diff options
| author | rillig <rillig> | 2006-03-12 13:34:53 +0000 |
|---|---|---|
| committer | rillig <rillig> | 2006-03-12 13:34:53 +0000 |
| commit | cdd70493d6215a203272d423aed3a21a284b6a0c (patch) | |
| tree | 4c985145086a210ed9d3c65e9bdc253f89e08ce5 /pkgtools/pkglint | |
| parent | b33ce9989ccb657f71050fe5a6f2f80bb9593785 (diff) | |
| download | pkgsrc-cdd70493d6215a203272d423aed3a21a284b6a0c.tar.gz | |
Added the BrokenIn data type. All BROKEN_IN lines generate an additional
note that tells the user to remove the line if the package builds.
Diffstat (limited to 'pkgtools/pkglint')
| -rw-r--r-- | pkgtools/pkglint/files/makevars.map | 4 | ||||
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 10 |
2 files changed, 11 insertions, 3 deletions
diff --git a/pkgtools/pkglint/files/makevars.map b/pkgtools/pkglint/files/makevars.map index fca923c9a22..840478c1d8e 100644 --- a/pkgtools/pkglint/files/makevars.map +++ b/pkgtools/pkglint/files/makevars.map @@ -1,4 +1,4 @@ -# $NetBSD: makevars.map,v 1.74 2006/03/11 18:38:35 rillig Exp $ +# $NetBSD: makevars.map,v 1.75 2006/03/12 13:34:53 rillig Exp $ # # This file contains the guessed type of some variables, according to @@ -49,7 +49,7 @@ BDB_LIBS Readonly BDB_TYPE Readonly BROKEN Message BROKEN_GETTEXT_DETECTION YesNo -BROKEN_IN List of { pkgsrc-2005Q4 } +BROKEN_IN List of BrokenIn BUILDLINK_CONTENTS_FILTER List of ShellWord # ^^ ShellCommand BUILDLINK_CFLAGS List+ of CFlag diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 29cda00bf3b..51d2cd6208d 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.547 2006/03/11 18:38:35 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.548 2006/03/12 13:34:53 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2882,6 +2882,14 @@ sub checkline_mk_vartype_basic($$$$$$$) { if ($type eq "AwkCommand") { $opt_debug and $line->log_warning("Unchecked AWK command: ${value}"); + } elsif ($type eq "BrokenIn") { + if ($value ne $value_novar) { + $line->log_error("${varname} must not refer to other variables."); + } elsif ($value =~ qr"^(\d\d\d\d)Q(\d)$") { + # Fine. + } + $line->log_note("Please remove this line if the package builds for you."); + } elsif ($type eq "BuildlinkDepmethod") { if ($value ne $value_novar) { # No checks yet. |