summaryrefslogtreecommitdiff
path: root/pkgtools
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2008-01-28 09:25:52 +0000
committerrillig <rillig@pkgsrc.org>2008-01-28 09:25:52 +0000
commit98ae096a666da43cca5ab695d0748a740fb331e0 (patch)
tree39072f64b22f48bd5004220bf84f7bd1da91e3af /pkgtools
parent5c15d8301b44021407f1a11d8066bc6b8f498301 (diff)
downloadpkgsrc-98ae096a666da43cca5ab695d0748a740fb331e0.tar.gz
Added Thomas' explanation for the "PKGREVISION must only be in Makefile"
error message.
Diffstat (limited to 'pkgtools')
-rw-r--r--pkgtools/pkglint/files/pkglint.pl8
1 files changed, 7 insertions, 1 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl
index 89bcf40ad04..a928e505092 100644
--- a/pkgtools/pkglint/files/pkglint.pl
+++ b/pkgtools/pkglint/files/pkglint.pl
@@ -1,5 +1,5 @@
#! @PERL@
-# $NetBSD: pkglint.pl,v 1.759 2008/01/28 01:18:13 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.760 2008/01/28 09:25:52 rillig Exp $
#
# pkglint - static analyzer and checker for pkgsrc packages
@@ -5397,6 +5397,12 @@ sub checkline_mk_vartype_basic($$$$$$$$) {
}
if ($line->fname !~ qr"(?:^|/)Makefile$") {
$line->log_error("${varname} must not be set outside the package Makefile.");
+ $line->explain_error(
+"Usually, different packages using the same Makefile.common have",
+"different dependencies and will be bumped at different times (e.g. for",
+"shlib major bumps) and thus the PKGREVISIONs must be in the separate",
+"Makefiles. There is no practical way of having this information in a",
+"commonly used Makefile.");
}
} elsif ($type eq "PlatformTriple") {