diff options
| author | rillig <rillig@pkgsrc.org> | 2006-10-17 21:42:46 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-10-17 21:42:46 +0000 |
| commit | 7b449192ed51b7bba431d32c1acc9753b128a976 (patch) | |
| tree | 07345f00b488517639b7cab8cb80edd43066ae17 /pkgtools | |
| parent | 0f4de084edd8575ea6837e571c33d6678746a9de (diff) | |
| download | pkgsrc-7b449192ed51b7bba431d32c1acc9753b128a976.tar.gz | |
The absolute pathname /bin/sh is allowed, despite the Solaris /bin/sh.
The WRKSRC variable (among others) is checked to consist of ony one
word. The url2pkg tool had created lines like
WRKSRC= ${WRKDIR}/Makefile PLIST distinfo
in the past, which happened to work in most cases up to now, but really
shouldn't.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 7 |
1 files changed, 6 insertions, 1 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 3319f48adb9..f7b58a9f7c8 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.680 2006/10/07 07:57:04 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.681 2006/10/17 21:42:46 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -3514,6 +3514,10 @@ sub checkword_absolute_pathname($$) { if ($word =~ qr"^/dev/(?:null|tty|zero)$") { # These are defined by POSIX. + } elsif ($word eq "/bin/sh") { + # This is usually correct, although on Solaris, it's pretty + # feature-crippled. + } elsif ($word !~ qr"/(?:[a-z]|\$[({])") { # Assume that all pathnames start with a lowercase letter. @@ -5312,6 +5316,7 @@ sub checkline_mk_vartype_basic($$$$$$$$) { } } elsif ($type eq "WrkdirSubdirectory") { + checkline_mk_vartype_basic($line, $varname, "Pathname", $op, $value, $comment, $list_context, $is_guessed); if ($value eq "\${WRKDIR}") { # Fine. } else { |