diff options
| author | rillig <rillig@pkgsrc.org> | 2006-04-13 01:57:35 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2006-04-13 01:57:35 +0000 |
| commit | 5ebd59d833ad48ef58d1f0bb318691d7e6378099 (patch) | |
| tree | 9e44855e532762f038d9a9d060986126e04ee46a /pkgtools | |
| parent | 3e514554d434d75104d3b193c0b09fb8f74f7034 (diff) | |
| download | pkgsrc-5ebd59d833ad48ef58d1f0bb318691d7e6378099.tar.gz | |
- The variables *_USER and *_GROUP don't need the :Q operator.
- Fixed a bug in the regular expression that detects sed(1) commands that
don't start with "-e".
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index d655c119811..36c8b773b01 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.555 2006/04/12 21:35:02 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.556 2006/04/13 01:57:35 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2069,7 +2069,7 @@ sub type_should_be_quoted($) { sub variable_needs_quoting($) { my ($varname) = @_; - return !($varname =~ qr"^(?:.*DIR|BUILDLINK_PREFIX\..*|DISTNAME|LOCALBASE|PKGNAME|PREFIX|WRKSRC)$"); + return !($varname =~ qr"^(?:.*DIR|.*_GROUP|.*_USER|BUILDLINK_PREFIX\..*|DISTNAME|LOCALBASE|PKGNAME|PREFIX|WRKSRC)$"); } my $check_pkglint_version_done = false; @@ -3262,7 +3262,7 @@ sub checkline_mk_vartype_basic($$$$$$$) { } elsif ($word eq "-n") { # Don't print lines per default. - } elsif ($i == 0 && $word =~ qr"^([\"']?)\d*s(.).*\2\1g?$") { + } elsif ($i == 0 && $word =~ qr"^([\"']?)\d*s(.).*\2g?\1$") { $line->log_warning("Please always use \"-e\" in sed commands, even if there is only one substitution."); } else { |