summaryrefslogtreecommitdiff
path: root/pkgtools
diff options
context:
space:
mode:
authorrillig <rillig@pkgsrc.org>2006-06-14 07:44:30 +0000
committerrillig <rillig@pkgsrc.org>2006-06-14 07:44:30 +0000
commita1701c2271261fd8a276981dc84b6ebddb0c9306 (patch)
treef4dec80df28f6c83d270b830c807620e63defad1 /pkgtools
parentabceb27ff16ef0f34b6a88a4454c322f69a02836 (diff)
downloadpkgsrc-a1701c2271261fd8a276981dc84b6ebddb0c9306.tar.gz
In pax(1) command lines, -pe is deprecated in favor of -pp.
Diffstat (limited to 'pkgtools')
-rw-r--r--pkgtools/pkglint/files/pkglint.pl10
1 files changed, 9 insertions, 1 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl
index eccec348e96..108a8988406 100644
--- a/pkgtools/pkglint/files/pkglint.pl
+++ b/pkgtools/pkglint/files/pkglint.pl
@@ -1,5 +1,5 @@
#! @PERL@
-# $NetBSD: pkglint.pl,v 1.619 2006/06/10 17:13:11 adrianp Exp $
+# $NetBSD: pkglint.pl,v 1.620 2006/06/14 07:44:30 rillig Exp $
#
# pkglint - static analyzer and checker for pkgsrc packages
@@ -3526,6 +3526,14 @@ sub checkline_mk_shelltext($$) {
"INSTALL_MAN_DIR, INSTALL_DATA_DIR.");
}
+ if ($state == SCST_PAX && $shellword eq "-pe") {
+ $line->log_warning("Please use the -pp option to pax(1) instead of -pe.");
+ $line->explain_warning(
+ "The -pe option tells pax to preserve the ownership of the files, which",
+ "means that the installed files will belong to the user that has built",
+ "the package. That's a Bad Thing.");
+ }
+
if ($state == SCST_PAX_S || $state == SCST_SED_E) {
if (false && $shellword !~ qr"^[\"\'].*[\"\']$") {
$line->log_warning("Substitution commands like \"${shellword}\" should always be quoted.");