diff options
| author | wiz <wiz@pkgsrc.org> | 2012-07-17 19:24:46 +0000 |
|---|---|---|
| committer | wiz <wiz@pkgsrc.org> | 2012-07-17 19:24:46 +0000 |
| commit | 17a655388300cf27ad1dac1e4b60fed8dc9cf6be (patch) | |
| tree | afaa813a3dde26a0e31fda4b40fbdcaa6da22429 /pkgtools | |
| parent | 14ace21090b52ea0a3d503d3c64279658447a1f6 (diff) | |
| download | pkgsrc-17a655388300cf27ad1dac1e4b60fed8dc9cf6be.tar.gz | |
Make missing comments in patches an error. Bump version.
The guide prescribes it for quite some time and it's common courtesy
for packages modifying packages after you.
ok gdt@
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 9777d6378b9..986536b55fb 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.841 2012/07/14 20:32:37 wiz Exp $ +# $NetBSD: pkglint.pl,v 1.842 2012/07/17 19:24:46 wiz Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -7415,12 +7415,12 @@ sub checkfile_patch($) { # }], [PST_TEXT, re_patch_cfd, PST_CFA, sub() { if (!$seen_comment) { - $line->log_warning("Comment expected."); + $line->log_error("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_TEXT, re_patch_ufd, PST_UFA, sub() { if (!$seen_comment) { - $line->log_warning("Comment expected."); + $line->log_error("Comment expected."); } }], [PST_TEXT, re_patch_text, PST_TEXT, sub() { $seen_comment = true; @@ -7432,14 +7432,14 @@ sub checkfile_patch($) { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - $line->log_warning("Comment expected."); + $line->log_error("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_CENTER, re_patch_ufd, PST_UFA, sub() { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - $line->log_warning("Comment expected."); + $line->log_error("Comment expected."); } }], [PST_CENTER, undef, PST_TEXT, sub() { $opt_warn_space and $line->log_note("Empty line expected."); |