diff options
| author | rillig <rillig@pkgsrc.org> | 2019-11-18 08:06:58 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2019-11-18 08:06:58 +0000 |
| commit | 6238c7d8aaa960f17b7b1d5f562a4d8821413fdf (patch) | |
| tree | 5d139527e0104b3280fcd9feab8ef86ba280e012 /pkgtools | |
| parent | ff7cb8b5df00ce7ccf03c3b5ab2f59509e4d42d9 (diff) | |
| download | pkgsrc-6238c7d8aaa960f17b7b1d5f562a4d8821413fdf.tar.gz | |
pkgtools/pkglint4: update to 4.193.2
Changes since 4.193.1:
Disabled unreliable check about possible typos in variable names. For
example, in pkgtools/url2pkg the variable TEST_DEPENDS was flagged even
though it is well-known.
Disabled unreliable check about unknown shell commands. For example, in
pkgtools/pkglint4 all commands from ${PREFIX} are ok, but were still
flagged.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint4/Makefile | 4 | ||||
| -rw-r--r-- | pkgtools/pkglint4/files/PkgLint/Shell.pm | 6 | ||||
| -rw-r--r-- | pkgtools/pkglint4/files/pkglint.pl | 6 |
3 files changed, 8 insertions, 8 deletions
diff --git a/pkgtools/pkglint4/Makefile b/pkgtools/pkglint4/Makefile index aa2da197fb8..2aae4e42e4e 100644 --- a/pkgtools/pkglint4/Makefile +++ b/pkgtools/pkglint4/Makefile @@ -1,6 +1,6 @@ -# $NetBSD: Makefile,v 1.14 2019/11/17 02:54:10 rillig Exp $ +# $NetBSD: Makefile,v 1.15 2019/11/18 08:06:58 rillig Exp $ -PKGNAME= pkglint4-4.193.1 +PKGNAME= pkglint4-4.193.2 CATEGORIES= pkgtools OWNER= rillig@NetBSD.org diff --git a/pkgtools/pkglint4/files/PkgLint/Shell.pm b/pkgtools/pkglint4/files/PkgLint/Shell.pm index 954870d48d7..816b9b07f69 100644 --- a/pkgtools/pkglint4/files/PkgLint/Shell.pm +++ b/pkgtools/pkglint4/files/PkgLint/Shell.pm @@ -1,4 +1,4 @@ -# $NetBSD: Shell.pm,v 1.3 2019/10/06 11:06:42 rillig Exp $ +# $NetBSD: Shell.pm,v 1.4 2019/11/18 08:06:59 rillig Exp $ # # Parsing and checking shell commands embedded in Makefiles # @@ -524,8 +524,8 @@ sub checkline_mk_shelltext($$) { } } else { - $opt_warn_extra and $line->log_warning("Unknown shell command \"${shellword}\"."); - $opt_warn_extra and $line->explain_warning( + 0 and $opt_warn_extra and $line->log_warning("Unknown shell command \"${shellword}\"."); + 0 and $opt_warn_extra and $line->explain_warning( "If you want your package to be portable to all platforms that pkgsrc", "supports, you should only use shell commands that are covered by the", "tools framework."); diff --git a/pkgtools/pkglint4/files/pkglint.pl b/pkgtools/pkglint4/files/pkglint.pl index 490c6546190..11ae4ab4a82 100644 --- a/pkgtools/pkglint4/files/pkglint.pl +++ b/pkgtools/pkglint4/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.10 2019/10/06 11:45:05 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.11 2019/11/18 08:06:58 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2249,7 +2249,7 @@ sub checkline_mk_varuse($$$$) { # Variables defined in .for loops are also ok. } else { - $opt_warn_extra and $line->log_warning("${varname} is used but not defined. Spelling mistake?"); + 0 and $opt_warn_extra and $line->log_warning("${varname} is used but not defined. Spelling mistake?"); } if ($varname eq "LOCALBASE" && !$is_internal) { @@ -3362,7 +3362,7 @@ sub checkline_mk_varassign($$$$$) { } elsif (exists($deprecated->{$varname}) || exists($deprecated->{$varcanon})) { # Ok } else { - $line->log_warning("${varname} is defined but not used. Spelling mistake?"); + 0 and $line->log_warning("${varname} is defined but not used. Spelling mistake?"); } } |