diff options
| author | rillig <rillig> | 2005-09-28 20:47:39 +0000 |
|---|---|---|
| committer | rillig <rillig> | 2005-09-28 20:47:39 +0000 |
| commit | 78122d314edeb82e3047dae09d03b73df8b70852 (patch) | |
| tree | c25d13735a7e21d04fad0410c5be44155434b009 /pkgtools | |
| parent | e3fdb40802c2142273827588e65eb7cbf8a3e507 (diff) | |
| download | pkgsrc-78122d314edeb82e3047dae09d03b73df8b70852.tar.gz | |
Updated pkglint to 4.23.2.
The use of "# defined" as variable value in Makefiles is deprecated. It
has too weak semantics, compared to "# none", "# empty" or "yes".
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/Makefile | 4 | ||||
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
2 files changed, 7 insertions, 3 deletions
diff --git a/pkgtools/pkglint/Makefile b/pkgtools/pkglint/Makefile index 79d5a1f5d57..4c116a9c5b8 100644 --- a/pkgtools/pkglint/Makefile +++ b/pkgtools/pkglint/Makefile @@ -1,7 +1,7 @@ -# $NetBSD: Makefile,v 1.257 2005/09/28 14:12:38 rillig Exp $ +# $NetBSD: Makefile,v 1.258 2005/09/28 20:47:39 rillig Exp $ # -DISTNAME= pkglint-4.23.1 +DISTNAME= pkglint-4.23.2 CATEGORIES= pkgtools devel MASTER_SITES= # empty DISTFILES= # empty diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 84cc4130899..1dc30c808ad 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -11,7 +11,7 @@ # Freely redistributable. Absolutely no warranty. # # From Id: portlint.pl,v 1.64 1998/02/28 02:34:05 itojun Exp -# $NetBSD: pkglint.pl,v 1.291 2005/09/28 14:12:38 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.292 2005/09/28 20:47:39 rillig Exp $ # # This version contains lots of changes necessary for NetBSD packages # done by: @@ -1507,6 +1507,10 @@ sub checklines_package_Makefile($) { $line->log_warning("COMMENT should not be longer than 70 characters."); } } + + if ($value eq "# defined" && $varname !~ qr".*_MK$") { + $line->log_warning("Please use \"# empty\", \"# none\" or \"yes\" instead of \"# defined\"."); + } } } |