diff options
| author | rillig <rillig> | 2006-01-12 10:39:30 +0000 |
|---|---|---|
| committer | rillig <rillig> | 2006-01-12 10:39:30 +0000 |
| commit | 573c54308a90d1898b19025376d60fe87803495b (patch) | |
| tree | 7fe9a086a5bb283025a049879ce7533fd0462dc8 /pkgtools | |
| parent | fad8a512564efda7da07f148b30aa29f704ca721 (diff) | |
| download | pkgsrc-573c54308a90d1898b19025376d60fe87803495b.tar.gz | |
- Defining and using make variables starting with an underscore is only
worth a warning, not an error. There are worse things at the moment that
need to be fixed.
Diffstat (limited to 'pkgtools')
| -rw-r--r-- | pkgtools/pkglint/files/pkglint.pl | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index cfaebba77cb..490d80b6e1b 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -w -# $NetBSD: pkglint.pl,v 1.465 2006/01/12 10:32:40 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.466 2006/01/12 10:39:30 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2676,7 +2676,7 @@ sub checkline_mk_varassign($$$$$) { checkline_mk_vartype($line, $varname, $op, $value, $comment); if (!$is_internal && $varname =~ qr"^_") { - $line->log_error("Variable names starting with an underscore are reserved for internal pkgsrc use."); + $line->log_warning("Variable names starting with an underscore are reserved for internal pkgsrc use."); } if ($varname eq "PERL5_PACKLIST" && defined($pkgname) && $pkgname !~ regex_unresolved && $pkgname =~ qr"^p5-(.*)-[0-9].*") { @@ -2981,7 +2981,7 @@ sub checklines_mk($) { foreach my $var (split(qr"\s+", $vars)) { if (!$is_internal && $var =~ qr"^_") { - $line->log_error("Variable names starting with an underscore are reserved for internal pkgsrc use."); + $line->log_warning("Variable names starting with an underscore are reserved for internal pkgsrc use."); } if ($var =~ qr"^[_a-z][_a-z0-9]*$") { |