diff options
| author | rillig <rillig@pkgsrc.org> | 2018-12-05 19:01:40 +0000 |
|---|---|---|
| committer | rillig <rillig@pkgsrc.org> | 2018-12-05 19:01:40 +0000 |
| commit | 1ef511e7b1f95132f739b15f53fb8f8218778f35 (patch) | |
| tree | 05f57475ee6b052d8cb02e32b59b102e7116f018 /regress | |
| parent | a1da0b01af5cd38587dc6ee4b6435992c39f80d4 (diff) | |
| download | pkgsrc-1ef511e7b1f95132f739b15f53fb8f8218778f35.tar.gz | |
regress/tools: clarify that only the NetBSD 7 shell exhibits this bug
The test has been changed again to fail since making the test pass would
mean this bug could later silently show up inside a large GNU configure
script where it would be impossible to find. Therefore, when using pkgsrc
on NetBSD 7, it is better to switch to another shell for doing pkgsrc
work.
The comment has been updated to be more accurate.
Diffstat (limited to 'regress')
| -rw-r--r-- | regress/tools/files/sh-test.sh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/regress/tools/files/sh-test.sh b/regress/tools/files/sh-test.sh index f349a1049ff..93cd2211d35 100644 --- a/regress/tools/files/sh-test.sh +++ b/regress/tools/files/sh-test.sh @@ -1,5 +1,5 @@ #! /bin/sh -# $NetBSD: sh-test.sh,v 1.2 2018/11/30 19:55:26 rillig Exp $ +# $NetBSD: sh-test.sh,v 1.3 2018/12/05 19:01:40 rillig Exp $ # set -e @@ -37,8 +37,8 @@ sh_assert_equals() { nl=" " -# This test fails with /bin/sh from 2018-11-08, see bin/53754. -if [ "`uname -s`" != "NetBSD" ]; then +# If this test fails because the result is "#define bindir \"", the +# tested shell may be from NetBSD 7.0, which is known to have this bug. +# Since NetBSD 8, this bug is fixed. See https://gnats.netbsd.org/43469. line="#define bindir \"/usr/bin\" /* bar */" sh_assert_equals "removing C comments" "#define bindir \"/usr/bin\" " "${line%%/\**}" -fi |