Update to 1.5.5.1, including a fix for PR 28216.

Changes since 1.5.1:

Post 1.5.5.1
The 1.5.5.1 package had wrong compiler flags. -g was switched on
while -O2 optimizations were off. Not a big deal, but I replaced
the package with a new one.

The next version's configure knows Cygwin and the Makefile knows
DESTDIR. Thanks to Yaakov Selkowitz for this and for the Cygwin
ports. :)

1.5.5.1
Obviously I failed to understand the arcane knowledge Unix signal
handling is made of. 1.5.5 creates zombies and fails to exit (hangs)
at least on OpenBSD. But I still claim that this is a bug in the
OS. Anyway, this release fixes just this one problem. If 1.5.5
works fine you don't need to upgrade.

1.5.5
I've fixed quite an amount of things in the HTTP and related code.
Torturing code with randomly generated crap is a fun method to find
problems. ;)

Cache file handling was also rewritten to avoid problems with
filesystems that don't like binary data in filenames very much. I
also fixed this on Cygwin where it was totally broken. Snownews
may now generate different hashes for the filenames than before so
some feeds may appear completely unread after upgrading in certain
cases.

Overall this release touched a lot of core code, should've probably
been 1.6.0. Ah well, have fun with the yellow chicken!

1.5.4.1
Make snownews work with gmail's atom feed.

1.5.4
    * Fixed some of the UTF-8 problems. Ncurses still doesn't seem
      to like what I do. Will solve this in a later version.
    * "Return to previous menu" and "quit" are now two different
      keys. Default bindings for both is still 'q' so it doesn't
      brake any previous behaviour, but if you want you can define
      different keys for it now.
    * The HTTP client now understands chunked transfer encoding.
      This was included from a patch for Liferea. Should be of rare
      use since only some broken proxy servers made it neccessary to
      support this.
    * I've update the Credits a bit. I know that I probably forgot
      to mention somebody, if you feel left out, let me know. ;) I
      will go over the file and my emails again for the next version.

    * I made the progress bars perfectly smooth. And much faster.
      The code wasted a lot of CPU cycles. The cookie loading still
      does the same, though. :P
    * The highlight bar and the status line cover the whole screen
      instead of n-1 columns now.
    * If an error during an update occurs the feedname that caused
      it is displayed in the status line as well. (Same goes for the
      error.log)

    * The code that determines read status of an item during an
      update now depends on the link and the title element. Feeds
      that have the same URL for all items should work better now.
    * Adding a feed now removes whitespaces from the beginning of
      the string so if you cut&paste " http://whatever" it'll work.
    * I added support for feed:// URLs. It's stupid, but seems to
      be used in the wild so I just give up.
    * The "HTML renderer" now decodes numerical entities all by
      itself (if supported by your C library) and uses libxml's
      htmlEntityLookup(). User defined entities are still checked
      first.

    * Stupid NULL ptr crash in the HTTP status parser.
    * Basic/Digest auth headers should be case insensitive.
    * Possible crash when deleting the "New Headlines" feed.
    * It is now possible to use URLs http://foo.com without a trailing slash.
    * Items in "New Headlines" had wrong feed name attached to them
      if you moved around feeds in the main menu.
    * No recursive adding of smartfeeds. And no extreme memory
      trashing in this case anymore.
    * UTF-16 and pure binary data can now be read. Anyone who wants
      to write a webcomic2aalib extension?

1.5.3

This version contains the following changes:
Prevent launching smartfeed:// URLs with the browser.
Configurable enter key broke type ahead a bit. Think I already mentioned this some time ago, no?
The "Downloading [feedname]" always shows the correct feed name now.
Finetuned display of HTML only feed descriptions a bit more.
Changed URL in user agent string to http://snownews.kcore.de/.
Error messages are now in full colour. :)
Many more errors are now written into the error.log file.

1.5.2

Not many new stuff since the beta1 version. Using filter extensions
works fine now, if you subscribe a feed that cannot be parsed you'll
be asked if you want to use a filter for this feed (=unsucked the
add a filter UI).  There was a problem with accessing memory that
didn't belong to us in xmlparse for strings exactly one byte long.
The feed download function behaved strangely sometimes due to some
thread safety issues. Never affected Snownews, only Liferea. Just
mentioned for completeness.  Snownews should also start up a bit
faster now if you have many feeds and a really slow system.

1.5.2beta2

Unfortunately 1.5.2-beta1 is a bit crashy if you use the (New
headlines) pseudo feed. Something's stompin on my internal database
which leads to inconsistent calculations of unread items in the
new headlines feed and the rest of the program. And ultimatively
to a segfault if you open the feed in this state. The patch below
fixes this. Also fixes obscure issues with smart feeds + caching,
makes HTTP auth via proxy work and fixes bugs with the feed reordering
in the main menu. Moved feeds had some of their internal data mixed
up with others. Specifically the last HTTP status reply, last
modification date and the data contentlength.


1.5.2beta1

The enter key has now a configurable key binding. So if you want
to have 'l' to select an item, it should work now.  Multi byte
characters are now handled correctly. Well, everywhere except in
the article (if provided) itself since the word wrap function still
doesn't like multi byte characters. Should work everywhere else if
you link against libncursesw.  I rewrote all of the build system.
Nothing fancy, but it's one single Makefile now and does not depend
on GNU make anymore. Building is probably broken on Solaris atm.
A feed that contains all new items from all your other feeds can
now be added by pressing 'H' in the main menu.  Filters and external
feed sources work now.

External sources:  Write a script/program that outputs RSS and you
can add it via an URL exec:/path/to/script. Snownews will execute
it everytime you refresh the feed/all feeds.  In short: [your
script] -> RSS -> Snownews

Filters:  You can subscribe to Atom, any other syndication format,
heck even HTML pages with this feature. All you need is a script
that converts whatever resource from the web to a valid RSS document.
The external script must accept data via stdin and write valid RSS
to stdout. Snownews will execute this filter everytime it downloads
a resource from the web. This automatically takes advantage from
Snownews' http features (last mod, gzip, auto redirect, etc.). To
use this, subscribe anything you want, ignore the parser errors,
press 'e' and enter the location of the filter you want to use,
refresh the feed.  In short: [resource on the web] -> Snownews ->
[your script] -> RSS -> Snownews

7 files changed, 37 insertions, 67 deletions

diff --git a/www/snownews/Makefile b/www/snownews/Makefile
index c955747fbd3..ac7e9f9f906 100644
--- a/www/snownews/Makefile
+++ b/www/snownews/Makefile
@@ -1,7 +1,6 @@
-# $NetBSD: Makefile,v 1.9 2004/10/03 00:18:27 tv Exp $
+# $NetBSD: Makefile,v 1.10 2004/11/20 00:30:29 wiz Exp $
 
-DISTNAME=	snownews-1.5.1
-PKGREVISION=	1
+DISTNAME=	snownews-1.5.5.1
 CATEGORIES=	www
 MASTER_SITES=	http://home.kcore.de/~kiza/software/snownews/download/
 
@@ -16,8 +15,8 @@ USE_GNU_TOOLS+=		make
 USE_NCURSES=		# missing WA_BOLD, WA_REVERSE, KEY_RESIZE
 USE_PKGLOCALEDIR=	YES
 
-MAKE_ENV+=	PKGLOCALEDIR="${PKGLOCALEDIR}" MAKE="${GMAKE}"
-MAKE_ENV+=	EXTRA_CFLAGS="${CFLAGS}" LOCALBASE="${LOCALBASE}"
+MAKE_ENV+=	PKGLOCALEDIR=${PKGLOCALEDIR:Q}
+MAKE_ENV+=	EXTRA_CFLAGS=${CFLAGS:Q} LOCALBASE=${LOCALBASE:Q}
 
 # XXX -lintl hack suggested by Jeremy C. Reed: blocking on PR #23369
 .include "../../devel/gettext-lib/buildlink3.mk"
@@ -26,13 +25,13 @@ MAKE_ENV+=	EXTRA_LDFLAGS="${LDFLAGS} ${BUILDLINK_LDADD.gettext}"
 do-install:
 	${INSTALL_PROGRAM} ${WRKSRC}/snownews ${LOCALBASE}/bin
 	${INSTALL_SCRIPT} ${WRKSRC}/opml2snow ${LOCALBASE}/bin
-.for M in de fr it nl
+.for M in de fr it nl ru_RU.KOI8-R
 	${INSTALL_DATA_DIR} ${LOCALBASE}/man/${M}/man1
 	${INSTALL_MAN} ${WRKSRC}/doc/man/${M}/snownews.1 ${LOCALBASE}/man/${M}/man1
 .endfor
 	${INSTALL_MAN} ${WRKSRC}/doc/man/snownews.1 ${LOCALBASE}/man/man1
 	${INSTALL_MAN} ${WRKSRC}/doc/man/opml2snow.1 ${LOCALBASE}/man/man1
-.for L in de es fr it nl sl zh_TW
+.for L in de es nl pt_BR ru sl zh_TW
 	${INSTALL_DATA_DIR} ${LOCALBASE}/${PKGLOCALEDIR}/locale/${L}/LC_MESSAGES
 	${INSTALL_DATA} ${WRKSRC}/po/${L}.mo ${LOCALBASE}/${PKGLOCALEDIR}/locale/${L}/LC_MESSAGES/snownews.mo
 .endfor
diff --git a/www/snownews/PLIST b/www/snownews/PLIST
index 965b1668117..9061127c628 100644
--- a/www/snownews/PLIST
+++ b/www/snownews/PLIST
@@ -1,4 +1,4 @@
-@comment $NetBSD: PLIST,v 1.2 2004/02/15 23:52:29 wiz Exp $
+@comment $NetBSD: PLIST,v 1.3 2004/11/20 00:30:29 wiz Exp $
 bin/opml2snow
 bin/snownews
 man/de/man1/snownews.1
@@ -7,11 +7,12 @@ man/it/man1/snownews.1
 man/man1/opml2snow.1
 man/man1/snownews.1
 man/nl/man1/snownews.1
+man/ru_RU.KOI8-R/man1/snownews.1
 ${PKGLOCALEDIR}/locale/de/LC_MESSAGES/snownews.mo
 ${PKGLOCALEDIR}/locale/es/LC_MESSAGES/snownews.mo
-${PKGLOCALEDIR}/locale/it/LC_MESSAGES/snownews.mo
-${PKGLOCALEDIR}/locale/fr/LC_MESSAGES/snownews.mo
 ${PKGLOCALEDIR}/locale/nl/LC_MESSAGES/snownews.mo
+${PKGLOCALEDIR}/locale/pt_BR/LC_MESSAGES/snownews.mo
+${PKGLOCALEDIR}/locale/ru/LC_MESSAGES/snownews.mo
 ${PKGLOCALEDIR}/locale/sl/LC_MESSAGES/snownews.mo
 ${PKGLOCALEDIR}/locale/zh_TW/LC_MESSAGES/snownews.mo
 @unexec ${RMDIR} %D/man/nl/man1 2> /dev/null || ${TRUE}
diff --git a/www/snownews/distinfo b/www/snownews/distinfo
index 454afb89c08..2cf183a6d8d 100644
--- a/www/snownews/distinfo
+++ b/www/snownews/distinfo
@@ -1,8 +1,6 @@
-$NetBSD: distinfo,v 1.4 2004/04/20 18:28:11 minskim Exp $
+$NetBSD: distinfo,v 1.5 2004/11/20 00:30:29 wiz Exp $
 
-SHA1 (snownews-1.5.1.tar.gz) = 328ec03c48d10bb434a22157725a9a1f2608e14f
-Size (snownews-1.5.1.tar.gz) = 111095 bytes
-SHA1 (patch-aa) = 05faea2cd77c2a92ab0f6d7238a2af3caa86d614
-SHA1 (patch-ab) = 70e30d145f673db2cb7b87568470b41179cb1a84
-SHA1 (patch-ac) = 224547ea2bf0a4565eaf48ae137a12c609fa7f2b
-SHA1 (patch-ad) = 2c8d9f5276ff7ff69f852ab7f18435cf9bf0f85d
+SHA1 (snownews-1.5.5.1.tar.gz) = 1efdb24e54a316f902ddd10af1652da2c4968756
+Size (snownews-1.5.5.1.tar.gz) = 139990 bytes
+SHA1 (patch-aa) = 33caf6cc7833691c6e503364a2efa9bee07831f4
+SHA1 (patch-ac) = 92a5b727c1626560058482a6f2b6a47f987bd5c0
diff --git a/www/snownews/patches/patch-aa b/www/snownews/patches/patch-aa
index 78ce458b2e0..03484e0fbf1 100644
--- a/www/snownews/patches/patch-aa
+++ b/www/snownews/patches/patch-aa
@@ -1,15 +1,13 @@
-$NetBSD: patch-aa,v 1.3 2004/04/09 00:04:23 wiz Exp $
+$NetBSD: patch-aa,v 1.4 2004/11/20 00:30:29 wiz Exp $
 
---- Makefile.inc.orig	2004-03-07 14:41:07.000000000 -0700
-+++ Makefile.inc
-@@ -1,8 +1,6 @@
--CC = gcc
--MAKE = make
- INSTALL = install
--PREFIX = /usr/local
--LOCALEPATH = $(PREFIX)/share/locale
-+PREFIX = $(LOCALBASE)
-+LOCALEPATH = $(PREFIX)/$(PKGLOCALEDIR)/locale
- DISTFILES = AUTHOR COPYING CREDITS Changelog README README.de README.colors README.patching INSTALL INSTALL.solaris INSTALL.FreeOpenNetBSD opml2snow \
- 	Makefile Makefile.inc Makefile.solaris \
- 	doc po scripts \
+--- interface.c.orig	2004-10-31 22:09:14.000000000 +0100
++++ interface.c
+@@ -1540,7 +1540,7 @@ void UIMainInterface (void) {
+ 					first_scr_ptr = first_ptr;
+ 					highlighted = first_ptr;
+ 					first_bak = NULL;
+-				} else if (highlighted->feedcategories != NULL) {
++				} else if ((highlighted != NULL) && (highlighted->feedcategories != NULL)) {
+ 					filters[0] = strdup (highlighted->feedcategories->name);
+ 					filteractivated = 1;
+ 				}
diff --git a/www/snownews/patches/patch-ab b/www/snownews/patches/patch-ab
deleted file mode 100644
index bcbd9eb4486..00000000000
--- a/www/snownews/patches/patch-ab
+++ /dev/null
@@ -1,13 +0,0 @@
-$NetBSD: patch-ab,v 1.3 2004/04/09 00:04:23 wiz Exp $
-
---- conversions.c.orig	2004-03-01 08:12:03.000000000 -0700
-+++ conversions.c
-@@ -37,7 +37,7 @@
- 
- extern struct entity *first_entity;
- 
--char * iconvert (char * inbuf, char * from, char * to) {
-+char * iconvert (const char * inbuf, char * from, char * to) {
- 	iconv_t cd;							/* Iconvs conversion descriptor. */
- 	char *outbuf, *outbuf_first;		/* We need two pointers so we do not lose
- 	                                       the strings starting position. */
diff --git a/www/snownews/patches/patch-ac b/www/snownews/patches/patch-ac
index 724f3d56c77..b0553856cef 100644
--- a/www/snownews/patches/patch-ac
+++ b/www/snownews/patches/patch-ac
@@ -1,13 +1,13 @@
-$NetBSD: patch-ac,v 1.3 2004/04/09 00:04:23 wiz Exp $
+$NetBSD: patch-ac,v 1.4 2004/11/20 00:30:29 wiz Exp $
 
---- Makefile.orig	2004-03-07 14:41:07.000000000 -0700
+--- Makefile.orig	2004-11-11 16:23:02.000000000 +0100
 +++ Makefile
-@@ -2,7 +2,7 @@ include Makefile.inc
+@@ -1,7 +1,5 @@
+-CC=         gcc
+-MAKE=       make
+ INSTALL=    install
+-LOCALEPATH= $(PREFIX)/share/locale
++LOCALEPATH= $(PREFIX)/${PKG_LOCALEDIR}/locale
  
- LDFLAGS = -lncurses `xml2-config --libs` $(EXTRA_LDFLAGS)
- OBJFILES = main.o netio.o interface.o xmlparse.o updatecheck.o conversions.o dialog.o ui-support.o categories.o about.o cookies.o setup.o net-support.o digcalc.o md5.o filters.o
--CFLAGS = -Wall -O2 -DLOCALEPATH="\"$(LOCALEPATH)\"" -DOS=\"$(shell uname)\" `xml2-config --cflags` $(EXTRA_CFLAGS)
-+CFLAGS = -Wall -DLOCALEPATH="\"$(LOCALEPATH)\"" -DOS=\"$(shell uname)\" `xml2-config --cflags` $(EXTRA_CFLAGS)
- VERSION = `grep VERSION version.h | sed s/\"//g | sed s/\#define\ VERSION\ //`
- MAN = doc/man
- DISTDIR = snownews-$(VERSION)
+ ### Compiler/linker flags   ###
+ ### Generated via configure ###
diff --git a/www/snownews/patches/patch-ad b/www/snownews/patches/patch-ad
deleted file mode 100644
index d849d2e865a..00000000000
--- a/www/snownews/patches/patch-ad
+++ /dev/null
@@ -1,13 +0,0 @@
-$NetBSD: patch-ad,v 1.2 2004/04/20 18:28:11 minskim Exp $
-
---- conversions.h.orig	2004-03-07 15:41:07.000000000 -0600
-+++ conversions.h
-@@ -23,7 +23,7 @@
- #ifndef CONVERSIONS_H
- #define CONVERSIONS_H
- 
--char * iconvert (char * inbuf, char * from, char * to);
-+char * iconvert (const char * inbuf, char * from, char * to);
- char * UIDejunk (char * feed_description);
- char * WrapText (char * text, int width);
- void *zlib_uncompress(void *in_buf, int in_size, int *out_size, int voodoo_magic);