diff options
| author | hasso <hasso@pkgsrc.org> | 2009-06-16 16:09:36 +0000 |
|---|---|---|
| committer | hasso <hasso@pkgsrc.org> | 2009-06-16 16:09:36 +0000 |
| commit | 46ae629b542952ac92914129ae44bdc1579fa043 (patch) | |
| tree | efd216f3f5e6548a11c887b81dfe48a741f74295 /x11/kdelibs3 | |
| parent | 9a9d45a978ffdbf2f8f13ddc4333c49730ee16c6 (diff) | |
| download | pkgsrc-46ae629b542952ac92914129ae44bdc1579fa043.tar.gz | |
Fix a serious security issue for platforms using kgrantpty (NetBSD isn't
such, but DragonFly is): ${SETUID_ROOT_PERMS} doesn't work for suid
kgrantpty, because the locate() method used to find the path to the binary
expects it to have a read permissions set.
Diffstat (limited to 'x11/kdelibs3')
| -rw-r--r-- | x11/kdelibs3/Makefile | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/x11/kdelibs3/Makefile b/x11/kdelibs3/Makefile index 5a46288c3c2..b19ff201593 100644 --- a/x11/kdelibs3/Makefile +++ b/x11/kdelibs3/Makefile @@ -1,6 +1,7 @@ -# $NetBSD: Makefile,v 1.140 2008/08/27 12:02:31 markd Exp $ +# $NetBSD: Makefile,v 1.141 2009/06/16 16:09:36 hasso Exp $ DISTNAME= kdelibs-${_KDE_VERSION} +PKGREVISION= 1 CATEGORIES= x11 COMMENT= Support libraries for the KDE integrated X11 desktop @@ -57,9 +58,12 @@ SUBST_FILES.kdemagic= kio/magic SUBST_SED.kdemagic= -n -e 'p' -e 's:/usr/local/bin:${LOCALBASE}/bin:p' SPECIAL_PERMS+= ${PREFIX}/bin/fileshareset ${SETUID_ROOT_PERMS} -SPECIAL_PERMS+= ${PREFIX}/bin/kgrantpty ${SETUID_ROOT_PERMS} SPECIAL_PERMS+= ${PREFIX}/bin/kpac_dhcp_helper ${SETUID_ROOT_PERMS} +# ${SETUID_ROOT_PERMS} doesn't work here because the locate() method used to +# find the path to the kgrantpty expects it to have read permissions set. +SPECIAL_PERMS+= ${PREFIX}/bin/kgrantpty ${REAL_ROOT_USER} ${REAL_ROOT_GROUP} 4555 + .include "options.mk" PLIST_VARS+= kded |