summaryrefslogtreecommitdiff
path: root/mk
AgeCommit message (Collapse)AuthorFilesLines
2020-06-18mk: do not check vulnerability when just fetching distfileswiz1-2/+2
This is intended to reduce the log output on ftp.NetBSD.org when fetching all distfiles. Also, we call the target in basically every step of package creation (extract, patch, configure, build, install, package) - perhaps we should trim this down some more.
2020-06-16mk/subst.mk: SUBST_NOOP_OK defaults to yes againrillig1-2/+2
There are still some packages that fail the strict SUBST check. These packages should nevertheless be built using the default pkgsrc configuration, at least in the stable 2020Q2 branch. After 2020Q2 has been switched, the strict SUBST checks will be activated again in the default configuration.
2020-06-13mk/configure: Replace SET(CMAKE_MODULE_PATH... like 'set' too.ryoon1-2/+4
This will break print/scribus-qt4. It uses CMAKE_MODULE_PATH as not a directory list. It is wrong assumption.
2020-06-12mk/build/build.mk: use SH for the shell in build-envrillig1-3/+3
Providing a realistic build environment has priority over having a convenient shell with auto-completion and all the likes.
2020-06-11mk/subst.mk: remove unnecessary SUBST_VARS definitionrillig1-2/+1
This is a package-settable variable, and if a package leaves it undefined, "bmake show-all-subst" should show exactly this.
2020-06-11mk/subst.mk: document the unspecified application orderrillig1-1/+2
To avoid bmake warnings because of duplicate class names, the :O:u modifier had been added in r1.66 on 2020-03-21. This had the side effect that the subst classes are now applied in alphabetical order instead of declaration order. For this to actually matter, there must be a file that is affected by two different subst classes and in which the substitutions depend on each other or prevent each other. Chances for that are pretty low. The order is intentionally documented as being unspecified, to allow for future modifications, just in case that a bmake variable modifier is invented that filters for duplicates without requiring the duplicates to be adjacent to each other. In that situation, it would be nicer to switch back to declaration order instead of alphabetical.
2020-06-11mk/subst.mk: fix local variable namesrillig1-8/+8
These variables don't record whether a file is changed but instead whether a pattern was found.
2020-06-11mk/subst.mk: always remove temporary filerillig1-6/+4
Fixes PR pkg/55364.
2020-06-10mk/plist: Add EARLY_PRINT_PLIST_AWKleot2-4/+11
EARLY_PRINT_PLIST_AWK is like PRINT_PLIST_AWK but operates before the file/directory lists are sorted. Discussed on tech-pkg@ mainly to address `print-PLIST' order problems for Python 3 packages: <https://mail-index.NetBSD.org/tech-pkg/2020/05/27/msg023249.html>
2020-06-07bsd.buildlink3.mk: add ABI_DEPENDS and API_DEPENDS to show-all-bl3rillig1-3/+17
2020-06-07mk/check/check-portability.mk: remove leaked debug coderillig1-2/+1
Thanks jperkin@.
2020-06-07mk/configure/replace-interpreter.mk: clean up show-all-interp variablesrillig1-4/+3
2020-06-07mk/check/check-portability.mk: use predefined toolsrillig1-3/+5
Just in case any of these tools defines some command line arguments. The correct path had already been used before since both env and sh are added to USE_TOOLS in bsd.pkg.mk.
2020-06-07mk/bsd.prefs.mk: add PKG_DBDIR to show-all-dirsrillig1-1/+2
2020-06-07mk/.../metadata.mk: properly clean up loops after removing ""rillig1-3/+1
There is no evidence that any shell needs the empty string literal in 'for i in "" $var' to loop over a simple variable. This would only be necessary if the shell code were generated by a preprocessor such as bmake or autoconf, and the list of items might end up empty. In such a case, the empty string literal prevents to generate 'for i in ; do', which would produce a syntax error.
2020-06-06mk/bsd.options.mk: remove redundant assignment to PKG_OPTIONSrillig1-5/+3
This assignment has popped up various times in the pkglint output, even though it is defined in the infrastructure and not in a specific package. Since there is no need to have this duplicate assignment, it is removed.
2020-06-06mk/bsd.options.mk: document variables in the canonical orderrillig1-5/+5
2020-06-06mk/subst.mk: fix wrong SUBST failure in mail/policyd-weightrillig1-8/+15
The general rule is that a SUBST_SED that contains _any_ identity substitution may leave files unmodified, no matter if there are other substitutions as well.
2020-06-06mk/.../metadata.mk: fix reference to undefined shell variablerillig1-4/+5
When RUN includes the -u shell option (see the pkgsrc guide, section bulk.var.shvar), there is a stray "requires: parameter not set" error. This error doesn't make the build fail immediately since it is on the left-hand side of a pipe, where the exit status is ignored. It would fail if the shell for bmake were set to bash and its option "pipefail" were enabled.
2020-06-05mk, doc: remove obsolete bulk-install and bulk-package targetsrillig1-3/+3
2020-06-03subst.mk: Move hint about find to package-settable sectiongdt1-5/+4
2020-06-02subst.mk: Give hint abotu SUBST_NOOP_OKgdt1-2/+3
Note that a typical reason to need this is using find to generate a list of files.
2020-06-02mk: bmake cannot compare non-integers numerically.jperkin1-2/+2
Just use an empty() match instead.
2020-06-02mk/defaults: Add 'mouse' optionsjmulder1-0/+1
Used already in sysutils/nnn but forgot to commit options.description.
2020-06-02mk/compiler.mk: check for too late GCC_REQD and USE_LANGUAGESrillig2-2/+21
For USE_LANGUAGES there is already a pkglint warning, but for GCC_REQD it is missing. It's better to have this check directly in the infrastructure since it is more reliable. This check is disabled by default, to not cause any new breakage. It should be enabled in bulk builds.
2020-05-31options.description: add "keyring" optiongutteridge1-0/+1
2020-05-31mk/compiler: Set -fcommon for GCC 10sjmulder1-1/+4
As with clang. Default got flipped with v10.
2020-05-30mk/compiler: Fix version check for GCC 10sjmulder1-2/+2
Caused SSP flags to be omitted in GCC 10. Check flipped because all new GCC versions can be expected to support it.
2020-05-30mk/defaults/options.description: remove trailing whitespacerillig1-2/+2
2020-05-30Typokhorben1-2/+2
2020-05-28Flip the switch on ALLOW_VULNERABLE_PACKAGES to allow them by default.maya3-21/+23
Right now, users who install the pkg-vulnerabilities database find that the vast majority of packages fail to build, penalizing them too severely. Package auditing can still be done via "pkg_admin audit". Alternatively, the previous behaviour can be restored with ALLOW_VULNERABLE_PACKAGES=no in mk.conf. Additionally, bmake-ify the check.mk logic. It was easier to do this, as the package relied on a single long ${RUN} command. Proposed on tech-pkg, with no objections to the idea of changing the default, just the method of doing so.
2020-05-28mk/tools: not all linuxes have bash (e.g. alpine)nia1-1/+3
2020-05-25options.description: "firefox" is also no longer an optiongutteridge1-1/+0
2020-05-25options.description: +2 missing entries, -1 no longer usedgutteridge1-1/+2
2020-05-23mk/configure: fix configure options check for custom CONFIGURE_SCRIPTrillig1-3/+6
Seen in cross/arm-none-eabi-gdb.
2020-05-23MySQL 5.5 and PostgreSQL 9.4 are no longer with usadam2-22/+5
2020-05-22mk/configure: fix check for unknown configure optionsrillig1-2/+2
2020-05-22Add a missing redirect to ensure that all files are picked up forjoerg1-1/+2
hashing.
2020-05-21mk/configure: remove outdated documentationrillig1-6/+1
2020-05-21mk/configure: add variable GNU_CONFIGURE_QUIETrillig1-1/+13
This allows bulk builds or other setups to see interesting error messages, without them being hidden in the noise of "checking ...".
2020-05-21mk/pkgformat/metadata.mk: fix relative paths in PATCHDIR and FILESDIRrillig1-4/+4
Before, relative paths had been stored as-is. This affected those packages that defined PATCHDIR or FILESDIR as relative directory instead of prefixing it with ${.CURDIR}. Since there are already several other paths that are interpreted relative to the package directory (CONFLICTS, DEPENDS), allow PATCHDIR and FILESDIR to be specified as relative paths, too. This makes the package Makefiles a bit shorter.
2020-05-21mk/configure/gnu-configure.mk: disable built-in option checkrillig1-4/+2
The rewritten check for unknown configure options already checks for options that are not defined anywhere. After that, the configure scripts don't need to check for these options anymore since all remaining options are known to the package, in at least one of its configure scripts.
2020-05-21mk/configure: completely rewrite check for unknown configure optionsrillig2-95/+42
The previous implementation could not reliably detect outdated configure options. This was apparent in devel/gettext-tools, where the option --with-included-libcroco had become unknown between May 2019 and May 2020, but the check was not run. The behavior is the same in the pkgsrc default configuration. Only if GNU_CONFIGURE_STRICT=yes, the new check is activated and will make packages fail that previously succeeded to build. Since that variable is not widely known, there won't be much sudden breakage, if any.
2020-05-18mk/configure/replace-interpreter.mk: silently skip broken symlinksrillig1-5/+5
Like directories, they probably come from shell globs. Seen in misc/byobu.
2020-05-17g/c references to openjdk7tnn1-23/+4
2020-05-16mk/subst.mk: change default value for SUBST_NOOP_OK from yes to norillig1-20/+23
This makes the SUBST blocks stricter than before, to detect outdated or unnecessary definitions. Filename patterns that are not affected by any of the SUBST_SED expressions make the build fail. It is still ok if only some of the files from a pattern are affected and some aren't. The latest bulk build shows that most of the build failures are fixed. The packages that fail in that build are mostly due to other failures, like missing C headers, wrong PLIST files, unresolved references at link time. There may be a few packages that still fail because of this, but these are near the leaves of the dependency tree. https://mail-index.netbsd.org/pkgsrc-bulk/2020/05/14/msg018919.html
2020-05-16mk/subst.mk: properly detect s,a,a,1 as identity substitutionrillig1-2/+2
Seen in games/bastet. The 1 is not necessary though since it only repeats the default behavior of sed.
2020-05-15pkg_create -U doesn't do anything, don't pass the flag.maya1-2/+2
2020-05-15mk/defaults: Revert PKG_DEVELOPER default change for nownia1-2/+3
2020-05-15mk/defaults: Switch PKG_DEVELOPER on by default.nia1-4/+3
Bulk builds with PKG_DEVELOPER set have been the status quo for a while. Every package in pkgsrc has to be expected to build with this.