summaryrefslogtreecommitdiff
path: root/pkgtools/pkglint
AgeCommit message (Collapse)AuthorFilesLines
2005-03-07update pkglint to 4.09:abs2-6/+10
Handle ! in .if conditionals, plus move slightly closer to the real 'make's behaviour when using defined() and empty(). Should fix pkg/28346
2005-02-24Minor wording changes. Fixed a bug. (The string "$line->text" does not callrillig2-10/+8
the method text() on $line, so I had to get the method call out of the string quotes. Approved by jlam.
2005-02-234.07: Use correct variable in workdir-cleanup warning.wiz2-4/+4
2005-02-21Claim maintainership.wiz1-2/+2
2005-02-21Sign over maintainership to tech-pkg@hubertf1-2/+2
2005-02-17Included the location of the warning or error in the messages forrillig2-33/+30
everything except Makefiles. (Makefiles which will follow soon.) This makes most warnings more useful. Together with the last few changes, we are now at version 4.06. Approved by wiz.
2005-02-16Rewrote the readmakefile routine. Now pkglint runs faster, and the logrillig1-55/+26
messages are formatted nicer. It produces more (reasonable) warnings, but also some more false positives. Did not increase DISTNAME, as the change is not yet big enough. Approved by wiz.
2005-02-16Changed the message about sorting PLIST files from FATAL to WARNING.rillig1-2/+2
Approved by wiz.
2005-02-15pkgtools/pkglint: Added checks for proper quoting of shell variablesrillig2-17/+26
($ vs. $$). Welcome to 4.05. Approved by wiz.
2005-02-14Make file(1) happy about plist-clash.pl. Fixes PR#29366 by Akio OBATA.cube2-4/+3
Welcome to version 4.04.
2005-02-12Pkglint now checks that the file entries in PLIST files are correctlyrillig2-4/+13
sorted. Welcome to 4.03.
2005-02-12Added type checking for Makefile variables. The typechecking isrillig1-1/+2
experimental and has been announced on tech-pkg to make the package developers aware of it.
2005-02-12Added type checking for Makefile variables. The typechecking isrillig3-5/+142
experimental and has been announced on tech-pkg to make the package developers aware of it.
2005-02-11Fixed bug in checkline_trailing_whitespace. No warnings were emittedrillig2-4/+6
before. Stripped non-leading "." path components in the log messages. Welcome to 4.01.
2005-02-05Another fix for python and ruby packages, this time for installed ones.wiz2-4/+12
Standardize the prefix so they can be compared with the packages more easily (pkg_chk is better at this anyway, but since I fixed the other cases already...). Welcome to 4.00!
2005-02-04Update to 3.99:wiz2-7/+20
Fix lintpkgsrc handling of python and ruby packages. Remove invalid-dewey test that broke more things than it helped. Add support for "pre" in version strings. Update comment about recognised strings.
2005-02-04regen.wiz1-33/+33
2005-02-04Sort option descriptions in man page.wiz1-38/+38
2004-12-27There is no -d option; remove it from the usage.wiz1-2/+1
Closes PR 28788 by Berndt Josef Wulf.
2004-12-023.98: Teach pkglint about BUILD_TARGET, and let it warn about ALL_TARGET.wiz2-5/+9
2004-11-09Report trailing slash of the package directory part of *_DEPENDS specificationseb2-3/+6
as a fatal error as this greatly confuses mk/scripts/mkdatabase. Update to version 3.97.
2004-11-04Ignore use of words which when used in make shell commands shouldhe2-3/+6
be used in variable-expansion version, e.g. `test' vs `${TEST}' in settings of TEST_TARGET and ALL_TARGET. Gets rid of warning about "test" in TEST_TARGET setting from lang/perl5/module.mk. Bump package version. Reviewed by wiz.
2004-11-04Test if pkgname is defined before using it; gets rid of some warnings:wiz2-4/+4
Use of uninitialized value in pattern match (m//) at /usr/pkg/bin/lintpkgsrc line 747. Patch from Nicolas Joly in PR 27875.
2004-10-28Add - and . to characters allowed in patch names. Welcome to 3.94.wiz2-4/+4
2004-10-16Correct file name for the package vulnerabilities.he1-2/+2
2004-10-16Update to 3.93, from Roland Illig:wiz3-46/+50
- Renamed PORTSDIR to PKGSRCDIR - Added warning option -Wno-workdir - Fixed some places where absolute and relative pathnames had been used incorrectly. Clean up Makefile.
2004-10-15Update to 3.92:wiz2-3/+9
Include each .include'd file only once. Solves the 'Out of memory!' problem for big packages, and avoids repeated warnings about problems coming from bl3 or Makefile.common files. From Roland Illig in private mail.
2004-10-07* Make PKGSRC_TOPDIR a private variable by renaming it to _PKGSRC_TOPDIR,jlam1-3/+3
as it's only used internally by bsd.prefs.mk. * Make _PKGSRCDIR a public variable by renaming it to PKGSRCDIR. Also, generate its value from ${_PKGSRC_TOPDIR} so it's less fragile than the old method of stripping off the last two components of ${.CURDIR}. PKGSRCDIR may now be used after bsd.prefs.mk is defined. * Change all references to _PKGSRCDIR to PKGSRCDIR.
2004-09-243.91:wiz3-87/+307
- added options for enabling/disabling specific checks - added options for enabling/disabling specific warnings - improved the --help message and corresponding man page updates. From Roland Illig with slight fixes by me.
2004-09-05Update to version 3.90. Lintpkgsrc package version comparison bug fix.seb2-10/+20
When comparing two version numbers vector the shorter one needs to be extended with 0. Cf. src/usr.sbin/pkg_install/lib/str.c:vtest(). Previously lintpkgsrc considered that 'png-1.2.6', which version vector is [1,0,2,0,6], is "less" than 'png-1.2.6rc1', which version vector is [1,0,2,0,6,-1,1]. No wonder lintpksrc -V considered the package png-1.2.6 being vulnerable wrt the 'png<1.2.6rc1' entry in pkg-vulnerabilities files. While here teach lintpkgsrc about the 'alpha' and 'beta' version elements.
2004-08-24Apply two patches from Roland Illig:wiz2-33/+30
First two chunks of diff: Fix for perl-5.6.1; addresses PR 26718. Remainder: - made $category a local variable of checkfile_Makefile - redefined the meaning of the return value of the check_* subs (siehe Zeile 37 des Patches) Welcome to 3.89.
2004-08-11Another refactoring patch from Roland Illig:wiz1-86/+136
more oop; move line functions into own module.
2004-08-10Another refactoring patch from Roland Illig applied.wiz1-71/+103
2004-08-08Apply patch from Roland Illig, in private mail:wiz1-63/+92
- replaced literal "1" and "0" by "true" and "false" where appropriate No functional change, thus no PKGREVISION bump.
2004-07-14Update to 3.88:wiz2-11/+13
Fix some bugs wrt MESSAGE and PLIST checking. From Roland Illig in private mail.
2004-07-10agc says we do not want binary mode files in the pkgsrc repository, sosnj2-4/+4
let's not suggest using -ko. Welcome to 3.87.
2004-07-09Code cleanup, by Roland Illig. More to come.hubertf2-137/+142
Bump to 3.86.
2004-07-06Look for buildlink3 instead of 2, and complain about USE_BUILDLINK2 beingwiz2-10/+14
set. Welcome to 3.85!
2004-07-01Update pkglint 3.84abs2-46/+57
Parse Make .{if,endif,else,elif,include} directives which contain a space between the . and the directive. Fix an include path issue which this threw up. Now 'lintpkgsrc -d' correctly extracts the PKGNAMEs for the gcc3 packages. It still doesn't understand 'dewey' versions with alpha chars, or some of the more interesting makefile constructs, but it looks closer to reality.
2004-06-30Update pkglint to 3.83. Changes:hubertf2-347/+342
- made the program compile with "use strict" - completely rewrote some subs to make the code more readable - converted the global ("local") variables into local ("my") ones ;-) - limited the scope of variables where possible - added file and line number to the error messages where possible Patch contributed by Roland Illig in private mail.
2004-06-28Update to 3.82, committing yesterday's changes from Roland Illig.hubertf2-89/+124
Changes: - Handle a rarely used patch format correctly - Do not output superflouus linebreaks anymore - Check the contents of the COMMENT field only if it exists - Handle invalid dependency specifications correctly - Correctly handle Makefile variables ordering - Output complete filename of absolute filenames - Added a new scheme for loading text files into memory so that the location of an error or warning can be given exactly (file + line) to the user. - Refactored the checkfile_patches_patch subprogram to use the new text file processing and to make clearer what is checked.
2004-06-28Update pkglint to 3.81abs2-11/+18
- Rework undefined variable handling. Fixes issue introduces in 3.80 - Never run a pkg_info in pkgdistdir. Avoids a serious misfeature of pkg_info whereby it looks for a package in the current directory by default.
2004-06-27Update pkglint to 3.80. Changes to lintpkgsrc.abs2-12/+18
- Append appropriate dirs to path - should fix pkg/23534 - Undefined variables evaluate to blank not UNDEFINED - should fix pkg/24475 - Handle ${C and ${S constructs that use separators other than / - Slightly more debugging - die if uname fails
2004-06-26Update to pkglint 3.79hubertf2-491/+531
== functional changes == - prints the various "OK: ..." messages only when called with "-v". - prints a summary after pkgsrc category checks - fixed a bug for commented category entries (in line 1718) - removed the option "-q". It has become unnecessary == refactoring == - more consistent naming scheme for variables and functions - replaced some "local" with "my" when possible - clustered the variables that are processed by the ${SED} commands - provided function prototypes for argument checking - replaced the old perror by log_{error,warning,info}. - Avoided the (implicit or explicit) use of $_ in many places Patch contributed by Roland Illig via private mail.
2004-06-25Commit patch from PR 25222 by Roland Illig:hubertf2-22/+65
* use strict mode (already found one error... hi wiz!) * add -q (quiet) flag * Identifie if patch files don't patch any or more than one file
2004-06-06Warn if a file is marked executable. Welcome to 3.77.schmonz2-4/+30
It's misleading to have uninstalled rc.d scripts in ${FILESDIR} marked executable just because they were inadvertently committed that way; they need to be processed by the install machinery in order to work. Since we set desired permissions at install time, it's generally best to avoid having "executable" files in pkgsrc (with the notable exception of pkglocate, which runs in place). For files not yet committed, please correct the permissions before committing. For files already in the repository, you'll need help from an administrator.
2004-05-13Back out changes made in 3.75, it's too slow for lintpkgsrc. Make it 3.76.salo2-4/+4
2004-05-10Welcome to 3.75.salo2-4/+4
Use real value of PKGNAME, suppress bogus warnings when PKGNAME is created from altering DISTNAME with make modifiers (e.g., S or C).
2004-05-10The existence of the kde-i18n-sr@Latn pkg makes it clear that _pkgatatat2-5/+7
also needs escapement treatment so that the eval doesn't barf. Since _ver is the only thing left, do that one, too. This makes 3.74.
2004-05-09Resurrect do-extract target, following atatat's advice.jschauma1-3/+8
This way, sources are extracted first as any other package, allowing for local patches.