Age | Commit message (Collapse) | Author | Files | Lines |
|
white-space.
Instead of including intltool/buildlink3.mk directly, a simple
USE_TOOLS+=intltool suffices.
|
|
|
|
|
|
Takayoshi in a private mail.
|
|
|
|
mark a package as not being able to build, due to some fatal error. I
don't see any reason _not_ to use PKG_FAIL_REASON in those cases.
|
|
|
|
|
|
|
|
|
|
(Requested in PR 34920.)
The warning about uncommitted patch files only appears when the distinfo
file is already committed.
|
|
${PREFIX}/${PKGMANDIR} is preferred over ${PREFIX}/man.
{ONLY,NOT}_FOR_PLATFORM may appear multiple times in the package
Makefile.
|
|
|
|
|
|
code.
|
|
|
|
The WRKSRC variable (among others) is checked to consist of ony one
word. The url2pkg tool had created lines like
WRKSRC= ${WRKDIR}/Makefile PLIST distinfo
in the past, which happened to work in most cases up to now, but really
shouldn't.
|
|
|
|
committed to CVS, a warning is printed.
|
|
hand-tuning the directories where KDE files are installed.
|
|
|
|
Added an explanation for why ${DESTDIR}/foo is considered an absolute
pathname.
|
|
- Handle 'badly named' patch files
- In the event of a distint checksum mismatch, report the affected file
as well as package
- If we need to call out to make to parse a makefile and it returns any
errors, ensure we prefix the error output with the Makefile path
- run through perltidy. Ugly, but consistent
|
|
|
|
|
|
|
|
Since many package fail to build in exotic environments because of that,
it is worth having this check even though we are currently in a freeze.
Improved the detection of absolute pathnames once more.
|
|
took about 300 MB of memory. Now it takes 27 MB, which is still much,
but quite better.
The cause for the memory leak was that I wrote
my ($result) = @_;
instead of
my ($result) = ($1);
after successfully matching a regular expression. That way, pkglint
created some cyclic data structures, and since Perl does not have
garbage collection, these didn't get cleaned up.
Added some checks so that this cannot easily happen again. Also fixed
some other instances where @_ appeared in the source code.
|
|
Changes since 4.68:
- Improved the checks for BUILD_DEFS.
- Improved the shell word parser.
- Improved the heuristics for detecting absolute pathnames.
- The :M* operator is only required with GNU configure scripts.
Committed during the freeze to have a unique version number that includes
the features from the last days.
|
|
configure script.
|
|
|
|
* Check all the shell commands to see if they are mentioned in USE_TOOLS.
|
|
Not only CFLAGS, but also {FOO}_CFLAGS should be passed through the :M*
operator before being passed to the shell.
|
|
internal error showing up in benchmarks/netio.
|
|
reasonably well. In the first pass, all variables that are added to
BUILD_DEFS are collected, and in the second pass it is checked whether
any remaining user-defined variables are used but have not been added to
BUILD_DEFS. This way, it does not matter in which order the variables
appear in the files.
|
|
shell parser to correctly handle ${WRKSRC.${d}}, which appears for
example in geography/epsg.
Avoided an internal fatal error for files that contain RCS conflicts.
|
|
Changes since 4.67:
- Adjusted to the ongoing changes in the pkgsrc infrastructure.
- Many small improvements in the makevars.map file.
- Stricter checking of dependency patterns, to catch foo-*.
- Small improvement on the use of stack space due to complicated regular
expressions.
- Many more absolute pathnames are found in patch files, no matter which
type of file is patched.
- All user-defined variables that are used should be added to BUILD_DEFS.
- All packages that set GNU_CONFIGURE are assumed to need a C compiler.
- Instead of ${TOOL}, tool may be used directly, since the tool wrappers
are installed very early in the build process.
- Removed the --debug option.
... and many more.
|
|
in double quotes or not, inside backticks.
|
|
which helps for some Perl modules to get the correct package name, which
in turn influences whether the update requests from doc/TODO can be
shown or not.
Suggested by wiz.
|
|
|
|
absolute pathnames.
|
|
some of the infrastructure files. This also allows checking the
Makefiles in htdocs.
Added GAMEOWN, GAMEGRP and GAMEDIRMODE to the list of user-defined
variables that don't need to be mentioned in BUILD_DEFS.
When looking for absolute pathnames in "other" files, don't require them
to have a second component. This produces warnings for /var and /tmp,
which had been hidden before.
When strings that are likely to be absolute pathnames appear in the form
$(VARIABLE)/bin or "+ '/bin'", don't print a warning. The latter is used
when "+" is a string concatenation operator.
The direct use of tools is only suggested in targets named
{pre,do,post}-*, since other ones may be invoked without the tool
directory being in the PATH.
|
|
saved in the line as extra fields.
When checking for absolute pathnames in "other" files, allow the form
${variable}/bin, as seen in www/apache2/patches/patch-ad. Noticed by
Matthias Scheler.
|
|
|
|
|
|
|
|
|
|
-D... options.
Removed the check for the :Q operator in C preprocessor macro
definitions, since we generally don't expect directory names with
embedded special characters in pkgsrc.
In buildlink3.mk files, the only BUILDLINK_* variables that may be set
are those of the current package.
The shell variables $@ and $? are now recognized. Since the shell parser
is able to parse the complete code in all pkgsrc packages, make parse
errors show in the normal pkglint output. These errors had been hidden
before.
Fixed the regular expressions in the shell parser to only match at the
beginning of the string. That way, when the shell command contains $$@,
the $@ is not removed, leaving a single $ behind.
Added some code to deal with the different parsing styles of bmake in
variable assignments and shell commands. For that, the PkgLint::Line
class has been extended to contain arbitrary additional data. This will
also allow to reduce the number of duplicate warnings later.
The assert() procedure has got a second parameter, the message to be
printed.
Variable assignment lines start start with a space character (\u0020)
are now recognized, but no warning is printed.
In pathnames and pathmasks, the '#' character is allowed, since some
packages need to remove the .#* files from CVS before installing.
|
|
|
|
install phase.
Stricter checks for manual pages in PLIST files.
|