summaryrefslogtreecommitdiff
path: root/pkgtools/pkglint
AgeCommit message (Collapse)AuthorFilesLines
2005-09-09This is pkglint-4.21.rillig1-2/+2
Changes since 4.20 include: - In the diagnostics, FATAL is replaced with ERROR. - The command line option -g changes the format of the diagnostics to be similar to the one of gcc. - Removed false warnings when checking if PLISTS are ordered. - Removed the check for contiguous blank lines. - Added a check to PLISTs that man pages are not installed in share/man. - pkglint -r allows to recursively check directories. - The pkgsrc root directory can be checked. - Removed false warnings for patches that contain "---" lines. - Switched to checking logical lines instead of physical lines. Diagnostics for logical lines contain the range of physical lines instead of a single line number. - Some ../.. path components are stripped from the diagnostics. - When checking for the direct use of tool names, only the context of the use, not the whole shell command is output. - Patches that contain RCS Ids should not have the -ko CVS mode anymore. - Variables that are modified using the "+=" operator are considered to be lists, so they should have a name indicating a plural.
2005-09-09Changed the regular expression for detecting valid .include lines inrillig1-2/+2
Makefiles. I had intended not to read files whose name contains $ characters, but had not written exactly that in the code. Fixes PR 31213.
2005-09-06Bugfix: The subdirectories of the pkgsrc root directory are listedrillig1-7/+16
correctly. With the -r option, the order of directories is now depth-first.
2005-09-05Added a check for variables that are modified using "+=". As they arerillig1-1/+75
mostly lists of something, their name should be a plural form. There are many exceptions to this rule, mostly because of backwards compatibility.
2005-09-05Replaced two instances of ad-hoc regular expressions with regex_varassign.rillig1-4/+4
2005-09-05The continuation line indicator in regex_varassign is not neededrillig1-4/+4
anymore, since assignments are checked on logical lines instead of physical lines.
2005-09-04Use logical lines for the validation of Makefiles rather than physicalrillig1-20/+43
lines. Print line ranges instead of the starting line in diagnostics.
2005-09-04regen (under 2.0)wiz1-15/+15
2005-09-04New sentence, new line.wiz1-2/+3
2005-09-04Changed the wording of the diagnostics message when a patch contains anrillig1-5/+4
RCS tag. Suggested by hubertf.
2005-09-04Made the code in get_logical_line easier.rillig1-3/+8
2005-09-04Updated the man pages.rillig2-36/+30
2005-09-03When RCS Ids are detected in patches, don't suggest the -ko mode, butrillig1-2/+2
ask the user to remove the offending line from the patch.
2005-09-03As the shell commands in Makefiles can be quite long, only the closerillig1-8/+23
neighborhood of the tool name is printed when checking for direct use of tools.
2005-09-03Added section comments and renamed some subroutines and variables.rillig1-28/+27
2005-09-03Made the import clauses uniform.rillig1-5/+11
2005-09-02Removed the -Winternal flag and the checks for the ":=" operator. There hadrillig1-16/+1
been too many spurious warnings to be worth the effort.
2005-09-02Removed the (undocumented) -d/--debug option.rillig1-16/+1
2005-09-02The command line options are now defined in one table instead of two.rillig1-49/+60
2005-09-02In logical lines from Makefiles, white-space surrounding therillig1-8/+13
continuation is stripped from the string to make the output shorter.
2005-09-02In the diagnostics, "../../" path components that are not at therillig1-1/+5
beginning are stripped to make the output less verbose. The beginning is needed to have a reference from which package the file is included, so it is not stripped.
2005-09-02The PKGDIR variable is extracted from the Makefile first, because otherrillig1-7/+6
variables like PATCHDIR and DISTINFO_FILE depend on it.
2005-09-02When checking for direct use of tools, the Makefile lines arerillig1-8/+27
interpreted as "logical lines", that is, lines ending in a backslash are continued on the next line. This led to a false warning for PKG_FAIL_REASON, which is suppressed.
2005-09-01Fixed a newly introduced bug that prevented multiple patches per file fromrillig1-1/+3
being detected.
2005-09-01Fixed the false warnings for lines in patches that start with "---". Therillig1-3/+10
old parser had been a little too simple.
2005-09-01Pkglint can check the pkgsrc root directory now. The checks are keptrillig1-7/+59
minimal, as I use it mainly to check all the categories using the -r flag.
2005-09-01Added an (undocumented) option -r/--recursive that checks all the packagesrillig1-9/+14
in a category Makefile that are not commented out.
2005-08-25Added a check for PLISTs: Man pages should be installed into man/, notrillig1-1/+4
share/man/.
2005-08-25Removed all references to the -B/contblank command line option.rillig2-12/+4
2005-08-24Removed the -p flag from the usage message. It hasn't been implementedrillig1-2/+1
for quite some time. I don't know when it had been removed, but apparently no-one had used it anyway.
2005-08-24Removed the check for contiguous blank lines completely. As long asrillig1-11/+1
pkglint does not catch the important facts correctly it shouldn't be nitpicking about white-space. I doubt that anyone has used the -B# and the -Wwhitespace options at all, so there's no harm removing them.
2005-08-24Added a -Wwhitespace flag that is off by default to control whetherrillig1-2/+4
multiple contiguous blank lines should result in warnings.
2005-08-22Sorted the regular expression constants alphabetically. Renamed two of them.rillig1-7/+7
2005-08-22Don't warn about unsorted PLIST entries that contain ${foo}. Only makerillig1-33/+17
sure the others are sorted.
2005-08-21Reduced the number of warnings for replacing ":=" with "=". Added a commandrillig1-3/+10
line flag -Winternal to enable checking of the pkgsrc infrastructure files. By default these files are not checked.
2005-08-21Buildlink files may use the := assignment operator for variable names thatrillig1-2/+2
contain "BUILDLINK". All other uses are still flagged.
2005-08-21Added a flag -g or --gcc-output-format that makes the messages parseable byrillig1-29/+51
the Emacs compile.el program. Changed the keyword for errors from FATAL to ERROR. Sorted command line options alphabetically in the source code.
2005-08-21This is pkglint-4.20. Changes since 4.19 include:rillig1-2/+2
- Very much code cleanup - Introduction of the --autofix flag for category Makefiles - Rewrite of the code to check the DISTNAME section in package Makefiles - Rewrite of the code to check category Makefiles
2005-08-21Generally warn about the use of the := operator in Makefiles.rillig1-2/+10
2005-08-21Rewrote the checking of the Makefile variables in the DISTNAME section.rillig1-74/+67
This reduces the number of false warnings.
2005-08-20Fixed a syntax error (a string had not been enclosed in double quotes).rillig1-2/+2
2005-08-20The default values for some variables in checkfile_package_Makefile arerillig1-24/+19
chosen more carefully to avoid false warnings. The local variables are sorted by categories. Unnecessary variables have been removed.
2005-08-19Added the command line option -CDESCR, for consistency.rillig1-2/+4
2005-08-19The --help message was wrong. The progress messages are not printed onrillig1-2/+2
STDERR but on STDOUT.
2005-08-19Reduced two errors to warnings for the category Makefiles: The sortrillig1-3/+3
order and subdirectories which are commented out without giving a reason.
2005-08-19Don't check the distinfo twice if it is defined as ./distinfo in therillig1-2/+2
package Makefile. This occurs for example in multimedia/gmplayer.
2005-08-17Changed the way how the direct use of tools is detected in Makefiles.rillig1-14/+20
Now the valid sequences are deleted from the string. If after the deletion the string contains a tool name, a warning is printed.
2005-08-17Moved the checkdir_package subroutine directly before the main subroutinerillig1-97/+86
to reduce the number of necessary forward declarations. Subsequently, removed those forward declarations.
2005-08-17Renamed check_{package,category} to checkdir_{package,category} torillig1-7/+7
distinguish them from the checkfile_* and checklines_* subroutines.
2005-08-17Fixed some bugs that appeared while checking the databases/ categoryrillig1-3/+4
Makefile.