Age | Commit message (Collapse) | Author | Files | Lines |
|
finddepends: Quote package names when they are used as patterns.
Based on an idea by dillo.
|
|
filenames and pathnames may appear in .for loops. (Of course, this only
works for "nice" filenames, but the amount of false positive warnings would
just be too high.)
Added another warning for dependency patterns like 2.3*, which are
likely to be wrong: They match 2.3, 2.3nb4 and 2.30, but not 2.20, which
lies in between them.
|
|
> In header files, there shall be no variable definitions, only
> declarations. Found by MIPSpro.
|
|
the start of each line
|
|
|
|
so that show-buildlink3 will show when these buildlink3.mk files are
included.
|
|
pull in as a dependancy.
|
|
Changes since 0.1:
- Improved error messages.
- Made the code simpler.
|
|
|
|
2005.
|
|
- Shell commands in Makefiles may have leading white-space before the
[@-]*.
- Replaced the obsolete MASTER_SITES_SUBDIR with DIST_SUBDIR in the
variable order check. The variables aren't the same, but the position
is fine.
|
|
the :Q warnings.
|
|
handled automatically by pkgsrc.
- Rewrote the PLIST parser a little bit, which revealed that PLIST
directives like @dirrm may be prefixed with ${FOR_...} or
${NOTFOR_...}.
|
|
buildlink3.mk files by jlam.
|
|
and add a new helper target and script, "show-buildlink3", that outputs
a listing of the buildlink3.mk files included as well as the depth at
which they are included.
For example, "make show-buildlink3" in fonts/Xft2 displays:
zlib
fontconfig
iconv
zlib
freetype2
expat
freetype2
Xrender
renderproto
|
|
of the order in which buildlink3.mk files are (recursively) included
by a package Makefile.
|
|
|
|
- Added a new check for -Wextra that requires a manual page for every
command in bin/ and sbin/.
|
|
purpose is to be overridden by packages, not by the user.
|
|
not "netbsd.org".
|
|
- Added the -Cglobal option for inter-package checks (disabled by
default) that may consume a lot of memory.
- Adjusted pkglint to another change in the TOOLS framework which had
not been detected automatically.
- MD5 checksums are no longer deprecated, they are now obsolete.
|
|
variables for use in other files.
|
|
|
|
|
|
|
|
a SUBST block does not start with SUBST_CLASSES, as well as when more
than one class is appended at a time to SUBST_CLASSES.
|
|
The PKGDBDIR and PKGDBDIR.refcount directories are excluded from the
list of files to check, because for unprivileged pkgsrc, they are
subdirectories of PKGSRCDIR.
Removed the dependency on libnbcompat for NetBSD.
|
|
|
|
This change includes all the things I thought of during the freeze of
2006Q2.
Some variables have disappeared from pkgsrc without notice. Marked them
deprecated to help the package authors at least a bit.
Renamed some ACL abbreviations in makevars.map and adjusted the variable
definitions.
Added the command line options -Dtrace, -Dunchecked and -Dunused.
Some variables may contain unexpected white-space and therefore should
not be used in .for loops.
The -Dmisc option replaces the --verbose option (and the log_info
subroutine), which does not exist any longer. This eliminates all
instances of "OK:" from the output, which I didn't like from the
beginning. The -Dmisc option also takes over many warnings that have
been issued by --debug before.
Improved the check for absolute pathnames. Especially, everything that
follows ${DESTDIR} or $(DESTDIR) in a Makefile is considered an absolute
pathname. This reveals many wrong uses of DESTDIR (as defined by the GNU
coding standards), for example $(DESTDIR)/$(prefix), which should be
$(DESTDIR)$(prefix) instead.
Almost every use of a make(1) variable is checked for spelling mistakes.
Before, only the definitions of variables have been checked.
Restricted the use of variables to specific files, which are defined in
makevars.map. This catches especially buildlink3.mk files with
unexpected side effects.
In shell commands, neither "echo" nor "echo -n" or "${ECHO} -n" should
be used. Since the INSTALL_*_DIR commands can only handle one directory
at a time, suggest to use INSTALLATION_DIRS instead.
Greatly improved the checks for dependency specifications, especially to
find foo-*, which should rather be foo-[0-9]*.
Fixed the incorrect handling of LICENSE_FILE (now using $line->text
instead of $line).
Improved the wording of the "plural names" warnings, so that for known
variables it is "The += operator should only be used with lists." now.
In buildlink3.mk files the uppercase and lowercase names of the package
should correspond with the package name. This catches many
copy-and-paste mistakes. Fixed many null pointer exceptions as well. In
addition, every buildlink3.mk file needs a definition of
BUILDLINK_API_DEPENDS.
In patch files, absolute pathnames and unportable macro names are
checked not only in added lines, but also in the context lines.
In the pkgsrc root directory and the category directories, the Makefiles
are checked like every other Makefile, too.
Fixed the place where the global variables for the package context are
defined and later undefined.
Variables that are mentioned in EVAL_PREFIX may be used in the current
file and are not flagged as "used but not defined".
When parsing shell words in Makefiles, recognize $<, $@, $^ and $/.
(The latter is used extensively by openoffice to represent a directory
separator.)
Fixed some minor bugs:
* $makevar had been defined unintentionally by using the -> operator.
|
|
Fix pkg_info -Q on binary packages; noted by rillig.
Bump version to 20060701.
Okayed during freeze by wiz.
|
|
|
|
differently, which may lead to problems.
|
|
|
|
|
|
|
|
Changes since 4.64:
- Many refinements of quoting checks and variable type definitions.
- Improved the wording of diagnostics and added some explanations.
- Adjusted pkglint to the many recent changes in the infrastructure part.
- Improved detection of absolute pathnames.
Updated during the freeze because the version number has not changed for
two weeks, but many features were added. Therefore the old version
number was not reliable for determining the real functionality of
pkglint exactly.
|
|
many false positive warnings for paths like ${PREFIX}/foo.
|
|
variables.
|
|
|
|
|
|
nice description text for most of the SUBST blocks.
|
|
graphics/xfig for an example where it makes a difference.
|
|
|
|
this one is defined in PkgLint::SubstContext instead of the main
package. Time will show whether this was a good decision. Since the
checking subroutines heavily modify the fields of the SubstContext, it
seems to be Done Right.
|
|
|
|
duplicate calls.
|
|
pkginstall framework.
|
|
- The macro __sparc_v9__ is neither defined by gcc nor by SunPro. But
__sparcv9 is.
- Added some more commands that may be hidden using the "@" character.
- Don't let pkglint get confused by additional magic in the use of
MASTER_SITES. For example, devel/nspr uses ${MASTER_SITE:S/../../:=foo/}.
|
|
(1.611) had broken the check of pkgsrc infrastructure files.
|
|
|