| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
|
|
sure the others are sorted.
|
|
line flag -Winternal to enable checking of the pkgsrc infrastructure files.
By default these files are not checked.
|
|
contain "BUILDLINK". All other uses are still flagged.
|
|
the Emacs compile.el program. Changed the keyword for errors from FATAL to
ERROR. Sorted command line options alphabetically in the source code.
|
|
- Very much code cleanup
- Introduction of the --autofix flag for category Makefiles
- Rewrite of the code to check the DISTNAME section in package Makefiles
- Rewrite of the code to check category Makefiles
|
|
|
|
This reduces the number of false warnings.
|
|
fixes build on BSD/OS.
from T. M. Pederson in PR pkg/31024.
|
|
that these directories will be conditionally removed (based on reference
counts), regardless of the value of PKG_CONFIG. Bump the PKGREVISION
for packages that were modified as a result.
|
|
|
|
chosen more carefully to avoid false warnings. The local variables are
sorted by categories. Unnecessary variables have been removed.
|
|
|
|
STDERR but on STDOUT.
|
|
order and subdirectories which are commented out without giving a
reason.
|
|
package Makefile. This occurs for example in multimedia/gmplayer.
|
|
Now the valid sequences are deleted from the string. If after the
deletion the string contains a tool name, a warning is printed.
|
|
to reduce the number of necessary forward declarations. Subsequently,
removed those forward declarations.
|
|
distinguish them from the checkfile_* and checklines_* subroutines.
|
|
Makefile.
|
|
subdirectories that are in one of filesystem/Makefile, but not in the
other.
|
|
comment. Instead, allow arbitrary comments at the beginning of the file.
This change required a major rewrite of the code, which had been quite
inflexible before.
|
|
|
|
has only effects for category Makefiles. While implementing it I
probably fixed some other bugs in the category Makefile checking code.
|
|
code, I had forgotten one assumption I made. It was that in the ifelse
chain the case ( && ) couldn't occur because
the outer loop already cought that. And then I had inserted code that
violated exactly this assumption. Fixed.
|
|
had put the closing indentation FIXME comment at a wrong place. But as
it is removed now, this doesn't matter.
|
|
The new code, which is not as nice as the old code, will hopefully allow
the --autofix option to be implemented really easily. If that will not
become true, I will probably revert to the old code. There's an
indentation FIXME in the code to keep this patch small. I will remove
that FIXME in a minute.
|
|
different second line and additional targets after the SUBDIR entries.
|
|
normal form" passes all checks.
|
|
|
|
|
|
|
|
them. All pathnames are already interpreted as being relative to the
package's directory. Added a reminder that ONLY_FOR_PLATFORM should be
changed to NOT_FOR_PLATFORM where appropriate.
|
|
of Perl files to deal with the perl-5.8.7 update that moved all
pkgsrc-installed Perl files into the "vendor" directories.
|
|
subroutine checklines_Makefile, which is called by
checkfile_package_Makefile and check_category.
|
|
When using the -M flag, look in Makefile and Makefile.common files.
Ok'ed by Peter Postma.
|
|
|
|
Make -b work without any access to pkgsrcdir
|
|
Fix the automagic tuning of the number of unified diff context
lines. It was broken since previous commit to files/pkgdiff.
Also arguments '-u' and '-U NUM' to GNU diffutils 2.8.1, as seen
in NetBSD 2.0_STABLE and current, are not intended to be used
together. Hence only '-U NUM' is now specified. I did not reverted
to the '-u -NUM' form used before as it seems undesirable.
Please note that if PKGDIFF_FMT is specified in the environment,
for testing or debugging purposes, we skip the automagic tuning of
the number of unified diff context lines. The user probably wants
to try another diff format, as suggested in the commit log of
revision 1.12 of files/pkgdiff. So there is no point in adding '-U
NUM' to PKGDIFF_FMT: it may just not work. See:
$ diff -c -U 1 /dev/null /dev/null
diff: conflicting output style options
diff: Try `diff --help' for more information.
While here save a few basename(1) runs.
|
|
${DISTNAME}, ${DISTFILES}, ${EXTRACT_SUFX} cannot be resolved
completely. It's better than proceeding with definitely unusable values.
|
|
|
|
saving the fields. This gives a 5 percent speed-up.
|
|
- add -m, -o, and -r flags to optionally specify the machine-architecture
operating system, and os version to be displayed in the generated README
file. From Greg Woods via private email.
- White space fixes from Greg Woods.
- Clean up the generated README file as well as several of the messages
to reflect if the collection is a CD-ROM or DVD set. Some patches from
Greg Woods, more from me.
- List the tools used at runtime.
|
|
|
|
measuring the time spent in the main checking subroutines. Using that
function I discovered that method calls like $line->text are awfully
slow. The subroutine checkfile_PLIST spent half of its time in this
function call. Now it is almost twice as fast as before.
|
|
|
|
|
|
references are needed. As the return value of the checkfile_*
subroutines is not needed, it is not provided anymore. Some other small
changes, which all do not affect the actual output or behavior of
pkglint.
|
|
|
|
branch.
|
