summaryrefslogtreecommitdiff
path: root/pkgtools
AgeCommit message (Collapse)AuthorFilesLines
2006-02-07- The diagnostics are filtered through strxvis(), so that pkglint is ablerillig1-2/+9
to check and report warnings even in files of random contents without emitting any terminal control sequences.
2006-02-07- Not only check for the definition of deprecated variables, but also forrillig1-11/+21
using them. - The :Q operator should not be used in double quotes.
2006-02-06Update pkg_chk to 1.76:abs2-4/+4
Append rather than prepend /usr/sbin:/usr/bin to path, to avoid issues on Solaris which has feature-poor ftp in /usr/bin
2006-02-06Updated pkglint to 4.56.rillig1-2/+2
Changes since 4.55: - Avoided false positive warnings about bsd.prefs.mk being required before using buildlink3.mk files. - Restricted the files that are checked for absolute pathnames in patch files. - Some tools that are often used as ${TOOLNAME} need to be explicitly added to the USE_TOOLS variable. When complaning about their direct use, add a proper advice. - Readded all the deprecated variables. The warnings will have to stay longer than just three months.
2006-02-06- Reworded two occurrences of "unportable". They sounded too harsh.rillig1-3/+3
2006-02-06- Don't emit an extra warning if a tool should be added to USE_TOOLS. Justrillig1-3/+5
append it to the previous line.
2006-02-05Recursive revision bump / recommended bump for gettext ABI change.joerg4-5/+8
2006-02-05Readded almost all variables that had been here in the past. We cannotrillig1-5/+56
force the developers to learn all pkgsrc changes every three months, so it's better to keep the warnings for a much longer time. I don't know yet what "much longer" exactly means.
2006-02-04Pinned down the collected problems of the current pkglint development.rillig1-0/+33
2006-02-04* Many of the checking routines need some context to provide betterrillig1-1/+4
warnings. For example, checkline_foo() may need to know what has happened in the file before that line.
2006-02-04- Some tools that are often used as ${TOOLNAME} need to be explicitlyrillig1-3/+71
added to the USE_TOOLS variable. When complaning about their direct use, add a proper advice.
2006-02-02- bsd.prefs.mk does not need to be included before BUILDLINK_DEPMETHOD getsrillig1-2/+3
assigned using the "?=" operator, since these variables are not meant to be set by the user. - Restricted the files that are checked for absolute pathnames in patch files.
2006-02-02Wish for warning about BUILD_USES_MSGFMT being used withoutjoerg1-1/+3
devel/gettext-lib/buildlink3.mk being included. This is often, but not always incorrect.
2006-01-31Updated createbuildlink to 3.10.rillig2-8/+8
The last line is now indented with <tab> instead of six spaces. This prevents many pkglint warnings and also looks better.
2006-01-30Updated pkglint to 4.55.rillig1-2/+2
Changes since 4.54: - -Wvarorder works now as expected. - distinfo files are checked more strictly. - Reduced the number of false positives. - Make(1) variables of the form $(...) are detected properly.
2006-01-30- Added a hack to be able to parse nested make(1) variables likerillig1-3/+4
${TOOL.${t}}. They just extend up to, but not including the next space or quote character. - log_debug() is used for printing debugging info, not log_error(). - Even if NO_CHECKSUM is set, distinfo files may exist if the package has patches. Noted by salo.
2006-01-29- Variables whose name end in DIR, DIRS, FILE, FILES, as well as PATH,rillig1-1/+4
PREFIX, LOCALBASE and PKGNAME may appear in single quotes.
2006-01-28- PkgLint::String::substring accepts an undefined second argument.rillig1-9/+34
- Added PkgLint::String::match_all. - Make(1) variables of the form $(...) are detected properly. - The shellword parser's state is printed in --debug mode. - In double quoted strings, normal text is processed faster. - The proof of concept for match_all is done with finding absolute pathnames in patch files.
2006-01-28- Added a comment above get_regex_plurals, explaining what it does.rillig1-1/+7
2006-01-28- Added PkgLint::Util::min and PkgLint::Util::max.rillig1-31/+44
- Rewrote PkgLint::String::substring to make it look less like a Brainf*** program. I guess this will greatly improve execution speed.
2006-01-28- Removed PkgLint::Util::match.rillig1-24/+64
- Added PkgLint::Match, which represents the result of matching a regular expression against a PkgLint::String. - Fixed the arguments to substr in PkgLint::String::substring. - Added PkgLint::String::match. - Added a proof of concept in checkfile_patch, in the warning about RCS tags. Run pkglint -s --klickibunti to see it.
2006-01-27- Found the one variable that slipped through when renaming $file torillig1-3/+3
$fname.
2006-01-27- Fixed inconsistent use of white-space.rillig1-3/+3
2006-01-27- Reformatted simple getter/setter methods to save some space.rillig1-46/+19
2006-01-27- Globally renamed all variables called $file into $fname. The identifierrillig1-66/+66
$file is reserved for variables of the type PkgLint::File.
2006-01-27- Added the two data types PkgLint::File and PkgLint::Location. I will needrillig1-1/+57
them soon.
2006-01-26- Added the PkgLint::Util::match function that matches a string against arillig1-2/+18
regular expression and saves the values of the volatile @- and @+ arrays.
2006-01-26Even in quick-install mode, the self test should be run.rillig1-2/+2
2006-01-25Added a ``quick-install'' target that allows me to install pkglint in threerillig1-1/+8
seconds instead of 40.
2006-01-25Fix false positives about the test that checks for pkg-config filesxtraeme2-4/+4
in WRKSRC. Now it works properly. Bump to 1.33.
2006-01-25- In --debug mode, all variable assignments that occur when the packagerillig1-8/+9
Makefile is read in are logged to give further aid in debugging. - Warnings about PKGNAME and DISTNAME are anchored at line numbers instead of the package Makefile.
2006-01-25Add conditional code to ignore the non-numeric part of an OS versionjoerg5-4/+36
for the sake of compatibility tests in pkg_add. E.g. DragonFly versions like 1.4.0-RELEASE are reduced to 1.4.0 This code is currently enabled for DragonFly only.
2006-01-24- As "set -- $i" is often used for splitting variables, don't warn if shellrillig1-5/+11
variables appear unquoted here.
2006-01-24- In shell variable assignments, no quoting is needed.rillig1-2/+4
2006-01-24- Accept "\"...\"" as valid CPP macro, as some old configure scripts needrillig1-1/+4
it that way. In --debug mode, a warning is printed.
2006-01-23- Made the parser for distinfo files stricter. It can catch mismatchedrillig1-14/+59
filenames now. - MD5 checksums are marked as deprecated. - Warnings from distinfo files now appear correctly sorted.
2006-01-23- Made -Wvarorder work like stated in the documentation. I had replaced therillig1-5/+9
wrong ``false'' with $opt_warn_varorder. - Fixed the detection of $seen_Makefile_common.
2006-01-22- Instead of only allowing the :Q modifier for quoting, allow any modifierrillig1-2/+7
that ends in :Q. - When NO_CONFIGURE ist defined, REPLACE_PERL does not work.
2006-01-21Update "rpm2pkg" package to version 2.1.1. Changes since 2.1:tron2-6/+5
- Fixed GCC 4.x build warning (which would have resulted in an error with future GCC versions). - Depend on newer version of "rpm" package to fix build under Mac OS X.
2006-01-21Update package Makefile now that bsd.pkg.extract.mk is using thejlam2-4/+2
"extract" script for extraction. Many cases where a custom EXTRACT_CMD simply copied the distfile into the work directory are no longer needed. The extract script also hides differences between pax and tar behind a common command-line interface, so we no longer need code that's conditional on whether EXTRACT_USING is tar or pax.
2006-01-20Updated pkglint to 4.54.rillig1-2/+2
Changes since 4.53: - Added about 50 new variables to be type-checked. - For unknown variables, the type is guessed from the variable name. - In patch files that patch Makefiles, added lines are checked for absolute pathnames. - Replaced the -Wdebug option with --debug, so that the debugging warnings don't show up when using -Wall. - Many minor improvements.
2006-01-20- Added the -d|--debug command line option, which replaces -Wdebug. Therillig3-33/+58
latter has been removed. - Added -Wvarorder (default: disabled) to check the ordering of variables in simple packages. - Using ${WRKSRC}/.. is only considered a warning, not an error, because there are packages that work nevertheless. Using this construct remains discouraged. - Replaced most of the TODOs in the source code with code that prints a warning in --debug mode. - The characters '.' and '+' are allowed in BuildlinkPackages. - Variables *_FLAGS and *_ARGS that have their type guessed based on the name don't have to be assigned using the += operator. - Variables that are assigned using the != operator are not checked for type compliance. - README files are not marked as unknown when they appear in a package directory.
2006-01-20Setting BROKEN_GETTEXT_DETECTION to "no" really means "no", so allow it.rillig1-2/+2
2006-01-20Despite its name, BUILTIN_FIND_FILES_VAR is a _list_ of variable names.rillig1-2/+2
2006-01-19Add include/X11/XlibConf.h to xorg list. I noticed and added thatreed2-3/+4
a few weeks ago when I was doing some builds using modular-xorg. (Now that new Xorg is in, maybe there are some others to add?) Update version.
2006-01-17- Added some more state transitions and warnings to the shellword parser.rillig1-1/+25
It has come to the point where almost any further improvement means to adopt a real recursive parser.
2006-01-16- In -Wextra mode, emit warnings if a "?=" operator occurs beforerillig1-1/+17
../../bsd.prefs.mk is included. (It is only shown in -Wextra mode because it is still quite unreliable.)
2006-01-15Update pkgtools/pkg_chk to 1.66abs2-4/+4
Fix incorrect quotation in test
2006-01-15- Implemented a first prototype of the diagnostics with character-wiserillig1-24/+121
precision in checkfile_patch for the warning for context diffs. - The --source option produces more condensed output than before. - The diagnostics with character-wise precision are colored using ANSI/VT100 color sequences. Support for other output formats will be added later.
2006-01-14- The pkgdir variable is only defined when checking a pkgsrc package. Forrillig1-2/+3
other directories it is undefined. This avoids some false warnings when checking files in pkgsrc/mk/.