Age | Commit message (Collapse) | Author | Files | Lines |
|
to check and report warnings even in files of random contents without
emitting any terminal control sequences.
|
|
using them.
- The :Q operator should not be used in double quotes.
|
|
Append rather than prepend /usr/sbin:/usr/bin to path, to avoid issues
on Solaris which has feature-poor ftp in /usr/bin
|
|
Changes since 4.55:
- Avoided false positive warnings about bsd.prefs.mk being required before
using buildlink3.mk files.
- Restricted the files that are checked for absolute pathnames in patch
files.
- Some tools that are often used as ${TOOLNAME} need to be explicitly
added to the USE_TOOLS variable. When complaning about their direct
use, add a proper advice.
- Readded all the deprecated variables. The warnings will have to stay
longer than just three months.
|
|
|
|
append it to the previous line.
|
|
|
|
force the developers to learn all pkgsrc changes every three months, so
it's better to keep the warnings for a much longer time. I don't know
yet what "much longer" exactly means.
|
|
|
|
warnings. For example, checkline_foo() may need to know what has
happened in the file before that line.
|
|
added to the USE_TOOLS variable. When complaning about their direct
use, add a proper advice.
|
|
assigned using the "?=" operator, since these variables are not meant to
be set by the user.
- Restricted the files that are checked for absolute pathnames in patch
files.
|
|
devel/gettext-lib/buildlink3.mk being included. This is often,
but not always incorrect.
|
|
The last line is now indented with <tab> instead of six spaces. This
prevents many pkglint warnings and also looks better.
|
|
Changes since 4.54:
- -Wvarorder works now as expected.
- distinfo files are checked more strictly.
- Reduced the number of false positives.
- Make(1) variables of the form $(...) are detected properly.
|
|
${TOOL.${t}}. They just extend up to, but not including the next space or
quote character.
- log_debug() is used for printing debugging info, not log_error().
- Even if NO_CHECKSUM is set, distinfo files may exist if the package has
patches. Noted by salo.
|
|
PREFIX, LOCALBASE and PKGNAME may appear in single quotes.
|
|
- Added PkgLint::String::match_all.
- Make(1) variables of the form $(...) are detected properly.
- The shellword parser's state is printed in --debug mode.
- In double quoted strings, normal text is processed faster.
- The proof of concept for match_all is done with finding absolute
pathnames in patch files.
|
|
|
|
- Rewrote PkgLint::String::substring to make it look less like a Brainf***
program. I guess this will greatly improve execution speed.
|
|
- Added PkgLint::Match, which represents the result of matching a regular
expression against a PkgLint::String.
- Fixed the arguments to substr in PkgLint::String::substring.
- Added PkgLint::String::match.
- Added a proof of concept in checkfile_patch, in the warning about RCS
tags. Run pkglint -s --klickibunti to see it.
|
|
$fname.
|
|
|
|
|
|
$file is reserved for variables of the type PkgLint::File.
|
|
them soon.
|
|
regular expression and saves the values of the volatile @- and @+ arrays.
|
|
|
|
seconds instead of 40.
|
|
in WRKSRC. Now it works properly.
Bump to 1.33.
|
|
Makefile is read in are logged to give further aid in debugging.
- Warnings about PKGNAME and DISTNAME are anchored at line numbers instead
of the package Makefile.
|
|
for the sake of compatibility tests in pkg_add.
E.g. DragonFly versions like
1.4.0-RELEASE
are reduced to
1.4.0
This code is currently enabled for DragonFly only.
|
|
variables appear unquoted here.
|
|
|
|
it that way. In --debug mode, a warning is printed.
|
|
filenames now.
- MD5 checksums are marked as deprecated.
- Warnings from distinfo files now appear correctly sorted.
|
|
wrong ``false'' with $opt_warn_varorder.
- Fixed the detection of $seen_Makefile_common.
|
|
that ends in :Q.
- When NO_CONFIGURE ist defined, REPLACE_PERL does not work.
|
|
- Fixed GCC 4.x build warning (which would have resulted in an error
with future GCC versions).
- Depend on newer version of "rpm" package to fix build under Mac OS X.
|
|
"extract" script for extraction. Many cases where a custom EXTRACT_CMD
simply copied the distfile into the work directory are no longer
needed. The extract script also hides differences between pax and
tar behind a common command-line interface, so we no longer need code
that's conditional on whether EXTRACT_USING is tar or pax.
|
|
Changes since 4.53:
- Added about 50 new variables to be type-checked.
- For unknown variables, the type is guessed from the variable name.
- In patch files that patch Makefiles, added lines are checked for
absolute pathnames.
- Replaced the -Wdebug option with --debug, so that the debugging warnings
don't show up when using -Wall.
- Many minor improvements.
|
|
latter has been removed.
- Added -Wvarorder (default: disabled) to check the ordering of variables
in simple packages.
- Using ${WRKSRC}/.. is only considered a warning, not an error, because
there are packages that work nevertheless. Using this construct remains
discouraged.
- Replaced most of the TODOs in the source code with code that prints
a warning in --debug mode.
- The characters '.' and '+' are allowed in BuildlinkPackages.
- Variables *_FLAGS and *_ARGS that have their type guessed based on the
name don't have to be assigned using the += operator.
- Variables that are assigned using the != operator are not checked for
type compliance.
- README files are not marked as unknown when they appear in a package
directory.
|
|
|
|
|
|
a few weeks ago when I was doing some builds using modular-xorg.
(Now that new Xorg is in, maybe there are some others to add?)
Update version.
|
|
It has come to the point where almost any further improvement means to
adopt a real recursive parser.
|
|
../../bsd.prefs.mk is included. (It is only shown in -Wextra mode
because it is still quite unreliable.)
|
|
Fix incorrect quotation in test
|
|
precision in checkfile_patch for the warning for context diffs.
- The --source option produces more condensed output than before.
- The diagnostics with character-wise precision are colored using
ANSI/VT100 color sequences. Support for other output formats will be
added later.
|
|
other directories it is undefined. This avoids some false warnings when
checking files in pkgsrc/mk/.
|