From 1f21b59bec16b4e2a880999d4a3a98cdcf442c22 Mon Sep 17 00:00:00 2001
From: rillig <rillig>
Date: Sun, 18 Jun 2006 08:43:35 +0000
Subject: When checking a Pathlist, split $value instead of $value_novar. This
 avoids many false positive warnings for paths like ${PREFIX}/foo.

---
 pkgtools/pkglint/files/pkglint.pl | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl
index 4612c7015bd..d430a269a68 100644
--- a/pkgtools/pkglint/files/pkglint.pl
+++ b/pkgtools/pkglint/files/pkglint.pl
@@ -1,5 +1,5 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.632 2006/06/18 08:20:19 rillig Exp $
+# $NetBSD: pkglint.pl,v 1.633 2006/06/18 08:43:35 rillig Exp $
 #
 
 # pkglint - static analyzer and checker for pkgsrc packages
@@ -4185,7 +4185,9 @@ sub checkline_mk_vartype_basic($$$$$$$) {
 		}
 
 	} elsif ($type eq "Pathlist") {
-		my (@paths) = split(qr":", $value_novar);
+		# XXX: The splitting will fail if $value contains any
+		# variables with modifiers, for example :Q or :S/././.
+		my (@paths) = split(qr":", $value);
 
 		foreach my $p (@paths) {
 			checkline_mk_vartype_basic($line, $varname, "Pathname", $op, $p, $comment, false);
-- 
cgit v1.2.3