From 828fd6c8826640e61eb1c544eab5a43c6c5c65b5 Mon Sep 17 00:00:00 2001 From: brook Date: Wed, 31 Aug 2011 19:40:43 +0000 Subject: In a recent thread [1], the value of including USE_CMAKE=yes in the file meta-pkgs/kde4/kde4.mk was discussed. The conclusion was that it did make sense to include that definition because kde4.mk is included by packages that use the kde4 configure and build system, which is cmake. Thus, they will need to define USE_CMAKE anyway and currently must do so in addition to including kde4.mk. This adds the needed definition so that it is no longer necessary to do both things. Many other packages currently include kde4.mk and also define USE_CMAKE. In many cases they also define CMAKE_ARGS. To avoid potential confusion centering around wondering whether or not USE_CMAKE was forgotten (e.g., if readers do not know it is now defined in kde4.mk), the definition was not removed from those packages. Future package authors can determine whether or not it is clearer to include the definition even though kde4.mk is also included. [1] http://mail-index.netbsd.org/tech-pkg/2011/08/28/msg007595.html --- meta-pkgs/kde4/kde4.mk | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'meta-pkgs/kde4') diff --git a/meta-pkgs/kde4/kde4.mk b/meta-pkgs/kde4/kde4.mk index 320fd0db4bd..95ec23b1a4b 100644 --- a/meta-pkgs/kde4/kde4.mk +++ b/meta-pkgs/kde4/kde4.mk @@ -1,4 +1,4 @@ -# $NetBSD: kde4.mk,v 1.2 2010/04/10 02:45:03 markd Exp $ +# $NetBSD: kde4.mk,v 1.3 2011/08/31 19:40:43 brook Exp $ # # This Makefile fragment is included by packages that use the KDE4 # configure-and-build process. @@ -9,6 +9,7 @@ KDE4_MK= # defined USE_PKGLOCALEDIR= YES +USE_CMAKE= yes CMAKE_ARGS+= -DHTML_INSTALL_DIR=${PREFIX}/share/doc/kde/HTML CMAKE_ARGS+= -DDATA_INSTALL_DIR=${PREFIX}/share/kde/apps CMAKE_ARGS+= -DCONFIG_INSTALL_DIR=${PREFIX}/share/kde/config -- cgit v1.2.3