From 8c50b1beff06aa6afdcd4a737949b92b441e631f Mon Sep 17 00:00:00 2001 From: seb Date: Wed, 25 Jun 2003 22:48:02 +0000 Subject: Using GNU missing script as makeinfo seemed like a good idea when a package use the buildlink2 framework but does not define USE_MAKEINFO. Well it was not after all. This caused annoying messages because missing's commands emit annoying error messages when the script is invoked with only 'makeinfo' as argument (typically run this way by configure scripts). And more it does not handle makeinfo's '--output=...' argument. I first thought that it could be used as a nice way to get ride of the need for makeinfo when it was only dubiously run during build or installation of a package. But it also has the annoying behavior of creating empty files because of the typical automake generated Makefile target for info file build. Making the buildlink2's makeinfo hiding script only logging an error and doing 'exit 1' is actually a better tool to spot the need for makeinfo. --- mk/buildlink2/bsd.buildlink2.mk | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'mk/buildlink2') diff --git a/mk/buildlink2/bsd.buildlink2.mk b/mk/buildlink2/bsd.buildlink2.mk index 516105ab99d..1caf83670a3 100644 --- a/mk/buildlink2/bsd.buildlink2.mk +++ b/mk/buildlink2/bsd.buildlink2.mk @@ -1,4 +1,4 @@ -# $NetBSD: bsd.buildlink2.mk,v 1.86 2003/06/19 21:41:15 seb Exp $ +# $NetBSD: bsd.buildlink2.mk,v 1.87 2003/06/25 22:48:02 seb Exp $ # # An example package buildlink2.mk file: # @@ -1065,7 +1065,9 @@ ${BUILDLINK_DIR}/bin/makeinfo: ${_GNU_MISSING} ${_PKG_SILENT}${_PKG_DEBUG} \ ${ECHO} "#!${BUILDLINK_SHELL}" > ${.TARGET} ${_PKG_SILENT}${_PKG_DEBUG} \ - ${ECHO} 'exec ${_GNU_MISSING} makeinfo "$$*"' >> ${.TARGET} + ${ECHO} '${ECHO} "==> [buildlink2] Error: makeinfo $$*" >> ${_BLNK_WRAP_LOG}' >> ${.TARGET} + ${_PKG_SILENT}${_PKG_DEBUG} \ + ${ECHO} 'exit 1' >> ${.TARGET} ${_PKG_SILENT}${_PKG_DEBUG}${CHMOD} +x ${.TARGET} . endif # USE_MAKEINFO .endif # INFO_FILES -- cgit v1.2.3