From 3444dbc9416d2f0728e3d98a1277490a19c59cc3 Mon Sep 17 00:00:00 2001 From: rillig Date: Mon, 21 Jan 2008 06:11:09 +0000 Subject: The package x11/gdm embeds ${exec_prefix} into a macro containing a PATH, in which it is not directly preceded by a quote character: #define GDM_USER_PATH "/usr/bin:/bin:${exec_prefix}" Catch this by complaining about "${" also when it appears after a colon. Since this check is still disabled by default, it will not surprise anyone. --- mk/check/check-headers.sh | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'mk') diff --git a/mk/check/check-headers.sh b/mk/check/check-headers.sh index c5222efe36b..9f90ee1c319 100644 --- a/mk/check/check-headers.sh +++ b/mk/check/check-headers.sh @@ -1,4 +1,4 @@ -# $NetBSD: check-headers.sh,v 1.9 2007/01/02 17:58:11 rillig Exp $ +# $NetBSD: check-headers.sh,v 1.10 2008/01/21 06:11:09 rillig Exp $ # # This program checks the header files for possible problems. # @@ -22,7 +22,7 @@ check_header() { # Check for "${" in macro definitions. case "$line" in - "#"*define*\"\$\{[A-Za-z]*\}/*\"*) + "#"*define*[\":]\$\{[A-Za-z]*\}/*\"*) found_unresolved_variable=yes cs_error_heading "Found unresolved variable in macro:" cs_error_msg "$fname: $line" @@ -55,6 +55,7 @@ The cause of this problem is usually that in a configure.ac or configure.in file, there is some code like FOO_DIR="\${bindir}" + # ... AC_DEFINE_UNQUOTED(FOO_DIR, "\$FOO_DIR", [Directory where foo files go]) You can fix this by telling the original package author not to use -- cgit v1.2.3