From 3299d23582f6249bb522b63936907d992fd2d476 Mon Sep 17 00:00:00 2001 From: rillig Date: Fri, 10 Mar 2006 22:30:25 +0000 Subject: Don't check the quoting in backticks. This is a misdesign of pkglint. --- pkgtools/pkglint/files/pkglint.pl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'pkgtools') diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 8fce6ad1ba4..ef754f2ff30 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.545 2006/03/09 17:34:17 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.546 2006/03/10 22:30:25 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -2529,6 +2529,10 @@ sub checkline_mk_shellword($$$) { if ($state == SWST_PLAIN && defined($mod) && $mod =~ qr":Q$") { # Fine. + } elsif ($state == SWST_BACKT) { + # Don't check here, to avoid false positives + # for tool names. + } elsif (($state == SWST_SQUOT || $state == SWST_DQUOT) && $varname =~ qr"^(?:.*DIR|.*FILE|.*PATH|.*_VAR|PREFIX|.*BASE|PKGNAME)$") { # This is ok if we don't allow these # variables to have embedded [\$\\\"\'\`]. -- cgit v1.2.3