From 47dc796d5584462b8b27c662796f071be56dccfd Mon Sep 17 00:00:00 2001 From: rillig Date: Tue, 15 Jun 2010 22:06:48 +0000 Subject: In patch files, comments are so useful that this is no longer a warning that only applies when -Wextra is given. ok wiz@ --- pkgtools/pkglint/files/pkglint.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) (limited to 'pkgtools') diff --git a/pkgtools/pkglint/files/pkglint.pl b/pkgtools/pkglint/files/pkglint.pl index 5307b35d940..2bf6af10526 100644 --- a/pkgtools/pkglint/files/pkglint.pl +++ b/pkgtools/pkglint/files/pkglint.pl @@ -1,5 +1,5 @@ #! @PERL@ -# $NetBSD: pkglint.pl,v 1.822 2010/03/10 14:42:22 rillig Exp $ +# $NetBSD: pkglint.pl,v 1.823 2010/06/15 22:06:48 rillig Exp $ # # pkglint - static analyzer and checker for pkgsrc packages @@ -7387,12 +7387,12 @@ sub checkfile_patch($) { # }], [PST_TEXT, re_patch_cfd, PST_CFA, sub() { if (!$seen_comment) { - $opt_warn_style and $line->log_warning("Comment expected."); + $line->log_warning("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_TEXT, re_patch_ufd, PST_UFA, sub() { if (!$seen_comment) { - $opt_warn_style and $line->log_warning("Comment expected."); + $line->log_warning("Comment expected."); } }], [PST_TEXT, re_patch_text, PST_TEXT, sub() { $seen_comment = true; @@ -7404,14 +7404,14 @@ sub checkfile_patch($) { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - $opt_warn_style and $line->log_warning("Comment expected."); + $line->log_warning("Comment expected."); } $line->log_warning("Please use unified diffs (diff -u) for patches."); }], [PST_CENTER, re_patch_ufd, PST_UFA, sub() { if ($seen_comment) { $opt_warn_space and $line->log_note("Empty line expected."); } else { - $opt_warn_style and $line->log_warning("Comment expected."); + $line->log_warning("Comment expected."); } }], [PST_CENTER, undef, PST_TEXT, sub() { $opt_warn_space and $line->log_note("Empty line expected."); -- cgit v1.2.3