1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
|
package main
import (
"bytes"
"crypto/sha1"
"io/ioutil"
"strings"
)
func checklinesDistinfo(lines []*Line) {
defer tracecall("checklinesDistinfo", lines[0].fname)()
fname := lines[0].fname
var patchesDir = "patches"
if G.pkgContext != nil && dirExists(G.currentDir+"/"+G.pkgContext.patchdir) {
patchesDir = G.pkgContext.patchdir
}
if G.pkgContext != nil && hasSuffix(fname, "/lang/php54/distinfo") {
patchesDir = G.curPkgsrcdir + "/lang/php54/patches"
}
_ = G.opts.DebugMisc && debugf(fname, noLines, "patchesDir=%q", patchesDir)
ck := &distinfoLinesChecker{
fname, patchesDir, isCommitted(fname),
make(map[string]bool), "", false, nil}
ck.checkLines(lines)
checklinesTrailingEmptyLines(lines)
ck.checkUnrecordedPatches()
}
type distinfoLinesChecker struct {
distinfoFilename string
patchdir string // Relative to G.currentDir
distinfoIsCommitted bool
patches map[string]bool // "patch-aa" => true
previousFilename string
isPatch bool
algorithms []string
}
func (ck *distinfoLinesChecker) checkLines(lines []*Line) {
checklineRcsid(lines[0], ``, "")
if 1 < len(lines) && lines[1].text != "" {
lines[1].notef("Empty line expected.")
}
for i, line := range lines {
if i < 2 {
continue
}
m, alg, filename, hash := match3(line.text, `^(\w+) \((\w[^)]*)\) = (.*)(?: bytes)?$`)
if !m {
line.errorf("Invalid line.")
continue
}
if filename != ck.previousFilename {
ck.onFilenameChange(line, filename)
}
ck.algorithms = append(ck.algorithms, alg)
ck.checkGlobalMismatch(line, filename, alg, hash)
ck.checkUncommittedPatch(line, filename, hash)
}
ck.onFilenameChange(NewLine(ck.distinfoFilename, "EOF", "", nil), "")
}
func (ck *distinfoLinesChecker) onFilenameChange(line *Line, nextFname string) {
prevFname := ck.previousFilename
if prevFname != "" {
algorithms := strings.Join(ck.algorithms, ", ")
if ck.isPatch {
if algorithms != "SHA1" {
line.errorf("Expected SHA1 hash for %s, got %s.", prevFname, algorithms)
}
} else {
if algorithms != "SHA1, RMD160, Size" && algorithms != "SHA1, RMD160, SHA512, Size" {
line.errorf("Expected SHA1, RMD160, SHA512, Size checksums for %q, got %s.", prevFname, algorithms)
}
}
}
ck.isPatch = matches(nextFname, `^patch-.+$`) && fileExists(G.currentDir+"/"+ck.patchdir+"/"+nextFname)
ck.previousFilename = nextFname
ck.algorithms = nil
}
func (ck *distinfoLinesChecker) checkPatchSha1(line *Line, patchFname, distinfoSha1Hex string) {
patchBytes, err := ioutil.ReadFile(G.currentDir + "/" + patchFname)
if err != nil {
line.errorf("%s does not exist.", patchFname)
return
}
h := sha1.New()
netbsd := []byte("$NetBSD")
for _, patchLine := range bytes.SplitAfter(patchBytes, []byte("\n")) {
if !bytes.Contains(patchLine, netbsd) {
h.Write(patchLine)
}
}
fileSha1Hex := sprintf("%x", h.Sum(nil))
if distinfoSha1Hex != fileSha1Hex {
line.errorf("%s hash of %s differs (distinfo has %s, patch file has %s). Run \"%s makepatchsum\".", "SHA1", patchFname, distinfoSha1Hex, fileSha1Hex, confMake)
}
}
func (ck *distinfoLinesChecker) checkUnrecordedPatches() {
files, err := ioutil.ReadDir(G.currentDir + "/" + ck.patchdir)
if err != nil {
_ = G.opts.DebugUnchecked && debugf(ck.distinfoFilename, noLines, "Cannot read patchesDir %q: %s", ck.patchdir, err)
return
}
for _, file := range files {
patch := file.Name()
if file.Mode().IsRegular() && !ck.patches[patch] {
errorf(ck.distinfoFilename, noLines, "patch %q is not recorded. Run \"%s makepatchsum\".", ck.patchdir+"/"+patch, confMake)
}
}
}
// Inter-package check for differing distfile checksums.
func (ck *distinfoLinesChecker) checkGlobalMismatch(line *Line, fname, alg, hash string) {
if G.ipcDistinfo != nil && !ck.isPatch {
key := alg + ":" + fname
otherHash := G.ipcDistinfo[key]
if otherHash != nil {
if otherHash.hash != hash {
line.errorf("The hash %s for %s is %s, ...", alg, fname, hash)
otherHash.line.errorf("... which differs from %s.", otherHash.hash)
}
} else {
G.ipcDistinfo[key] = &Hash{hash, line}
}
}
}
func (ck *distinfoLinesChecker) checkUncommittedPatch(line *Line, patchName, sha1Hash string) {
if ck.isPatch {
patchFname := ck.patchdir + "/" + patchName
if ck.distinfoIsCommitted && !isCommitted(G.currentDir+"/"+patchFname) {
line.warnf("%s is registered in distinfo but not added to CVS.", patchFname)
}
ck.checkPatchSha1(line, patchFname, sha1Hash)
ck.patches[patchName] = true
}
}
|
