1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
|
package main
import (
check "gopkg.in/check.v1"
"io/ioutil"
"os"
)
func (s *Suite) TestVartypeCheck_AwkCommand(c *check.C) {
newVartypeCheck("PLIST_AWK", "+=", "{print $0}").AwkCommand()
}
func (s *Suite) TestVartypeCheck_BasicRegularExpression(c *check.C) {
newVartypeCheck("REPLACE_FILES.pl", "=", ".*\\.pl$").BasicRegularExpression()
}
func (s *Suite) TestVartypeCheck_BuildlinkDepmethod(c *check.C) {
newVartypeCheck("BUILDLINK_DEPMETHOD.libc", "?=", "full").BuildlinkDepmethod()
newVartypeCheck("BUILDLINK_DEPMETHOD.libc", "?=", "unknown").BuildlinkDepmethod()
c.Check(s.Output(), equals, "WARN: fname:1: Invalid dependency method \"unknown\". Valid methods are \"build\" or \"full\".\n")
}
func (s *Suite) TestVartypeCheck_Category(c *check.C) {
tmpdir := c.MkDir()
categorydir := tmpdir + "/filesyscategory"
categoryMakefile := categorydir + "/Makefile"
os.Mkdir(categorydir, 0777)
ioutil.WriteFile(categoryMakefile, []byte("# Nothing\n"), 0777)
G.currentDir = tmpdir
G.curPkgsrcdir = "."
newVartypeCheck("CATEGORIES", "=", "chinese").Category()
newVartypeCheck("CATEGORIES", "=", "arabic").Category()
newVartypeCheck("CATEGORIES", "=", "filesyscategory").Category()
c.Check(s.Output(), equals, "ERROR: fname:1: Invalid category \"arabic\".\n")
}
func (s *Suite) TestVartypeCheck_CFlag(c *check.C) {
newVartypeCheck("CFLAGS", "+=", "-Wall").CFlag()
newVartypeCheck("CFLAGS", "+=", "/W3").CFlag()
newVartypeCheck("CFLAGS", "+=", "target:sparc64").CFlag()
newVartypeCheck("CFLAGS", "+=", "-std=c99").CFlag()
newVartypeCheck("CFLAGS", "+=", "-XX:+PrintClassHistogramAfterFullGC").CFlag()
c.Check(s.Output(), equals, ""+
"WARN: fname:1: Compiler flag \"/W3\" should start with a hyphen.\n"+
"WARN: fname:1: Compiler flag \"target:sparc64\" should start with a hyphen.\n"+
"WARN: fname:1: Unknown compiler flag \"-XX:+PrintClassHistogramAfterFullGC\".\n")
}
func (s *Suite) TestVartypeCheck_Comment(c *check.C) {
newVartypeCheck("COMMENT", "=", "Versatile Programming Language").Comment()
newVartypeCheck("COMMENT", "=", "SHORT_DESCRIPTION_OF_THE_PACKAGE").Comment()
newVartypeCheck("COMMENT", "=", "A great package.").Comment()
newVartypeCheck("COMMENT", "=", "some packages need a very very long comment to explain their basic usefulness").Comment()
c.Check(s.Output(), equals, ""+
"ERROR: fname:1: COMMENT must be set.\n"+
"WARN: fname:1: COMMENT should not begin with \"A\".\n"+
"WARN: fname:1: COMMENT should not end with a period.\n"+
"WARN: fname:1: COMMENT should start with a capital letter.\n"+
"WARN: fname:1: COMMENT should not be longer than 70 characters.\n")
}
func (s *Suite) TestVartypeCheck_Dependency(c *check.C) {
newVartypeCheck("CONFLICTS", "+=", "Perl").Dependency()
c.Check(s.Output(), equals, "WARN: fname:1: Unknown dependency format: Perl\n")
newVartypeCheck("CONFLICTS", "+=", "perl5>=5.22").Dependency()
c.Check(s.Output(), equals, "")
newVartypeCheck("CONFLICTS", "+=", "perl5-*").Dependency()
c.Check(s.Output(), equals, "WARN: fname:1: Please use \"perl5-[0-9]*\" instead of \"perl5-*\".\n")
newVartypeCheck("CONFLICTS", "+=", "perl5-5.22.*").Dependency()
c.Check(s.Output(), equals, "WARN: fname:1: Please append \"{,nb*}\" to the version number of this dependency.\n")
newVartypeCheck("CONFLICTS", "+=", "perl5-[5.10-5.22]*").Dependency()
c.Check(s.Output(), equals, "WARN: fname:1: Only [0-9]* is allowed in the numeric part of a dependency.\n")
newVartypeCheck("CONFLICTS", "+=", "py-docs").Dependency()
c.Check(s.Output(), equals, "ERROR: fname:1: Unknown dependency pattern \"py-docs\".\n")
newVartypeCheck("CONFLICTS", "+=", "perl5-5.22.*{,nb*}").Dependency()
c.Check(s.Output(), equals, "")
}
func (s *Suite) TestVartypeCheck_DependencyWithPatch(c *check.C) {
G.curPkgsrcdir = "../.."
newVartypeCheck("DEPENDS", "+=", "Perl").DependencyWithPath()
c.Check(s.Output(), equals, "WARN: fname:1: Unknown dependency format.\n")
newVartypeCheck("DEPENDS", "+=", "perl5>=5.22:../perl5").DependencyWithPath()
c.Check(s.Output(), equals, "WARN: fname:1: Dependencies should have the form \"../../category/package\".\n")
newVartypeCheck("DEPENDS", "+=", "perl5>=5.24:../../lang/perl5").DependencyWithPath()
c.Check(s.Output(), equals, ""+
"ERROR: fname:1: \"../../lang/perl5\" does not exist.\n"+
"ERROR: fname:1: There is no package in \"lang/perl5\".\n"+
"WARN: fname:1: Please use USE_TOOLS+=perl:run instead of this dependency.\n")
}
func (s *Suite) TestVartypeCheck_DistSuffix(c *check.C) {
newVartypeCheck("EXTRACT_SUFX", "=", ".tar.gz").DistSuffix()
newVartypeCheck("EXTRACT_SUFX", "=", ".tar.bz2").DistSuffix()
c.Check(s.Output(), equals, "NOTE: fname:1: EXTRACT_SUFX is \".tar.gz\" by default, so this definition may be redundant.\n")
}
func (s *Suite) TestVartypeCheck_EmulPlatform(c *check.C) {
newVartypeCheck("EMUL_PLATFORM", "=", "linux-i386").EmulPlatform()
newVartypeCheck("EMUL_PLATFORM", "=", "nextbsd-8087").EmulPlatform()
newVartypeCheck("EMUL_PLATFORM", "=", "${LINUX}").EmulPlatform()
c.Check(s.Output(), equals, ""+
"WARN: fname:1: Unknown operating system: nextbsd\n"+
"WARN: fname:1: Unknown hardware architecture: 8087\n"+
"WARN: fname:1: \"${LINUX}\" is not a valid emulation platform.\n")
}
func (s *Suite) TestVartypeCheck_FetchURL(c *check.C) {
G.globalData.masterSiteUrls = map[string]string{
"https://github.com/": "MASTER_SITE_GITHUB",
"http://ftp.gnu.org/pub/gnu/": "MASTER_SITE_GNU",
}
G.globalData.masterSiteVars = map[string]bool{
"MASTER_SITE_GITHUB": true,
"MASTER_SITE_GNU": true,
}
newVartypeCheck("MASTER_SITES", "=", "https://github.com/example/project/").FetchURL()
c.Check(s.Output(), equals, ""+
"WARN: fname:1: Please use ${MASTER_SITE_GITHUB:=example/} instead of \"https://github.com/example/project/\".\n"+
"WARN: fname:1: Run \""+confMake+" help topic=github\" for further tips.\n")
newVartypeCheck("MASTER_SITES", "=", "http://ftp.gnu.org/pub/gnu/bison").FetchURL() // Missing a slash at the end
c.Check(s.Output(), equals, "WARN: fname:1: Please use ${MASTER_SITE_GNU:=bison} instead of \"http://ftp.gnu.org/pub/gnu/bison\".\n")
newVartypeCheck("MASTER_SITES", "=", "${MASTER_SITE_GNU:=bison}").FetchURL()
c.Check(s.Output(), equals, "ERROR: fname:1: The subdirectory in MASTER_SITE_GNU must end with a slash.\n")
newVartypeCheck("MASTER_SITES", "=", "${MASTER_SITE_INVALID:=subdir/}").FetchURL()
c.Check(s.Output(), equals, "ERROR: fname:1: MASTER_SITE_INVALID does not exist.\n")
}
func (s *Suite) TestVartypeCheck_Filename(c *check.C) {
newVartypeCheck("FNAME", "=", "Filename with spaces.docx").Filename()
c.Check(s.Output(), equals, "WARN: fname:1: \"Filename with spaces.docx\" is not a valid filename.\n")
newVartypeCheck("FNAME", "=", "OS/2-manual.txt").Filename()
c.Check(s.Output(), equals, "WARN: fname:1: A filename should not contain a slash.\n")
}
func (s *Suite) TestVartypeCheck_MailAddress(c *check.C) {
newVartypeCheck("MAINTAINER", "=", "pkgsrc-users@netbsd.org").MailAddress()
c.Check(s.Output(), equals, "WARN: fname:1: Please write \"NetBSD.org\" instead of \"netbsd.org\".\n")
}
func (s *Suite) TestVartypeCheck_Message(c *check.C) {
newVartypeCheck("SUBST_MESSAGE.id", "=", "\"Correct paths\"").Message()
c.Check(s.Output(), equals, "WARN: fname:1: SUBST_MESSAGE.id should not be quoted.\n")
newVartypeCheck("SUBST_MESSAGE.id", "=", "Correct paths").Message()
c.Check(s.Output(), equals, "")
}
func (s *Suite) TestVartypeCheck_Pathlist(c *check.C) {
newVartypeCheck("PATH", "=", "/usr/bin:/usr/sbin:.:${LOCALBASE}/bin").Pathlist()
c.Check(s.Output(), equals, "WARN: fname:1: All components of PATH (in this case \".\") should be absolute paths.\n")
}
func (s *Suite) TestVartypeCheck_PkgRevision(c *check.C) {
newVartypeCheck("PKGREVISION", "=", "3a").PkgRevision()
c.Check(s.Output(), equals, ""+
"WARN: fname:1: PKGREVISION must be a positive integer number.\n"+
"ERROR: fname:1: PKGREVISION only makes sense directly in the package Makefile.\n")
vc := newVartypeCheck("PKGREVISION", "=", "3")
vc.line.fname = "Makefile"
vc.PkgRevision()
c.Check(s.Output(), equals, "")
}
func (s *Suite) TestVartypeCheck_PlatformTriple(c *check.C) {
newVartypeCheck("ONLY_FOR_PLATFORM", "=", "linux-i386").PlatformTriple()
newVartypeCheck("ONLY_FOR_PLATFORM", "=", "nextbsd-5.0-8087").PlatformTriple()
newVartypeCheck("ONLY_FOR_PLATFORM", "=", "${LINUX}").PlatformTriple()
c.Check(s.Output(), equals, ""+
"WARN: fname:1: \"linux-i386\" is not a valid platform triple.\n"+
"WARN: fname:1: Unknown operating system: nextbsd\n"+
"WARN: fname:1: Unknown hardware architecture: 8087\n")
}
func (s *Suite) TestVartypeCheck_SedCommands(c *check.C) {
newVartypeCheck("SUBST_SED.dummy", "=", "s,@COMPILER@,gcc,g").SedCommands()
c.Check(s.Output(), equals, "NOTE: fname:1: Please always use \"-e\" in sed commands, even if there is only one substitution.\n")
newVartypeCheck("SUBST_SED.dummy", "=", "-e s,a,b, -e a,b,c,").SedCommands()
c.Check(s.Output(), equals, "NOTE: fname:1: Each sed command should appear in an assignment of its own.\n")
}
func (s *Suite) TestVartypeCheck_Stage(c *check.C) {
newVartypeCheck("SUBST_STAGE.dummy", "=", "post-patch").Stage()
c.Check(s.Output(), equals, "")
newVartypeCheck("SUBST_STAGE.dummy", "=", "post-modern").Stage()
c.Check(s.Output(), equals, "WARN: fname:1: Invalid stage name \"post-modern\". Use one of {pre,do,post}-{extract,patch,configure,build,test,install}.\n")
newVartypeCheck("SUBST_STAGE.dummy", "=", "pre-test").Stage()
c.Check(s.Output(), equals, "")
}
func (s *Suite) TestVartypeCheck_Yes(c *check.C) {
newVartypeCheck("APACHE_MODULE", "=", "yes").Yes()
c.Check(s.Output(), equals, "")
newVartypeCheck("APACHE_MODULE", "=", "no").Yes()
c.Check(s.Output(), equals, "WARN: fname:1: APACHE_MODULE should be set to YES or yes.\n")
newVartypeCheck("APACHE_MODULE", "=", "${YESVAR}").Yes()
c.Check(s.Output(), equals, "WARN: fname:1: APACHE_MODULE should be set to YES or yes.\n")
}
func newVartypeCheck(varname, op, value string) *VartypeCheck {
line := NewLine("fname", "1", "dummy", nil)
valueNovar := withoutMakeVariables(line, value, true)
return &VartypeCheck{line, varname, op, value, valueNovar, "", true, NOT_GUESSED}
}
|
