From b0e279670a4d96c9929b70a658e3b1dc09ae50ee Mon Sep 17 00:00:00 2001 From: Sean Finney Date: Thu, 13 May 2010 13:10:40 +0200 Subject: Remove dead patch handling code --- patchtracker/ReqHandler.py | 63 +------------------ patchtracker/Templates.py | 22 +------ templates/package_vers.tmpl | 149 -------------------------------------------- templates/patch_view.tmpl | 33 ---------- 4 files changed, 3 insertions(+), 264 deletions(-) delete mode 100755 templates/package_vers.tmpl delete mode 100644 templates/patch_view.tmpl diff --git a/patchtracker/ReqHandler.py b/patchtracker/ReqHandler.py index da23525..ca81be7 100755 --- a/patchtracker/ReqHandler.py +++ b/patchtracker/ReqHandler.py @@ -5,9 +5,7 @@ import os import sys import patchtracker.Conf as Conf -from patchtracker.Templates import ErrorTemplate, PatchTemplate, LetterTocTemplate, FrontPageTemplate, SearchResultsTemplate -from patchtracker.DiffGzHandler import DiffGzHandler, DiffGzException -from patchtracker.DebTarHandler import DebTarHandler +from patchtracker.Templates import ErrorTemplate, LetterTocTemplate, FrontPageTemplate, SearchResultsTemplate from patchtracker.CacheObject import CacheObject, CacheMissException import patchtracker.DB as DB from patchtracker.DB import PatchTrackerDB @@ -35,58 +33,6 @@ class ErrorCmd(Cmd): def output(self): return str(ErrorTemplate(self.msg)) -class PatchCmd(Cmd): - def __init__(self, args): - Cmd.__init__(self) - self.db = PatchTrackerDB() - self.patchtype,mode,pkgname,version = args[0:4] - self.parsemode(mode) - dh = self.make_diffhandler(pkgname,version) - if self.patchtype == "series": - self.patchname = os.sep.join(args[4:]) - self.content = dh.series().fetch(self.patchname) - elif self.patchtype == "debianonly": - self.patchname = "debian-dir only changes" - self.content = dh.debiandir() - elif self.patchtype == "nondebian": - self.patchname = "direct (non packaging) changes" - self.content = dh.nondebiandir() - elif self.patchtype == "misc": - self.patchname = os.sep.join(args[4:]) - self.content = dh.filterdiff(include=self.patchname) - else: - raise ReqHandlerException("unhandled patch type '%s'"%(self.patchtype)) - self.pkgname = pkgname - self.version = version - - def parsemode(self, mode): - if mode == "view" or mode == "dl": - self.mode = mode - else: - raise ReqHandlerException("unhandled display mode '%s'"%(mode)) - if mode == "dl": - self.content_type = "text/x-diff" - - # XXX this is kinda ugly... - def make_diffhandler(self, pkgname, vers): - dfile = self.db.findDiffGz(pkgname,vers) - if dfile: - return DiffGzHandler(dfile) - else: - dfile = self.db.findDebTar(pkgname, vers) - if dfile: - return DebTarHandler(dfile) - else: - raise ReqHandlerException("can not find diff file for %s / %s"%(pkgname,vers)) - - def output(self): - if self.mode == "dl": - return str(self.content) - else: - return str(PatchTemplate(pkg=self.pkgname,vers=self.version, - patch=self.content,name=self.patchname, - patchtype=self.patchtype)) - class PackageCmd(Cmd): def __init__(self, args): Cmd.__init__(self) @@ -173,10 +119,7 @@ class CmdHandler: args = uri[len(Conf.root_url)+1:].split("/") cmdarg = args[0] cacheable = False - if cmdarg == "patch": - self.cmd = PatchCmd(args[1:]) - cacheable = True - elif cmdarg == "package": + if cmdarg == "package": self.cmd = PackageCmd(args[1:]) if len(args[1:]) > 1: cacheable = True @@ -208,8 +151,6 @@ class CmdHandler: except CacheMissException: result = self.cmd.output() self.cacheobj.put(result) - except DiffGzException, e: - return ErrorCmd(str(e), "500 Oh Noez!!1!").output() return result diff --git a/patchtracker/Templates.py b/patchtracker/Templates.py index 7d599c5..42e07dc 100755 --- a/patchtracker/Templates.py +++ b/patchtracker/Templates.py @@ -1,6 +1,4 @@ -from patchtracker import Conf, DB -from patchtracker.DiffGzHandler import DiffGzHandler -from patchtracker.DebTarHandler import DebTarHandler +from patchtracker import Conf from patchtracker.SourceArchive import ReleaseList from Cheetah.Template import Template @@ -64,21 +62,3 @@ class ErrorTemplate(OurTemplate): tpl = os.sep.join([Conf.template_dir, "cgi_error.tmpl"]) OurTemplate.__init__(self, file=tpl, searchList={'error':msg}) -class PatchTemplate(OurTemplate): - def __init__(self, pkg=None, vers=None, name=None, patch=None,patchtype=None): - tpl = os.sep.join([Conf.template_dir, "patch_view.tmpl"]) - sl = {'package':pkg, 'version':vers, 'name':name, - 'patch':patch, 'patchtype':patchtype} - sl['crumbs'] = [("package/"+pkg,pkg), - ("package/"+pkg+"/"+vers, pkg+"/"+vers)] - if patchtype == "debianonly": - sl['crumbs'].append( ("patch/%s/view/%s/%s"%(patchtype,pkg,vers), - "./debian-dir only patch") ) - elif patchtype == "series": - sl['crumbs'].append(("patch/%s/view/%s/%s/%s"%(patchtype,pkg,vers,name), - "series patch "+name) ) - elif patchtype == "misc": - sl['crumbs'].append(("patch/%s/view/%s/%s/%s"%(patchtype,pkg,vers,name), - "direct patch of "+name) ) - OurTemplate.__init__(self, file=tpl, searchList=sl) - diff --git a/templates/package_vers.tmpl b/templates/package_vers.tmpl deleted file mode 100755 index 23ab83e..0000000 --- a/templates/package_vers.tmpl +++ /dev/null @@ -1,149 +0,0 @@ -#import templates -#extends templates.skeleton -#def title -debian specific patch information for $src.name / $src.version -#end def -#def body - #set $u = $conf.root_url -

debian specific patch information for $src.name / $src.version

-
- -

Summary

- - - - - - - - - - - -
Package VersionPackage TypeSource Package Format
$src.version$src.type$src.format
-
- -#if $src.debtar_name -
- -

Debian packaging Information

- - - - - - - - - - - -
Debian changes tarfile - - $src.debtar_name - -
Size$src.debtar_size
MD5sum$src.debtar_md5sum
-
-#end if - -#if $src.diffgz_name -
- -

Debian packaging Information

- - - - - - - - - - - - - - - - - #if $src.diffgz_name and $diffhandler.nondebiandir.lines - - - - - - #end if -
Diff file - - $src.diffgz_name - -
Size$src.diffgz_size
MD5sum$src.diffgz_md5sum
./debian only changes - view - - download -
non packaging (i.e. not ./debian) changes - view - - download -
-
- #end if - -#if $src.diffgz_name and $diffhandler.nondebiandir.lines -
- -

Misc. Non-packaging "direct" style patches

- - - - - - - - - - #for $insd,$deld,$modd,$f in $diffhandler.nondebiandir.diffstat.stats - - - - - - #end for -
fileinserteddeletedmodifiedviewdownload
$f$insd$deld$modd - view - - download -
-
-#end if - -#if $src.diffgz_name or $src.debtar_name -#set $series = $diffhandler.series -#if $series -
- -

"series" style patches

- - - - - - - - #for $name,$patch in $series.iterpatches() - - - - - - - #end for -
patchsummaryviewraw
$name
$patch.diffstat
 - view - - download -
-
-#end if -#end if -#end def diff --git a/templates/patch_view.tmpl b/templates/patch_view.tmpl deleted file mode 100644 index 0a715b9..0000000 --- a/templates/patch_view.tmpl +++ /dev/null @@ -1,33 +0,0 @@ -#import templates -#extends templates.skeleton -#import pygments -#from pygments.lexers import DiffLexer -#from pygments.formatters import HtmlFormatter -#from cgi import escape -#def title -Patch information for $package ($version) $name -#end def -#def body -

$package ($version) $name

-

Summary

-
- - 
-$escape($str($patch.diffstat))
-
- -
-
- - download this patch - -
-

Patch contents

-
- #try - $pygments.highlight($str($patch).decode('utf-8'), $DiffLexer(), $HtmlFormatter(style='colorful', noclasses=True, encoding='utf-8')) - #except UnicodeDecodeError - $pygments.highlight($str($patch).decode('latin-1'), $DiffLexer(), $HtmlFormatter(style='colorful', noclasses=True, encoding='latin-1')) - #end try -
-#end def -- cgit v1.2.3