summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2010-02-02 18:19:27 -0800
committerRuss Cox <rsc@golang.org>2010-02-02 18:19:27 -0800
commit1989a2bebe4e9908fce31d93076bcb291873e87f (patch)
tree8fa23558f4f7aece526d382fd27f3f1d449aaca0
parent3f3ae50ab8a0c20d079ee0411cfee83d8c399a1b (diff)
downloadgolang-1989a2bebe4e9908fce31d93076bcb291873e87f.tar.gz
fix build - misc ... vs ...T fixes
TBR=r CC=golang-dev http://codereview.appspot.com/198081
-rw-r--r--src/pkg/encoding/ascii85/ascii85_test.go8
-rw-r--r--src/pkg/encoding/base64/base64_test.go8
-rw-r--r--src/pkg/encoding/git85/git_test.go8
-rw-r--r--src/pkg/exp/datafmt/datafmt.go3
4 files changed, 8 insertions, 19 deletions
diff --git a/src/pkg/encoding/ascii85/ascii85_test.go b/src/pkg/encoding/ascii85/ascii85_test.go
index 7eb245ee2..3219d49e0 100644
--- a/src/pkg/encoding/ascii85/ascii85_test.go
+++ b/src/pkg/encoding/ascii85/ascii85_test.go
@@ -8,7 +8,6 @@ import (
"bytes"
"io/ioutil"
"os"
- "reflect"
"strings"
"testing"
)
@@ -34,11 +33,8 @@ var pairs = []testpair{
var bigtest = pairs[len(pairs)-1]
-func testEqual(t *testing.T, msg string, args ...) bool {
- v := reflect.NewValue(args).(*reflect.StructValue)
- v1 := v.Field(v.NumField() - 2)
- v2 := v.Field(v.NumField() - 1)
- if v1.Interface() != v2.Interface() {
+func testEqual(t *testing.T, msg string, args ...interface{}) bool {
+ if args[len(args)-2] != args[len(args)-1] {
t.Errorf(msg, args)
return false
}
diff --git a/src/pkg/encoding/base64/base64_test.go b/src/pkg/encoding/base64/base64_test.go
index fe66cff7e..f26f8f2ce 100644
--- a/src/pkg/encoding/base64/base64_test.go
+++ b/src/pkg/encoding/base64/base64_test.go
@@ -8,7 +8,6 @@ import (
"bytes"
"io/ioutil"
"os"
- "reflect"
"strings"
"testing"
)
@@ -48,11 +47,8 @@ var bigtest = testpair{
"VHdhcyBicmlsbGlnLCBhbmQgdGhlIHNsaXRoeSB0b3Zlcw==",
}
-func testEqual(t *testing.T, msg string, args ...) bool {
- v := reflect.NewValue(args).(*reflect.StructValue)
- v1 := v.Field(v.NumField() - 2)
- v2 := v.Field(v.NumField() - 1)
- if v1.Interface() != v2.Interface() {
+func testEqual(t *testing.T, msg string, args ...interface{}) bool {
+ if args[len(args)-2] != args[len(args)-1] {
t.Errorf(msg, args)
return false
}
diff --git a/src/pkg/encoding/git85/git_test.go b/src/pkg/encoding/git85/git_test.go
index 4a42282fe..0eb65129d 100644
--- a/src/pkg/encoding/git85/git_test.go
+++ b/src/pkg/encoding/git85/git_test.go
@@ -8,7 +8,6 @@ import (
"bytes"
"io/ioutil"
"os"
- "reflect"
"strings"
"testing"
)
@@ -17,11 +16,8 @@ type testpair struct {
decoded, encoded string
}
-func testEqual(t *testing.T, msg string, args ...) bool {
- v := reflect.NewValue(args).(*reflect.StructValue)
- v1 := v.Field(v.NumField() - 2)
- v2 := v.Field(v.NumField() - 1)
- if v1.Interface() != v2.Interface() {
+func testEqual(t *testing.T, msg string, args ...interface{}) bool {
+ if args[len(args)-2] != args[len(args)-1] {
t.Errorf(msg, args)
return false
}
diff --git a/src/pkg/exp/datafmt/datafmt.go b/src/pkg/exp/datafmt/datafmt.go
index cd9af2b6a..7472a97a9 100644
--- a/src/pkg/exp/datafmt/datafmt.go
+++ b/src/pkg/exp/datafmt/datafmt.go
@@ -721,7 +721,8 @@ func (f Format) Sprint(args ...) string {
var buf bytes.Buffer
_, err := f.Fprint(&buf, nil, args)
if err != nil {
- fmt.Fprintf(&buf, "--- Sprint(%s) failed: %v", fmt.Sprint(args), err)
+ var i interface{} = args
+ fmt.Fprintf(&buf, "--- Sprint(%s) failed: %v", fmt.Sprint(i), err)
}
return buf.String()
}