summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2008-10-17 17:51:29 -0700
committerRuss Cox <rsc@golang.org>2008-10-17 17:51:29 -0700
commit47b9fa3aea99bd1ae22b28f06095eb9e467b6ed8 (patch)
tree22fc19c120657a41e0254538c4cfe8407b0c2534
parent626f09b1522cfd62c16e9f902a92da29c9bdc29f (diff)
downloadgolang-47b9fa3aea99bd1ae22b28f06095eb9e467b6ed8.tar.gz
do not set t->recur on basic types.
the comment talked about printing, but now t->recur is only used for typehash. in typehash it is important to compute different hashes for the different basic types. add test that makes sure an interface { X() int8 } cannot be used as interface { X() int64 } R=ken OCL=17396 CL=17396
-rw-r--r--src/cmd/gc/lex.c1
-rw-r--r--test/golden.out8
-rw-r--r--test/interface3.go23
3 files changed, 31 insertions, 1 deletions
diff --git a/src/cmd/gc/lex.c b/src/cmd/gc/lex.c
index d0bff2741..de9700da3 100644
--- a/src/cmd/gc/lex.c
+++ b/src/cmd/gc/lex.c
@@ -1120,7 +1120,6 @@ lexinit(void)
}
t->sym = s;
- t->recur = 1; // supresses printing beyond name
dowidth(t);
types[etype] = t;
diff --git a/test/golden.out b/test/golden.out
index 19988f2aa..9139d49d9 100644
--- a/test/golden.out
+++ b/test/golden.out
@@ -34,6 +34,14 @@ Faulting address: 0x0
pc: xxx
+=========== ./interface3.go
+cannot convert type S to interface I2: missing method Name
+throw: interface conversion
+SIGSEGV: segmentation violation
+Faulting address: 0x0
+pc: xxx
+
+
=========== ./peano.go
0! = 1
1! = 1
diff --git a/test/interface3.go b/test/interface3.go
new file mode 100644
index 000000000..04af91a02
--- /dev/null
+++ b/test/interface3.go
@@ -0,0 +1,23 @@
+// $G $D/$F.go && $L $F.$A && (! ./$A.out || echo BUG: should not succeed)
+
+// Copyright 2009 The Go Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style
+// license that can be found in the LICENSE file.
+
+package main
+
+type S struct { a int }
+type T struct { b string }
+
+func (s *S) Name() int8 { return 1 }
+func (t *T) Name() int64 { return 64 }
+
+type I1 interface { Name() int8 }
+type I2 interface { Name() int64 }
+
+func main() {
+ var i1 I1;
+ var s *S;
+ i1 = s;
+ print(i1.(I2).Name())
+}