summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRobert Griesemer <gri@golang.org>2008-09-11 15:38:22 -0700
committerRobert Griesemer <gri@golang.org>2008-09-11 15:38:22 -0700
commitd65d770b3ac7dc400eb1ef0a68da7955db572ef3 (patch)
tree1b6c14be41954c6fdcf8d5aa4340300e9bb8eff1
parent51fc664eae48e6645eedbf7d02efd8018654fe5b (diff)
downloadgolang-d65d770b3ac7dc400eb1ef0a68da7955db572ef3.tar.gz
- fixed missing return issues
R=r OCL=15168 CL=15168
-rwxr-xr-xsrc/pkg/integer.go2
-rw-r--r--usr/gri/gosrc/parser.go9
-rw-r--r--usr/gri/gosrc/scanner.go2
3 files changed, 10 insertions, 3 deletions
diff --git a/src/pkg/integer.go b/src/pkg/integer.go
index b10c73577..f6184c4cb 100755
--- a/src/pkg/integer.go
+++ b/src/pkg/integer.go
@@ -572,7 +572,7 @@ func (x Integer) cmp (y Integer) int {
case zero(d.val): return 0;
default : return +1;
}
- CHECK(false); // unreachable
+ panic("UNREACHABLE");
}
diff --git a/usr/gri/gosrc/parser.go b/usr/gri/gosrc/parser.go
index 6cccb5508..95f1771fe 100644
--- a/usr/gri/gosrc/parser.go
+++ b/usr/gri/gosrc/parser.go
@@ -348,6 +348,8 @@ func (P *Parser) ParseQualifiedIdent(pos int, ident string) *Globals.Object {
P.Ecart();
return nil;
}
+
+ panic("UNREACHABLE");
}
@@ -412,6 +414,8 @@ func (P *Parser) ParseTypeName() *Globals.Type {
P.Ecart();
return Universe.bad_t;
}
+
+ panic("UNREACHABLE");
}
@@ -1525,6 +1529,7 @@ func (P *Parser) ParseIfStat() *AST.IfStat {
P.CloseScope();
P.Ecart();
+ return nil;
}
@@ -1657,7 +1662,7 @@ func (P *Parser) ParseCommClause() {
}
-func (P *Parser) ParseRangeStat() bool {
+func (P *Parser) ParseRangeStat() {
P.Trace("RangeStat");
P.Expect(Scanner.RANGE);
@@ -1670,7 +1675,7 @@ func (P *Parser) ParseRangeStat() bool {
}
-func (P *Parser) ParseSelectStat() bool {
+func (P *Parser) ParseSelectStat() {
P.Trace("SelectStat");
P.Expect(Scanner.SELECT);
diff --git a/usr/gri/gosrc/scanner.go b/usr/gri/gosrc/scanner.go
index 956d0facf..39d576046 100644
--- a/usr/gri/gosrc/scanner.go
+++ b/usr/gri/gosrc/scanner.go
@@ -609,6 +609,8 @@ func (S *Scanner) ScanEscape() string {
default:
S.Error(pos, "illegal char escape");
}
+
+ return ""; // TODO fix this
}