diff options
| author | Devon H. O'Dell <devon.odell@gmail.com> | 2009-11-17 08:32:23 -0800 |
|---|---|---|
| committer | Devon H. O'Dell <devon.odell@gmail.com> | 2009-11-17 08:32:23 -0800 |
| commit | b0a876be0baae3b1e3d1bf3865dcd96167d973fb (patch) | |
| tree | bd133971afe1b4b0822edbf0074a222980dc60c8 /lib/codereview/codereview.py | |
| parent | 429e86b5b7166734d6757e292b1548c39ff384bd (diff) | |
| download | golang-b0a876be0baae3b1e3d1bf3865dcd96167d973fb.tar.gz | |
Pass ui into PostMessage to avoid nasty/confusing exception
R=rsc
http://codereview.appspot.com/155079
Committer: Russ Cox <rsc@golang.org>
Diffstat (limited to 'lib/codereview/codereview.py')
| -rw-r--r-- | lib/codereview/codereview.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 499b0061f..dd56de8b1 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -702,7 +702,7 @@ def change(ui, repo, *pats, **opts): if opts["delete"]: if cl.original_author: return "original author must delete CL; hg change -D will remove locally" - PostMessage(cl.name, "*** Abandoned ***", send_mail="checked") + PostMessage(ui, cl.name, "*** Abandoned ***", send_mail="checked") EditDesc(cl.name, closed="checked") cl.Delete(ui, repo) return @@ -903,7 +903,7 @@ def mail(ui, repo, *pats, **opts): pmsg += ",\n" pmsg += "\n" pmsg += "I'd like you to review the following change.\n" - PostMessage(cl.name, pmsg, send_mail="checked", subject=cl.Subject()) + PostMessage(ui, cl.name, pmsg, send_mail="checked", subject=cl.Subject()) def nocommit(ui, repo, *pats, **opts): """(disabled when using this extension)""" @@ -1059,7 +1059,7 @@ def submit(ui, repo, *pats, **opts): else: print >>sys.stderr, "URL: ", url pmsg = "*** Submitted as " + changeURL + " ***\n\n" + opts['message'] - PostMessage(cl.name, pmsg, send_mail="checked") + PostMessage(ui, cl.name, pmsg, send_mail="checked") if not cl.original_author: EditDesc(cl.name, closed="checked") cl.Delete(ui, repo) @@ -1517,7 +1517,7 @@ def PostMessage1(issue, message, reviewers=None, cc=None, send_mail=None, subjec print response sys.exit(2) -def PostMessage(issue, message, reviewers=None, cc=None, send_mail=None, subject=None): +def PostMessage(ui, issue, message, reviewers=None, cc=None, send_mail=None, subject=None): # When Rietveld is busy, it seems to throw off a lot of HTTP Error 500: Internal Server Error. # Rather than abort, sleep and try again. # Even if the second time fails, let the overall hg command keep going. |