summaryrefslogtreecommitdiff
path: root/lib/codereview/codereview.py
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2009-11-12 18:37:39 -0800
committerRuss Cox <rsc@golang.org>2009-11-12 18:37:39 -0800
commitb823121815713c494cf9658643b1f87c595dae72 (patch)
tree22ce48f3be5f221e5c0bd8d4bf4c924c7260e67d /lib/codereview/codereview.py
parent8b14f3bd4711a103e323d652cca8cc91fadff196 (diff)
downloadgolang-b823121815713c494cf9658643b1f87c595dae72.tar.gz
codereview: clpatch tweaks
R=agl1 http://codereview.appspot.com/152114
Diffstat (limited to 'lib/codereview/codereview.py')
-rw-r--r--lib/codereview/codereview.py10
1 files changed, 7 insertions, 3 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 5f2e17d8d..499b0061f 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -1352,10 +1352,14 @@ def DownloadCL(ui, repo, clname):
try:
data = MySend("/user_popup/" + nick, force_auth=False)
except:
- return None, None, "error looking up %s: %s" % (nick, ExceptionDetail())
+ ui.warn("error looking up %s: %s\n" % (nick, ExceptionDetail()))
+ cl.original_author = nick+"@needtofix"
+ return cl, diffdata, ""
match = re.match(r"<b>(.*) \((.*)\)</b>", data)
- if not match or match.group(2) != nick:
- return None, None, "error looking up %s: cannot parse result" % (nick,)
+ if not match:
+ return None, None, "error looking up %s: cannot parse result %s" % (nick, repr(data))
+ if match.group(1) != nick and match.group(2) != nick:
+ return None, None, "error looking up %s: got info for %s, %s" % (nick, match.group(1), match.group(2))
email = match.group(1)
# Temporary hack until we move to the public code review server.