diff options
| author | Russ Cox <rsc@golang.org> | 2009-11-17 16:52:36 -0800 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2009-11-17 16:52:36 -0800 |
| commit | e6ecaea0d007cdaf14824a59547c1f7e5e635e40 (patch) | |
| tree | 48363c77aa64f7f6756ddb1e582f5cbe44277380 /lib/codereview/codereview.py | |
| parent | 2ddf8ba005389183031c1c6e1479fb5591d53425 (diff) | |
| download | golang-e6ecaea0d007cdaf14824a59547c1f7e5e635e40.tar.gz | |
codereview: handle spaces and other unexpected chars in nicknames
R=r
http://codereview.appspot.com/157053
Diffstat (limited to 'lib/codereview/codereview.py')
| -rw-r--r-- | lib/codereview/codereview.py | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py index 3376f0736..bed002b9f 100644 --- a/lib/codereview/codereview.py +++ b/lib/codereview/codereview.py @@ -1351,7 +1351,9 @@ def DownloadCL(ui, repo, clname): # The author is just a nickname: get the real email address. try: - data = MySend("/user_popup/" + nick, force_auth=False) + # want URL-encoded nick, but without a=, and rietveld rejects + for %20. + url = "/user_popup/" + urllib.urlencode({"a": nick})[2:].replace("+", "%20") + data = MySend(url, force_auth=False) except: ui.warn("error looking up %s: %s\n" % (nick, ExceptionDetail())) cl.original_author = nick+"@needtofix" |