summaryrefslogtreecommitdiff
path: root/lib/codereview/codereview.py
diff options
context:
space:
mode:
authorPaolo Giarrusso <p.giarrusso@gmail.com>2010-06-09 21:37:11 -0700
committerPaolo Giarrusso <p.giarrusso@gmail.com>2010-06-09 21:37:11 -0700
commit16257ed30b89ad3c0eef072623913396e4b6c1fb (patch)
tree20510f21b5861be0fd13039ba438052fee48b40d /lib/codereview/codereview.py
parentcbd8d32cecf39be549c28cbcddfbf0219c5dcaac (diff)
downloadgolang-16257ed30b89ad3c0eef072623913396e4b6c1fb.tar.gz
codereview: avoid exception in match
R=rsc CC=golang-dev http://codereview.appspot.com/1585041 Committer: Russ Cox <rsc@golang.org>
Diffstat (limited to 'lib/codereview/codereview.py')
-rw-r--r--lib/codereview/codereview.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/lib/codereview/codereview.py b/lib/codereview/codereview.py
index 4b1797a7f..1ece1fa3a 100644
--- a/lib/codereview/codereview.py
+++ b/lib/codereview/codereview.py
@@ -659,6 +659,7 @@ original_match = None
def ReplacementForCmdutilMatch(repo, pats=[], opts={}, globbed=False, default='relpath'):
taken = []
files = []
+ pats = pats or []
for p in pats:
if p.startswith('@'):
taken.append(p)
@@ -671,7 +672,7 @@ def ReplacementForCmdutilMatch(repo, pats=[], opts={}, globbed=False, default='r
if cl.files == None:
raise util.Abort("no files in CL " + clname)
files = Add(files, cl.files)
- pats = Sub(pats, taken) + ['path:'+f for f in files]
+ pats = Sub(pats, taken) + ['path:'+f for f in files]
return original_match(repo, pats=pats, opts=opts, globbed=globbed, default=default)
def RelativePath(path, cwd):