summaryrefslogtreecommitdiff
path: root/src/cmd/fix/httpfinalurl.go
diff options
context:
space:
mode:
authorMichael Stapelberg <stapelberg@debian.org>2013-03-04 21:27:43 +0100
committerMichael Stapelberg <michael@stapelberg.de>2013-03-04 21:27:43 +0100
commitad47422646a18ffcb47cec916ef7393c923f2e76 (patch)
tree7c7861fb3d9539d61c1dcfd5b8dadee974c25760 /src/cmd/fix/httpfinalurl.go
parent2c8d5d584a79781ca41bb6f4b396893fbbac5b97 (diff)
parent04b08da9af0c450d645ab7389d1467308cfc2db8 (diff)
downloadgolang-ad47422646a18ffcb47cec916ef7393c923f2e76.tar.gz
Merge tag 'upstream/1.1_hg20130304' into debian-sid
Upstream version 1.1~hg20130304
Diffstat (limited to 'src/cmd/fix/httpfinalurl.go')
-rw-r--r--src/cmd/fix/httpfinalurl.go57
1 files changed, 0 insertions, 57 deletions
diff --git a/src/cmd/fix/httpfinalurl.go b/src/cmd/fix/httpfinalurl.go
deleted file mode 100644
index 49b9f1c51..000000000
--- a/src/cmd/fix/httpfinalurl.go
+++ /dev/null
@@ -1,57 +0,0 @@
-// Copyright 2011 The Go Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style
-// license that can be found in the LICENSE file.
-
-package main
-
-import (
- "go/ast"
-)
-
-func init() {
- register(httpFinalURLFix)
-}
-
-var httpFinalURLFix = fix{
- "httpfinalurl",
- "2011-05-13",
- httpfinalurl,
- `Adapt http Get calls to not have a finalURL result parameter.
-
-http://codereview.appspot.com/4535056/
-`,
-}
-
-func httpfinalurl(f *ast.File) bool {
- if !imports(f, "http") {
- return false
- }
-
- fixed := false
- walk(f, func(n interface{}) {
- // Fix up calls to http.Get.
- //
- // If they have blank identifiers, remove them:
- // resp, _, err := http.Get(url)
- // -> resp, err := http.Get(url)
- //
- // But if they're using the finalURL parameter, warn:
- // resp, finalURL, err := http.Get(url)
- as, ok := n.(*ast.AssignStmt)
- if !ok || len(as.Lhs) != 3 || len(as.Rhs) != 1 {
- return
- }
-
- if !isCall(as.Rhs[0], "http", "Get") {
- return
- }
-
- if isBlank(as.Lhs[1]) {
- as.Lhs = []ast.Expr{as.Lhs[0], as.Lhs[2]}
- fixed = true
- } else {
- warn(as.Pos(), "call to http.Get records final URL")
- }
- })
- return fixed
-}