diff options
| author | Adam Langley <agl@golang.org> | 2010-03-05 15:55:26 -0500 |
|---|---|---|
| committer | Adam Langley <agl@golang.org> | 2010-03-05 15:55:26 -0500 |
| commit | d21a2e78d84d4a0e57d330dc3aa257a4f7092fa6 (patch) | |
| tree | ba453e0c7ee8c64d98ad611606bc4a668082e343 /src/pkg/big/int_test.go | |
| parent | 95a68c09203bcff3fe1030b5ad203c7b9961e414 (diff) | |
| download | golang-d21a2e78d84d4a0e57d330dc3aa257a4f7092fa6.tar.gz | |
big: fix mistakes with probablyPrime
probablyPrime would return false negatives in some cases.
This code has now been tested against GMP for several million iterations without issues.
Fixes issue 638.
R=rsc
CC=golang-dev
http://codereview.appspot.com/252041
Diffstat (limited to 'src/pkg/big/int_test.go')
| -rw-r--r-- | src/pkg/big/int_test.go | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/src/pkg/big/int_test.go b/src/pkg/big/int_test.go index 7267adb28..70dbe5900 100644 --- a/src/pkg/big/int_test.go +++ b/src/pkg/big/int_test.go @@ -480,6 +480,9 @@ var primes = []string{ "10953742525620032441", "17908251027575790097", + // http://code.google.com/p/go/issues/detail?id=638 + "18699199384836356663", + "98920366548084643601728869055592650835572950932266967461790948584315647051443", "94560208308847015747498523884063394671606671904944666360068158221458669711639", @@ -503,14 +506,14 @@ func TestProbablyPrime(t *testing.T) { for i, s := range primes { p, _ := new(Int).SetString(s, 10) if !ProbablyPrime(p, 20) { - t.Errorf("#%d prime found to be non-prime", i) + t.Errorf("#%d prime found to be non-prime (%s)", i, s) } } for i, s := range composites { c, _ := new(Int).SetString(s, 10) if ProbablyPrime(c, 20) { - t.Errorf("#%d composite found to be prime", i) + t.Errorf("#%d composite found to be prime (%s)", i, s) } } } |