summaryrefslogtreecommitdiff
path: root/src/pkg/bufio/bufio_test.go
diff options
context:
space:
mode:
authorRob Pike <r@golang.org>2009-09-17 23:51:06 -0700
committerRob Pike <r@golang.org>2009-09-17 23:51:06 -0700
commit7b79ee2545d11bb332aa2ba5e2b1a2509b0aa313 (patch)
treedf353ed3ad6cfa68e97dbaba2e601842547d1dd5 /src/pkg/bufio/bufio_test.go
parent94cb5a646b38b4ac3c4b9e04409e6e5a5e6d5056 (diff)
downloadgolang-7b79ee2545d11bb332aa2ba5e2b1a2509b0aa313.tar.gz
use buf.String() instead of string(buf.Bytes())
use strings.Buffer instead of bytes.Buffer in some places R=rsc DELTA=40 (0 added, 3 deleted, 37 changed) OCL=34770 CL=34775
Diffstat (limited to 'src/pkg/bufio/bufio_test.go')
-rw-r--r--src/pkg/bufio/bufio_test.go11
1 files changed, 5 insertions, 6 deletions
diff --git a/src/pkg/bufio/bufio_test.go b/src/pkg/bufio/bufio_test.go
index 78920eb40..7d590df0b 100644
--- a/src/pkg/bufio/bufio_test.go
+++ b/src/pkg/bufio/bufio_test.go
@@ -60,13 +60,13 @@ func readBytes(buf *Reader) string {
}
func TestReaderSimple(t *testing.T) {
- data := strings.Bytes("hello world");
- b := NewReader(bytes.NewBuffer(data));
+ data := "hello world";
+ b := NewReader(strings.NewBuffer(data));
if s := readBytes(b); s != "hello world" {
t.Errorf("simple hello world test failed: got %q", s);
}
- b = NewReader(newRot13Reader(bytes.NewBuffer(data)));
+ b = NewReader(newRot13Reader(strings.NewBuffer(data)));
if s := readBytes(b); s != "uryyb jbeyq" {
t.Error("rot13 hello world test failed: got %q", s);
}
@@ -148,14 +148,13 @@ func TestReader(t *testing.T) {
for h := 0; h < len(texts); h++ {
text := texts[h];
- textbytes := strings.Bytes(text);
for i := 0; i < len(readMakers); i++ {
for j := 0; j < len(bufreaders); j++ {
for k := 0; k < len(bufsizes); k++ {
readmaker := readMakers[i];
bufreader := bufreaders[j];
bufsize := bufsizes[k];
- read := readmaker.fn(bytes.NewBuffer(textbytes));
+ read := readmaker.fn(strings.NewBuffer(text));
buf, _ := NewReaderSize(read, bufsize);
s := bufreader.fn(buf);
if s != text {
@@ -309,7 +308,7 @@ func TestWriteErrors(t *testing.T) {
func TestNewReaderSizeIdempotent(t *testing.T) {
const BufSize = 1000;
- b, err := NewReaderSize(bytes.NewBuffer(strings.Bytes("hello world")), BufSize);
+ b, err := NewReaderSize(strings.NewBuffer("hello world"), BufSize);
if err != nil {
t.Error("NewReaderSize create fail", err);
}