diff options
author | Robert Griesemer <gri@golang.org> | 2009-07-29 17:01:09 -0700 |
---|---|---|
committer | Robert Griesemer <gri@golang.org> | 2009-07-29 17:01:09 -0700 |
commit | 53abf93013954216d6521b5a10a2202f7d7bcb36 (patch) | |
tree | fe5b6fe43fb4577157bd2c05385b8db29866ebcc /src/pkg/go/parser/parser_test.go | |
parent | 297317cfed550069aeb8442f968d5cdcec9908aa (diff) | |
download | golang-53abf93013954216d6521b5a10a2202f7d7bcb36.tar.gz |
parser:
- Changed filter function for parser.ParsePackage to
take an *os.Dir instead of a filename for more
powerful filters
- Removed TODO in ast.PackageInterface: Now collect
package comments from all package files
- Cleanups in godoc: Use the new ParsePackage and
PackageInterface functions; as a result computing
package information is much simpler now.
R=rsc
DELTA=285 (80 added, 110 deleted, 95 changed)
OCL=32473
CL=32486
Diffstat (limited to 'src/pkg/go/parser/parser_test.go')
-rw-r--r-- | src/pkg/go/parser/parser_test.go | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/src/pkg/go/parser/parser_test.go b/src/pkg/go/parser/parser_test.go index b6618d06e..29719b6de 100644 --- a/src/pkg/go/parser/parser_test.go +++ b/src/pkg/go/parser/parser_test.go @@ -62,7 +62,7 @@ func TestParse3(t *testing.T) { } -func filter(filename string) bool { +func nameFilter(filename string) bool { switch filename { case "parser.go": case "interface.go": @@ -74,9 +74,14 @@ func filter(filename string) bool { } +func dirFilter(d *os.Dir) bool { + return nameFilter(d.Name); +} + + func TestParse4(t *testing.T) { path := "."; - pkg, err := ParsePackage(path, filter, 0); + pkg, err := ParsePackage(path, dirFilter, 0); if err != nil { t.Fatalf("ParsePackage(%s): %v", path, err); } @@ -84,7 +89,7 @@ func TestParse4(t *testing.T) { t.Errorf("incorrect package name: %s", pkg.Name); } for filename, _ := range pkg.Files { - if !filter(filename) { + if !nameFilter(filename) { t.Errorf("unexpected package file: %s", filename); } } |