diff options
author | Russ Cox <rsc@golang.org> | 2010-03-30 10:34:57 -0700 |
---|---|---|
committer | Russ Cox <rsc@golang.org> | 2010-03-30 10:34:57 -0700 |
commit | 74119689619c24f5871056d13d07d56f69ad5f60 (patch) | |
tree | 2ad4647a66bf21bf56d761edba537c237b8e318a /src/pkg/go | |
parent | 74339da2d519a795f33d78f8694eb7b97065d9d7 (diff) | |
download | golang-74119689619c24f5871056d13d07d56f69ad5f60.tar.gz |
single argument panic
note that sortmain.go has been run through hg gofmt;
only the formatting of the day initializers changed.
i'm happy to revert that formatting if you'd prefer.
stop on error in doc/progs/run
R=r
CC=golang-dev
http://codereview.appspot.com/850041
Diffstat (limited to 'src/pkg/go')
-rw-r--r-- | src/pkg/go/ast/walk.go | 2 | ||||
-rw-r--r-- | src/pkg/go/parser/parser.go | 3 | ||||
-rw-r--r-- | src/pkg/go/printer/printer.go | 4 |
3 files changed, 4 insertions, 5 deletions
diff --git a/src/pkg/go/ast/walk.go b/src/pkg/go/ast/walk.go index 2137ddaa4..6c9837a01 100644 --- a/src/pkg/go/ast/walk.go +++ b/src/pkg/go/ast/walk.go @@ -316,7 +316,7 @@ func Walk(v Visitor, node interface{}) { default: fmt.Printf("ast.Walk: unexpected type %T", n) - panic() + panic("ast.Walk") } v.Visit(nil) diff --git a/src/pkg/go/parser/parser.go b/src/pkg/go/parser/parser.go index 2002d3818..6831a53de 100644 --- a/src/pkg/go/parser/parser.go +++ b/src/pkg/go/parser/parser.go @@ -1738,8 +1738,7 @@ func (p *parser) parseForStmt() ast.Stmt { return &ast.ForStmt{pos, s1, p.makeExpr(s2), s3, body} } - panic() // unreachable - return nil + panic("unreachable") } diff --git a/src/pkg/go/printer/printer.go b/src/pkg/go/printer/printer.go index 5a12c6edb..2316a459b 100644 --- a/src/pkg/go/printer/printer.go +++ b/src/pkg/go/printer/printer.go @@ -107,7 +107,7 @@ func (p *printer) internalError(msg ...interface{}) { if debug { fmt.Print(p.pos.String() + ": ") fmt.Println(msg) - panic() + panic("go/printer") } } @@ -791,7 +791,7 @@ func (p *printer) print(args ...interface{}) { } default: fmt.Fprintf(os.Stderr, "print: unsupported argument type %T\n", f) - panic() + panic("go/printer type") } p.pos = next |