diff options
author | Russ Cox <rsc@golang.org> | 2010-01-06 15:45:30 -0800 |
---|---|---|
committer | Russ Cox <rsc@golang.org> | 2010-01-06 15:45:30 -0800 |
commit | 999e90e430e9ca88d00065e55a35b9f2b0bdc8d8 (patch) | |
tree | 00254ae8f31ef3e7bc4f8e36414457c2dbf08f25 /src/pkg/http | |
parent | 007ccd41206ad78871179ab17bd1ecd9bfdfa624 (diff) | |
download | golang-999e90e430e9ca88d00065e55a35b9f2b0bdc8d8.tar.gz |
http: avoid header duplication - take struct fields out of Header map
R=r
CC=golang-dev, petar-m
http://codereview.appspot.com/183132
Diffstat (limited to 'src/pkg/http')
-rw-r--r-- | src/pkg/http/request.go | 14 |
1 files changed, 12 insertions, 2 deletions
diff --git a/src/pkg/http/request.go b/src/pkg/http/request.go index bf1e299d7..10dc08c2b 100644 --- a/src/pkg/http/request.go +++ b/src/pkg/http/request.go @@ -160,6 +160,11 @@ func (req *Request) Write(w io.Writer) os.Error { // Response.{GetHeader,AddHeader} and string constants for "Host", // "User-Agent" and "Referer". for k, v := range req.Header { + // Host, User-Agent, and Referer were sent from structure fields + // above; ignore them if they also appear in req.Header. + if k == "Host" || k == "User-Agent" || k == "Referer" { + continue + } io.WriteString(w, k+": "+v+"\r\n") } @@ -497,8 +502,11 @@ func ReadRequest(b *bufio.Reader) (req *Request, err os.Error) { // GET http://www.google.com/index.html HTTP/1.1 // Host: doesntmatter // the same. In the second case, any Host line is ignored. - if v, present := req.Header["Host"]; present && req.URL.Host == "" { - req.Host = v + if v, present := req.Header["Host"]; present { + if req.URL.Host == "" { + req.Host = v + } + req.Header["Host"] = "", false } // RFC2616: Should treat @@ -525,9 +533,11 @@ func ReadRequest(b *bufio.Reader) (req *Request, err os.Error) { // Pull out useful fields as a convenience to clients. if v, present := req.Header["Referer"]; present { req.Referer = v + req.Header["Referer"] = "", false } if v, present := req.Header["User-Agent"]; present { req.UserAgent = v + req.Header["User-Agent"] = "", false } // TODO: Parse specific header values: |