diff options
| author | Russ Cox <rsc@golang.org> | 2010-04-08 18:15:30 -0700 |
|---|---|---|
| committer | Russ Cox <rsc@golang.org> | 2010-04-08 18:15:30 -0700 |
| commit | 2d19c2d8f2a9d759ecfa73d07ed1bab66f8ac24f (patch) | |
| tree | 9042a434db46b9ee490ca915723872f355fd60f2 /src/pkg/runtime/linux/amd64/signal.c | |
| parent | 1fa9a0c209f50aa6b8eac0755ce6ccd00ff2cf02 (diff) | |
| download | golang-2d19c2d8f2a9d759ecfa73d07ed1bab66f8ac24f.tar.gz | |
runtime: turn divide by zero, nil dereference into panics
tested on linux/amd64, linux/386, linux/arm, darwin/amd64, darwin/386.
freebsd untested; will finish in a separate CL.
for now all the panics are errorStrings.
richer structures can be added as necessary
once the mechanism is shaked out.
R=r
CC=golang-dev
http://codereview.appspot.com/906041
Diffstat (limited to 'src/pkg/runtime/linux/amd64/signal.c')
| -rw-r--r-- | src/pkg/runtime/linux/amd64/signal.c | 37 |
1 files changed, 27 insertions, 10 deletions
diff --git a/src/pkg/runtime/linux/amd64/signal.c b/src/pkg/runtime/linux/amd64/signal.c index 87a5a638b..57cdea132 100644 --- a/src/pkg/runtime/linux/amd64/signal.c +++ b/src/pkg/runtime/linux/amd64/signal.c @@ -54,7 +54,29 @@ sighandler(int32 sig, Siginfo* info, void* context) { Ucontext *uc; Mcontext *mc; - Sigcontext *sc; + Sigcontext *r; + uintptr *sp; + G *gp; + + uc = context; + mc = &uc->uc_mcontext; + r = (Sigcontext*)mc; // same layout, more conveient names + + if((gp = m->curg) != nil && (sigtab[sig].flags & SigPanic)) { + // Make it look like a call to the signal func. + // Have to pass arguments out of band since + // augmenting the stack frame would break + // the unwinding code. + gp->sig = sig; + gp->sigcode0 = info->si_code; + gp->sigcode1 = ((uintptr*)info)[2]; + + sp = (uintptr*)r->rsp; + *--sp = r->rip; + r->rip = (uintptr)sigpanic; + r->rsp = (uintptr)sp; + return; + } if(sigtab[sig].flags & SigQueue) { if(sigsend(sig) || (sigtab[sig].flags & SigIgnore)) @@ -66,23 +88,18 @@ sighandler(int32 sig, Siginfo* info, void* context) exit(2); panicking = 1; - uc = context; - mc = &uc->uc_mcontext; - sc = (Sigcontext*)mc; // same layout, more conveient names - if(sig < 0 || sig >= NSIG) printf("Signal %d\n", sig); else printf("%s\n", sigtab[sig].name); - printf("Faulting address: %p\n", *(void**)info->_sifields); - printf("PC=%X\n", sc->rip); + printf("PC=%X\n", r->rip); printf("\n"); if(gotraceback()){ - traceback((void*)sc->rip, (void*)sc->rsp, 0, (void*)sc->r15); - tracebackothers((void*)sc->r15); - dumpregs(sc); + traceback((void*)r->rip, (void*)r->rsp, 0, (void*)r->r15); + tracebackothers((void*)r->r15); + dumpregs(r); } breakpoint(); |
