diff options
| author | Adam Langley <agl@golang.org> | 2009-11-13 10:08:51 -0800 |
|---|---|---|
| committer | Adam Langley <agl@golang.org> | 2009-11-13 10:08:51 -0800 |
| commit | 6462f9307491d37af52007ae41f72c5fc411e769 (patch) | |
| tree | 84d3734c7512711d549eef0400de8e477b391863 /src/pkg/runtime/malloc.cgo | |
| parent | d98afc3f915fef85f2fe65295d685d6b45025333 (diff) | |
| download | golang-6462f9307491d37af52007ae41f72c5fc411e769.tar.gz | |
runtime: warn about SELinux based mmap failures on Linux.
SELinux will cause mmap to fail when we request w+x memory unless the
user has configured their policies. We have a warning in make.bash,
but it's quite likely that the policy will be reset at some point and
then all their binaries start failing.
This patch prints a warning on Linux when mmap fails with EACCES.
R=rsc
CC=golang-dev
http://codereview.appspot.com/152086
Diffstat (limited to 'src/pkg/runtime/malloc.cgo')
| -rw-r--r-- | src/pkg/runtime/malloc.cgo | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/src/pkg/runtime/malloc.cgo b/src/pkg/runtime/malloc.cgo index 6a769c9e0..3b755fc4e 100644 --- a/src/pkg/runtime/malloc.cgo +++ b/src/pkg/runtime/malloc.cgo @@ -208,8 +208,19 @@ mallocinit(void) void* SysAlloc(uintptr n) { + void *p; mstats.sys += n; - return runtime_mmap(nil, n, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_ANON|MAP_PRIVATE, -1, 0); + p = runtime_mmap(nil, n, PROT_READ|PROT_WRITE|PROT_EXEC, MAP_ANON|MAP_PRIVATE, -1, 0); + if(p < (void*)4096) { + if(p == (void*)EACCES) { + printf("mmap: access denied\n"); + printf("If you're running SELinux, enable execmem for this process.\n"); + } else { + printf("mmap: errno=%p\n", p); + } + exit(2); + } + return p; } void |