summaryrefslogtreecommitdiff
path: root/src
diff options
context:
space:
mode:
authorRuss Cox <rsc@golang.org>2009-04-13 19:14:09 -0700
committerRuss Cox <rsc@golang.org>2009-04-13 19:14:09 -0700
commit3b1ae7db17d35fecb2b43f831e412388ed26bd8c (patch)
treec5afe79ff2bda2cb15e5b83612048de70bba745c /src
parent4948321bee7a9dfb635db68e40eacf5bed25ebd9 (diff)
downloadgolang-3b1ae7db17d35fecb2b43f831e412388ed26bd8c.tar.gz
fix error return in Remove
change canexec to canExec. R=r DELTA=7 (0 added, 0 deleted, 7 changed) OCL=27393 CL=27398
Diffstat (limited to 'src')
-rw-r--r--src/lib/exec.go6
-rw-r--r--src/lib/os/file.go4
2 files changed, 5 insertions, 5 deletions
diff --git a/src/lib/exec.go b/src/lib/exec.go
index effb46fa4..425b94eb3 100644
--- a/src/lib/exec.go
+++ b/src/lib/exec.go
@@ -184,7 +184,7 @@ func (p *Cmd) Close() *os.Error {
return err;
}
-func canexec(file string) bool{
+func canExec(file string) bool{
d, err := os.Stat(file);
if err != nil {
return false;
@@ -203,7 +203,7 @@ func LookPath(file string) (string, *os.Error) {
// but that would not match all the Unix shells.
if strings.Index(file, "/") >= 0 {
- if canexec(file) {
+ if canExec(file) {
return file, nil;
}
return "", os.ENOENT;
@@ -219,7 +219,7 @@ func LookPath(file string) (string, *os.Error) {
// Unix shell semantics: path element "" means "."
dir = ".";
}
- if canexec(dir+"/"+file) {
+ if canExec(dir+"/"+file) {
return dir+"/"+file, nil;
}
}
diff --git a/src/lib/os/file.go b/src/lib/os/file.go
index 80f43bb59..9e98be697 100644
--- a/src/lib/os/file.go
+++ b/src/lib/os/file.go
@@ -287,13 +287,13 @@ func Remove(name string) *os.Error {
// returns EISDIR, so can't use that. However,
// both agree that rmdir(file) returns ENOTDIR,
// so we can use that to decide which error is real.
- // Rmdir might return ENOTDIR if given a bad
+ // Rmdir might also return ENOTDIR if given a bad
// file path, like /etc/passwd/foo, but in that case,
// both errors will be ENOTDIR, so it's okay to
// use the error from unlink.
if e1 != syscall.ENOTDIR {
e = e1;
}
- return ErrnoToError(e1);
+ return ErrnoToError(e);
}