Age | Commit message (Collapse) | Author | Files | Lines |
|
R=rsc
http://codereview.appspot.com/176070
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, r, phf
CC=golang-dev
http://codereview.appspot.com/170046
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/176064
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 422.
R=r
CC=golang-dev
http://codereview.appspot.com/180057
|
|
Fixes issue 71.
R=rsc, r
http://codereview.appspot.com/162056
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 433.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179072
|
|
Fixes issue 405.
R=r
CC=golang-dev, hoisie
http://codereview.appspot.com/180056
|
|
eliminate all tab characters while we're here.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180055
|
|
use Int31n in Intn when possible.
Fixes issue 390.
(using 8g)
Intn1000 50000000 38 ns/op
Int31n1000 50000000 39 ns/op
Int63n1000 20000000 114 ns/op
R=r
CC=golang-dev, skybrian
http://codereview.appspot.com/180054
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/180046
|
|
Fixes issue 401.
R=ken2
http://codereview.appspot.com/180053
|
|
Fixes issue 403.
R=ken2
http://codereview.appspot.com/180052
|
|
Fixes issue 407.
R=rsc, ajstarks
CC=ushakov
http://codereview.appspot.com/176076
Committer: Russ Cox <rsc@golang.org>
|
|
* better error for lookup of unexported field
* do not assign "ideal string" type to typed string literal
* do not confuse methods and fields during interface check
Fixes issue 410.
Fixes issue 411.
Fixes issue 426.
R=ken2
http://codereview.appspot.com/179069
|
|
R=ken2
http://codereview.appspot.com/179070
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
5th and last set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180050
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
4th set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180049
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
3rd set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180048
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
1st set of files.
R=rsc
CC=agl, golang-dev, iant, ken2, r
http://codereview.appspot.com/180047
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/179063
|
|
parsing and printing to new syntax.
Use -oldparser to parse the old syntax,
use -oldprinter to print the old syntax.
2) Change default gofmt formatting settings
to use tabs for indentation only and to use
spaces for alignment. This will make the code
alignment insensitive to an editor's tabwidth.
Use -spaces=false to use tabs for alignment.
3) Manually changed src/exp/parser/parser_test.go
so that it doesn't try to parse the parser's
source files using the old syntax (they have
new syntax now).
4) gofmt -w src misc test/bench
2nd set of files.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179067
|
|
Fixes issue 423.
R=ken2
http://codereview.appspot.com/180045
|
|
Fixes issue 384.
R=ken2
http://codereview.appspot.com/179061
|
|
Pull the struct into a single line, since 6g reports the error
on the last line of the struct definition and gccgo reports it
on the first line.
6g:
bug215.go:12: invalid recursive type A
gccgo:
bug215.go:12:6: error: invalid recursive type ‘A’
R=rsc
http://codereview.appspot.com/180044
|
|
automatically in "hg mail".
also, avoid "empty list means all modified files in client" bug
R=gri, cw
CC=golang-dev
http://codereview.appspot.com/174072
|
|
that introduce the newline (important for correct placement
of comments with gofmt when parsing new syntax)
R=rsc
http://codereview.appspot.com/179055
|
|
mustgetc reports unexpected EOF as SyntaxError. using
mustgetc seems to be a better approach than letting the
caller handle unexpected EOF every time.
name: the second if statement should explicitly return
ok==false.
R=rsc
http://codereview.appspot.com/174083
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/178046
|
|
multi-line expressions with comments
Fixes issue 414.
R=rsc
http://codereview.appspot.com/179047
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/176062
Committer: Russ Cox <rsc@golang.org>
|
|
the previous fix.
R=rsc
http://codereview.appspot.com/178044
|
|
Fixes issue 425.
R=rsc
http://codereview.appspot.com/178043
|
|
1. If all data is exhausted using Read then a following Next will
fail as if it saw EOF. (Test case added.)
2. Seeking isn't always possible (i.e. sockets and pipes). Fallback
to read. (Test case added.)
3. Fix to readHeader (cleaner fix pointed out by rsc).
(TestReader modified.)
4. When Read has consumed all the data, don't try to read 0 bytes from reader.
In cases where tr.nb is zero we attempt to read zero bytes and thus
never see an EOF (this is most easily seen when the 'tar source' is
something like bytes.Buffer{} as opposed to os.File).
5. If write is used to the point of ErrWriteTooLong, allow additional file entries.
6. Make close work as expected. That is any further Write or
WriteHeader attempts will result in ErrWriteAfterClose.
Fixes issue 419.
R=rsc, dsymonds1
http://codereview.appspot.com/162062
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/174078
|
|
Andy Davis (individual CLA)
Arvindh Rajesh Tamilmani (individual CLA)
R=r
http://codereview.appspot.com/176067
|
|
R=rsc
CC=pwil3058
http://codereview.appspot.com/174087
|
|
to avoid growing unnecessarily.
R=rsc
CC=golang-dev
http://codereview.appspot.com/176071
|
|
R=dho, rsc
CC=r
http://codereview.appspot.com/176058
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/166080
Committer: Russ Cox <rsc@golang.org>
|
|
Doing rm -rf /pkg/.. blindly isn't nice. It could have
unintended consequences.
Secondly set bash to abort on (unexpected) errors.
R=dho, rsc
CC=golang-dev
http://codereview.appspot.com/176056
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/164049
Committer: Russ Cox <rsc@golang.org>
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/174077
|
|
Update units.y too.
Fixes issue 417.
R=rsc
CC=golang-dev
http://codereview.appspot.com/176063
|
|
trying to get alizses
to optimize
R=rsc
http://codereview.appspot.com/176061
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/174082
|
|
- no need to replace comments for stand-alone blocks
- always print string concatenations with interspersed "+"
(remove option)
- minor cleanups
R=rsc
http://codereview.appspot.com/174076
|
|
Fixes issue 89.
Fixes issue 92.
Fixes issue 118.
Fixes issue 182.
Fixes issue 328.
Fixes issue 340.
R=ken2, ken3
CC=golang-dev
http://codereview.appspot.com/172049
|
|
8g still needs fixing
R=rsc
http://codereview.appspot.com/176057
|
|
R=rsc
http://codereview.appspot.com/175046
Committer: Robert Griesemer <gri@golang.org>
|
|
R=rsc
http://codereview.appspot.com/175048
|