summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-12-02Runes: turn string into []intPeter Froehlich4-1/+116
Split: fixed typo in documentation R=rsc, r, r1 http://codereview.appspot.com/157170 Committer: Russ Cox <rsc@golang.org>
2009-12-02updated documentation for gofmtRobert Griesemer1-0/+2
R=rsc http://codereview.appspot.com/164085
2009-12-028g: discard tempalloc/tempfree experimentRuss Cox7-141/+61
in favor of tempname. allows optimizer to do more. unfortunately, optimizer seems to be broken; disable it. R=ken2 http://codereview.appspot.com/163091
2009-12-026g etc: groundwork for eliminating redundant bounds checks.Russ Cox7-22/+34
drop check in range over array. drop check in [256]array indexed by byte. R=ken2 http://codereview.appspot.com/163088
2009-12-02Add flag -tabindent to gofmt: forces use ofRobert Griesemer4-154/+191
tabs for indentation even if -spaces is set. Changes to gofmt: - added -tabindent flag - don't recompute parser and printer mode repeatedly Changes to go/printer: - provide new printing mode TabIndent Changes to tabwriter: - implement new mode TabIndent to use tabs independent of the actual padding character for leading empty columns - distinguish between minimal cell width and tab width (tabwidth is only used if the output contains tabs, minwidth and padding are always considered) - fixed and added more comments - some additional factoring By default, -tabindent is disabled and the default gofmt behavior is unchanged. By setting -spaces and -tabindent, gofmt will use tabs for indentation but do any other alignment with spaces. This permits a user to change the visible indentation by simply changing the editor's tab width and the code will remain properly aligned without the need to rerun gofmt. R=rsc http://codereview.appspot.com/163068
2009-12-02net: test and fix support for 0-length datagram packets.Russ Cox2-25/+39
Fixes issue 274. R=r CC=jonathan.r.hudson http://codereview.appspot.com/163072 Committer: Russ Cox <rsc@golang.org>
2009-12-02change the naming example from Vector to Ring due to loss of vector.New()Rob Pike1-5/+5
R=rsc CC=golang-dev http://codereview.appspot.com/164082
2009-12-02Add copy to the list of predeclared functions.Ian Lance Taylor1-1/+1
R=gri http://codereview.appspot.com/164081
2009-12-02gofmt: race condition in error reporting and setting exit codeFazlul Shahriar1-1/+4
How to reproduce: $ mkdir /tmp/foo $ cp /dev/null /tmp/foo/bar.go $ chmod -r /tmp/foo/bar.go $ gofmt /tmp/foo open /tmp/foo/bar.go: permission denied $ echo $? # should echo 2 0 $ Maybe you need to put a call to time.Sleep at the beginning of report(). R=gri CC=golang-dev http://codereview.appspot.com/164073 Committer: Robert Griesemer <gri@golang.org>
2009-12-02apply gofmt to json filesRobert Griesemer2-5/+3
R=rsc http://codereview.appspot.com/164071
2009-12-02fix segfault printing errors. add test case and improve messages.Rob Pike2-6/+41
Fixes issue 338. R=rsc CC=golang-dev http://codereview.appspot.com/163083
2009-12-02test that arrays work properly.Rob Pike1-4/+22
can't mix slices and arrays now; perhaps that should be a TODO R=rsc http://codereview.appspot.com/164079
2009-12-02codereview: move reviewers to cc line after submit,Russ Cox1-11/+18
so that the issue stops showing up on the per-reviewer dashboard page. R=r http://codereview.appspot.com/164075
2009-12-02time: another bug in SecondsToUTC.Russ Cox2-0/+26
added random test to look for more. Fixes issue 363. R=r, cw http://codereview.appspot.com/163071
2009-12-02Add Shutdown to 32-bit GNU/Linux build.Ian Lance Taylor1-0/+5
Submitting as a TBR to fix the build. R=dho, rsc http://codereview.appspot.com/164078 Committer: Russ Cox <rsc@golang.org>
2009-12-02 lxml.etree is the wrong location for this alt packageDevon H. O'Dell1-1/+1
on my linux machine this is the correct one. lxml.etree exists with an ElementTree class, but does not contain an .XML method. R=rsc http://codereview.appspot.com/163082 Committer: Russ Cox <rsc@golang.org>
2009-12-02xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3)Devon H. O'Dell1-1/+4
R=rsc CC=golang-dev http://codereview.appspot.com/164053 Committer: Russ Cox <rsc@golang.org>
2009-12-01time: fix handling of Jan 1 1601, 1201, 801, ...Russ Cox2-6/+7
R=r CC=hurtonm http://codereview.appspot.com/164074
2009-12-01net: fix netFD.Close racesDevon H. O'Dell5-75/+98
Fixes issue 271. Fixes issue 321. R=rsc, agl, cw CC=golang-dev http://codereview.appspot.com/163052 Committer: Russ Cox <rsc@golang.org>
2009-12-01explicitly catch attempt to decode into a value - must be a pointer to see ↵Rob Pike2-2/+20
the result. R=rsc http://codereview.appspot.com/163070
2009-12-01make io.ReadFile use Stat.Size as a hint for preallocationRob Pike1-1/+17
R=rsc CC=golang-dev http://codereview.appspot.com/163069
2009-12-01Add syscall.Shutdown to FreeBSD i386/amd64Devon H. O'Dell5-154/+173
Necessary for 163052 R=rsc CC=golang-dev http://codereview.appspot.com/164068 Committer: Russ Cox <rsc@golang.org>
2009-12-018g: Match sgen definition to declarationEvan Shaw1-1/+1
R=rsc CC=golang-dev http://codereview.appspot.com/164069 Committer: Russ Cox <rsc@golang.org>
2009-12-01FreeBSD needs #!/usr/bin/env bash (fixes broken build on FreeBSD)Devon H. O'Dell1-1/+1
R=gri http://codereview.appspot.com/163067 Committer: Robert Griesemer <gri@golang.org>
2009-12-01syscall: add Shutdown on OS X, add more constants in mkerror.shRuss Cox8-411/+526
R=dho CC=golang-dev http://codereview.appspot.com/163061
2009-12-01Add 'copy' as a Go builtin function for Vim syntax highlighter spec.David Symonds1-1/+1
R=rsc http://codereview.appspot.com/163049 Committer: Russ Cox <rsc@golang.org>
2009-12-01update package unicode to Unicode 5.2Rob Pike4-230/+609
R=rsc CC=golang-dev http://codereview.appspot.com/163062
2009-12-01gob: fix buildRuss Cox1-1/+1
TBR=r http://codereview.appspot.com/163064
2009-12-01Integrated feedback by Ken.Robert Griesemer1-39/+37
Easy stuff in this round, more to come. R=iant, rsc, r, ken2 http://codereview.appspot.com/163058
2009-12-01Explicitly return values where it's shadowing the parameter.Christopher Wedgwood1-8/+8
Bad returns noticed by "Devon H. O'Dell" <devon.odell@gmail.com>. Resolves Issue 360. R=rsc, dho, agl, agl1 CC=ukai http://codereview.appspot.com/163055 Committer: Adam Langley <agl@golang.org>
2009-12-018g: fix 386 floating point stack bugCharles L. Dorian3-5/+10
Also fixes issue 310 comment 5 error. Fixes issue 310. R=rsc http://codereview.appspot.com/163042 Committer: Russ Cox <rsc@golang.org>
2009-12-01more gob bugsRob Pike4-25/+69
1) need to send slice and array types (was only sending element types) 2) compatibleType needs to use decoder's type map R=rsc CC=golang-dev http://codereview.appspot.com/164062
2009-12-01make test.sh work againRobert Griesemer1-5/+6
R=rsc http://codereview.appspot.com/164059
2009-12-01A/C: add Charles L. DorianRuss Cox2-0/+2
R=r http://codereview.appspot.com/164060
2009-12-01Added Sven Almgren to AUTHORS and CONTRIBUTORSSven Almgren2-0/+2
R=rsc http://codereview.appspot.com/163053 Committer: Russ Cox <rsc@golang.org>
2009-12-01a couple of usage fixups in profRob Pike1-1/+7
R=rsc http://codereview.appspot.com/161050
2009-12-01gofmt: use os.Stdin instead of opening /dev/stdinFazlul Shahriar1-8/+18
Opening /dev/stdin can sometimes fail. For example, in the acme editor, executing "Edit ,|gofmt" fails with: open /dev/stdin: no such device or address Executing "Edit ,|ls -l /dev/stdin /proc/self/fd/0" gives: lrwxrwxrwx 1 root root 15 2009-09-07 02:17 /dev/stdin -> /proc/self/fd/0 lrwx------ 1 fhs users 64 2009-11-26 22:05 /proc/self/fd/0 -> socket:[5528230] (This is my first change, and I've signed the individual contributor license agreement.) R=rsc, gri CC=golang-dev http://codereview.appspot.com/162041 Committer: Robert Griesemer <gri@golang.org>
2009-12-01some godoc cleanup:Robert Griesemer5-109/+36
- simplified dealing with parse errors: no need to intersperse them in the source - improve visibility of highlighted identifiers by showing them in bold R=rsc http://codereview.appspot.com/163051
2009-11-30Fix typo in specFazlul Shahriar1-1/+1
R=golang-dev, rsc http://codereview.appspot.com/164052 Committer: Russ Cox <rsc@golang.org>
2009-11-30Syntax coloring and function navigation for BBEdit/TextWranglerAnthony Starks1-0/+65
R=rsc CC=agl1 http://codereview.appspot.com/154123 Committer: Russ Cox <rsc@golang.org>
2009-11-30Adding to AUTHORS and CONTRIBUTORS as per ↵Anthony Starks2-0/+2
http://golang.org/doc/contribute.html#copyright R=rsc http://codereview.appspot.com/163050 Committer: Russ Cox <rsc@golang.org>
2009-11-30change command-line argument to beRoger Peppe2-9/+13
unnamed, not require -n, in line with other entries. R=rsc CC=r http://codereview.appspot.com/162061 Committer: Russ Cox <rsc@golang.org>
2009-11-30Make tests run on systems missing time utilitySergey 'SnakE' Gromov1-1/+1
R=rsc CC=golang-dev http://codereview.appspot.com/164047 Committer: Russ Cox <rsc@golang.org>
2009-11-30Added my name to the AUTHORS and CONTRIBUTORS files.Adrian O'Grady2-0/+2
R=rsc http://codereview.appspot.com/157153 Committer: Russ Cox <rsc@golang.org>
2009-11-30A first stab at porting the XCB X11 protocol bindings to go.Tor Andersson6-0/+5344
The python script needs a checkout of xcb/proto to generate an xproto.go file, which together with xgb.go provide functions to access all of the core X11 protocol requests. I have included the generated file. Extensions and authentication methods are not implemented. R=r, rsc, nigeltao_golang http://codereview.appspot.com/162053 Committer: Russ Cox <rsc@golang.org>
2009-11-30json: Decode into native Go data structuresSergey 'SnakE' Gromov7-427/+271
This patch adds an ability to convert JSON-encoded data into a hierarchy of Go's native data types. R=rsc CC=golang-dev http://codereview.appspot.com/161060 Committer: Russ Cox <rsc@golang.org>
2009-11-30Typo in comment.Robert Griesemer1-1/+1
Fixes issue 358. R=rsc CC=r http://codereview.appspot.com/164043
2009-11-30sync.RWMutex: rewritten to add support for concurrent readers.Péter Szabó5-49/+202
Also made sync.xadd public to help testing sync.RWMutex. Also added unit tests for sync.RWMutex. R=rsc http://codereview.appspot.com/162044 Committer: Russ Cox <rsc@golang.org>
2009-11-30Added a method on UDPConn so they can actually send broadcast packets.Jonathan Wills1-1/+5
R=rsc http://codereview.appspot.com/162046 Committer: Russ Cox <rsc@golang.org>
2009-11-30a[b:len(a)] -> a[b:]Christopher Wedgwood2-7/+7
R=r, rsc CC=agl1 http://codereview.appspot.com/161070 Committer: Russ Cox <rsc@golang.org>
generated by cgit v1.2.3 (git 2.46.0) at 2025-09-07 19:43:11 +0000