summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2010-02-01Ignore the temporary files used for improved error messages.Ian Lance Taylor1-0/+3
R=rsc CC=golang-dev http://codereview.appspot.com/199047
2010-02-01Fix for gccgo, which uses a package prefix.Ian Lance Taylor1-3/+3
R=rsc CC=golang-dev http://codereview.appspot.com/198046
2010-02-01Match gccgo error messages.Ian Lance Taylor1-12/+12
I have to admit that "cannot use type p.T as type p.T" is a bit weak. 8g gives a similar error ("cannot use v1 (type p.T) as type p.T in assignment"). bug3.go:37:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:38:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:43:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:44:5: error: incompatible type in initialization (incompatible type for method ‘M’ (different parameter types)) bug3.go:49:5: error: incompatible types in assignment (cannot use type p.T as type p.T) bug3.go:50:5: error: incompatible types in assignment (cannot use type p.T as type p.T) bug3.go:55:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:56:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:57:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:58:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:59:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:60:5: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:61:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) bug3.go:62:6: error: incompatible types in assignment (incompatible type for method ‘M’ (different parameter types)) R=rsc CC=golang-dev http://codereview.appspot.com/199044
2010-02-01gc: final ...T bug for the dayRuss Cox4-5/+4
R=ken2 CC=golang-dev http://codereview.appspot.com/199046
2010-02-01Corrected broken assertion.Robert Griesemer2-2/+10
Fixes issue 571. R=rsc CC=golang-dev http://codereview.appspot.com/198045
2010-02-01don't report a couple of meaningless errors in command-line modeRobert Griesemer2-7/+8
R=rsc CC=golang-dev http://codereview.appspot.com/199045
2010-02-02Change type of Printf's args to ... interface{}Rob Pike15-141/+248
R=rsc CC=golang-dev http://codereview.appspot.com/197043
2010-02-01nacl: fix build, finally fixed 8l convergence bugRuss Cox7-8/+119
R=r CC=golang-dev http://codereview.appspot.com/199042
2010-02-01dashboard: avoid seeing cron's sh -c in ps checkRuss Cox1-1/+3
R=agl1 CC=golang-dev http://codereview.appspot.com/196091
2010-02-01http: test for ReadReqeustPetar Maymounkov1-0/+96
R=rsc, rsc1 CC=golang-dev http://codereview.appspot.com/195068 Committer: Russ Cox <rsc@golang.org>
2010-02-01gc: ... T corner casesRuss Cox7-5/+86
more to come, but should suffice for Printf work. R=ken2 CC=golang-dev http://codereview.appspot.com/197044
2010-02-01language FAQ entry on braces and semicolonsRob Pike1-0/+30
R=rsc, iant, gri CC=golang-dev http://codereview.appspot.com/196075
2010-02-01gc: add ... T, rework plain ...Russ Cox21-109/+360
No longer a distinct type; now a property of func types. R=ken2 CC=golang-dev http://codereview.appspot.com/197042
2010-02-01add link to go build dashboard.Rob Pike1-0/+3
break the list into two pieces R=golang-dev CC=golang-dev http://codereview.appspot.com/196088
2010-02-01Fix redirection if the page is in a subdirectory.Rob Pike1-0/+3
Fixes buggy links in the devel subdirectory. Code from rsc; tested by me. R=rsc, gri CC=golang-dev http://codereview.appspot.com/197041
2010-02-01the package global name space problem is addressed; update road mapRob Pike1-6/+0
R=rsc, iant CC=golang-dev http://codereview.appspot.com/196087
2010-01-31Fix expected string.Ian Lance Taylor1-1/+12
I got it wrong because gccgo was incorrectly failing to clear the value when a nonblocking receive did not receive anything. R=rsc CC=golang-dev http://codereview.appspot.com/194161
2010-01-30Match gccgo error messages.Ian Lance Taylor1-7/+7
bug238.go:11:7: error: invalid constant type bug238.go:12:7: error: invalid constant type bug238.go:13:7: error: invalid constant type bug238.go:14:7: error: invalid constant type bug238.go:15:7: error: invalid constant type bug238.go:16:7: error: invalid constant type bug238.go:17:7: error: invalid constant type R=rsc CC=golang-dev http://codereview.appspot.com/194159
2010-01-30New gccgo error message; match both compilers with one string.Ian Lance Taylor1-1/+1
8g: runtime.go:19: cannot refer to unexported name runtime.printbool gccgo: runtime.go:19:10: error: invalid reference to unexported identifier ‘runtime.printbool’ R=rsc CC=golang-dev http://codereview.appspot.com/194157
2010-01-30Match gccgo error message.Ian Lance Taylor1-1/+1
bug231.go:20:4: error: incompatible types in assignment (type has no methods) R=rsc CC=golang-dev http://codereview.appspot.com/194156
2010-01-29Recognize gccgo error messages.Ian Lance Taylor1-2/+2
bug228.go:11:25: error: invalid use of ‘...’ bug228.go:13:13: error: ‘...’ only permits one name bug228.go:15:20: error: ‘...’ must be last parameter bug228.go:17:7: error: expected type bug228.go:19:8: error: expected type R=rsc CC=golang-dev http://codereview.appspot.com/196077
2010-01-30Check gzip strings for NUL elements, since they are NUL-terminatedNigel Tao2-4/+4
on the wire. R=rsc CC=golang-dev http://codereview.appspot.com/194146
2010-01-30Add a GZIP test for the empty payload.Nigel Tao1-37/+57
R=rsc, r CC=golang-dev http://codereview.appspot.com/194131
2010-01-29http: increase header line limit, let req.Host override req.URL.HostPetar Maymounkov1-4/+11
Fixes issue 566. R=rsc CC=golang-dev http://codereview.appspot.com/194074 Committer: Russ Cox <rsc@golang.org>
2010-01-29Long-overdue update for semicolon change.Ian Lance Taylor1-62/+92
Fixes issue 485. R=r CC=golang-dev http://codereview.appspot.com/196071
2010-01-29The gccgo frontend has moved to a new repository.Ian Lance Taylor2-33/+78
Update the documents accordingly. Also document gccgo specific options. R=r CC=golang-dev http://codereview.appspot.com/196070
2010-01-29fix bug in tickRob Pike1-4/+5
Fixes issue 576. R=rsc, rog CC=golang-dev http://codereview.appspot.com/196061 Committer: Rob Pike <r@golang.org>
2010-01-29math: Change veryclose to close for Sinh and Exp tests.Devon H. O'Dell1-2/+2
Fixes issue 550. R=rsc CC=eds, golang-dev, jtomaschke http://codereview.appspot.com/196063 Committer: Russ Cox <rsc@golang.org>
2010-01-28two minor build fixesRuss Cox2-8/+8
Fixes issue 572. Fixes issue 570. R=r CC=golang-dev http://codereview.appspot.com/194134
2010-01-29move comment on StringHeader to fix godoc output.Rob Pike1-2/+3
R=rsc, ken2 CC=golang-dev http://codereview.appspot.com/196055
2010-01-28io: fix nil Write bug in PipeRuss Cox2-1/+23
R=nigeltao_golang CC=golang-dev http://codereview.appspot.com/194132
2010-01-28added StringHeader to reflectKen Thompson1-0/+5
R=rsc CC=golang-dev http://codereview.appspot.com/194133
2010-01-28avoid overflow of symb buffer in 5a/6a/8a/5c/6c/8cDean Prichard10-8/+56
R=rsc CC=golang-dev http://codereview.appspot.com/194099 Committer: Russ Cox <rsc@golang.org>
2010-01-29gzip deflater (i.e., writer).Nigel Tao6-25/+285
Also, the unused Inflater.eof field was removed. It has been unused since revision aaa0b24538. "introduce os.EOF and io.ErrUnexpectedEOF. remove io.ErrEOF." http://code.google.com/p/go/source/diff?spec=svnaaa0b24538ed1e3e54cbbfdd030a3c35785e74c5&r=aaa0b24538ed1e3e54cbbfdd030a3c35785e74c5&format=side&path=/src/pkg/compress/gzip/gunzip.go R=rsc CC=golang-dev http://codereview.appspot.com/194122
2010-01-28gc: tweak error messages, avoid internalization settings in bisonRuss Cox11-26/+30
R=r CC=golang-dev http://codereview.appspot.com/194129
2010-01-28http: add lexing functionsPetar Maymounkov3-0/+223
In particular, add field-value tokenizer which respects quoting rules. The code is intended for use in tokenizing the Transfer-Encoding and Trailer fields. The lexing function is not connected to the main parsing code yet (in the next CL). R=rsc CC=golang-dev http://codereview.appspot.com/190085 Committer: Russ Cox <rsc@golang.org>
2010-01-28Cosmetic bug or compliance fixes in http.Response.Petar Maymounkov2-15/+17
(1) http.Response must close resp.Body after writing. (2) Case when resp.Body != nil and resp.ContentLength = 0 should not be treated as an error in Response.Write, because this is what ReadResponse often returns. (3) Changed body.th to body.hdr for readability. R=rsc CC=golang-dev http://codereview.appspot.com/194084 Committer: Russ Cox <rsc@golang.org>
2010-01-29An experimental implemenation of Ticker using two goroutines for all tickers.Rob Pike1-63/+122
Feel free to suggest other approaches. R=rsc CC=cw, golang-dev http://codereview.appspot.com/193070
2010-01-28support for ...T parameters (go/* packages)Robert Griesemer8-14/+68
R=rsc CC=golang-dev http://codereview.appspot.com/194126
2010-01-28codereview: make sure each mail has a reviewerRuss Cox1-2/+10
R=r CC=golang-dev http://codereview.appspot.com/196050
2010-01-28dashboard: move key.py out of the way,Russ Cox1-0/+2
so that if you have a key.py with the real key, there is no chance hg change will accidentally make a CL with the real key and upload it to codereview. R=agl1 CC=golang-dev http://codereview.appspot.com/196051
2010-01-27Allow underscores in XML element names (except for leading characters)Michael Hoisie2-2/+24
Fixes issue 569 R=rsc, r CC=golang-dev http://codereview.appspot.com/194121 Committer: Rob Pike <r@golang.org>
2010-01-28Regularize the comments for the websocket package and document all functions ↵Rob Pike3-57/+69
and methods. R=rsc, ukai CC=golang-dev http://codereview.appspot.com/196044
2010-01-27release.2010-01-27, take 2Russ Cox0-0/+0
R=r CC=golang-dev http://codereview.appspot.com/196042
2010-01-27prepare for take 2 on release.2010-01-27Russ Cox0-0/+0
R=r CC=golang-dev http://codereview.appspot.com/194120
2010-01-27go/parser: disable scoping code alwaysRuss Cox1-1/+4
Seems to be enabled spuriously during godoc (can't see why), producing errors like: parser.parseDir: src/pkg/http/server.go:159:16: 'Write' declared already at src/pkg/http/request.go:140:21 (and 4 more errors) R=r CC=golang-dev http://codereview.appspot.com/194119
2010-01-27release.2010-01-27Russ Cox0-0/+0
R=r CC=golang-dev http://codereview.appspot.com/195081
2010-01-27prepare for release.2010-01-27Russ Cox1-0/+43
R=r CC=golang-dev http://codereview.appspot.com/195080
2010-01-27codereview: correct handling of files created with hg cpRuss Cox1-5/+2
R=r CC=golang-dev http://codereview.appspot.com/194118
2010-01-27ucsd cns talk, focused on networkingRuss Cox2-5/+458
R=r CC=golang-dev http://codereview.appspot.com/186230
generated by cgit v1.2.3 (git 2.39.1) at 2025-08-28 08:11:45 +0000