summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-11-15fix some typos in the documentationRob Pike3-5/+5
Fixes issue 196. R=rsc http://codereview.appspot.com/154152
2009-11-15fix bug in bytes.Map and add test cases for Map in both strings and bytes ↵Rob Pike3-3/+56
packages. thanks to ulrik.sverdrup for the test case. Fixes issue 191. R=rsc CC=golang-dev http://codereview.appspot.com/155056
2009-11-15Use // to start comment instead of #.Robert Griesemer1-4/+4
Fixes issue 189. R=r CC=rsc http://codereview.appspot.com/155055
2009-11-15cc: drop redundant strcpyRuss Cox1-2/+0
Fixes issue 192. R=ken2 http://codereview.appspot.com/155047
2009-11-14cc: eliminate two fixed-size buffersRuss Cox2-25/+25
Fixes bug 168. Alternative to http://codereview.appspot.com/152143. R=ken2 http://codereview.appspot.com/155042
2009-11-14complain if GOARCH != arm. fix build break caused by gomakeKai Backman1-0/+31
introduction. R=rsc http://codereview.appspot.com/152109
2009-11-14crypto/rsa: handle the case of non-coprime blinds.Adam Langley2-11/+26
We are dealing with the multiplicative group ℤ/pqℤ. Multiples of either p or q are not members of the group since they cannot have an inverse. (Such numbers are 0 in the subgroup ℤ/pℤ.) With p and q of typical size (> 512 bits), the probability of a random blind [1..pq-1] being a multiple of p or q is negligible. However, in the unit tests, much smaller sizes are used and the event could occur. This change checks the result of the ext GCD and deals with this case. It also increases the size of p and q in the unit test as a large number of the keys selected were p, q = 227,169. R=rsc CC=golang-dev http://codereview.appspot.com/154141 Committer: Russ Cox <rsc@golang.org>
2009-11-14make arm pass match what's working on real hardwareKai Backman1-41/+4
R=rsc http://codereview.appspot.com/154097
2009-11-14test/interface/receiver.go: expand to do dynamicRuss Cox1-0/+8
versions of static checks in receiver1.go R=r http://codereview.appspot.com/155045
2009-11-14Build changes to support work on the BSDs.Devon H. O'Dell20-48/+65
This does still contain some FreeBSD-specific bits, but it's a pain to do partial diffs. R=rsc http://codereview.appspot.com/152138 Committer: Russ Cox <rsc@golang.org>
2009-11-14Adding myself to AUTHORS/CONTRIBUTORS for Go.Devon H. O'Dell2-0/+2
R=rsc http://codereview.appspot.com/155041 Committer: Russ Cox <rsc@golang.org>
2009-11-14encoding/binary: implemented the Write functionMôshe van der Sterre2-18/+121
The ByteOrder.Put* methods are already available, this change uses them to implement the Write function. R=golang-dev, agl1, rsc, r http://codereview.appspot.com/152141 Committer: Russ Cox <rsc@golang.org>
2009-11-14Adding my name to CONTRIBUTORS and AUTHORSMôshe van der Sterre2-0/+2
As Adam Langley mentioned, this should go in with http://codereview.appspot.com/152141 R=rsc CC=agl1 http://codereview.appspot.com/154138 Committer: Russ Cox <rsc@golang.org>
2009-11-14gc: do not try to constant-evaluate (interface{})("bar")Russ Cox1-0/+1
Fixes issue 183. R=ken http://codereview.appspot.com/154139
2009-11-14move evaluation of null-matching instructions one iteration earlier.Rob Pike3-41/+61
performance hit of about 20% but more intuitive results for submatches. we need a good regexp package at some point. Fixes issue 110. R=rsc CC=golang-dev http://codereview.appspot.com/152131
2009-11-14 xml: Fixed CDATA parsing.Abhinav Gupta2-5/+9
Fixes issue 128. R=r, rsc http://codereview.appspot.com/154126 Committer: Russ Cox <rsc@golang.org>
2009-11-14Added self to AUTHORS and CONTRIBUTORS.Abhinav Gupta2-0/+2
R=rsc http://codereview.appspot.com/154128 Committer: Russ Cox <rsc@golang.org>
2009-11-14typosRuss Cox2-2/+2
Fixes issue 171. Fixes issue 172. R=agl1 http://codereview.appspot.com/154136
2009-11-13Created new Conn.Flush() public method so the fd pipeline can be drained ↵David Titarenco1-2/+10
arbitrarily by the user. Commented both flush methods so people know what they are looking at. This is a necessary fix for streaming and long polling HTTP services. Fixes issue 93. R=r, rsc, david.titarenco http://codereview.appspot.com/154099 Committer: Russ Cox <rsc@golang.org>
2009-11-13Added self to AUTHORS and CONTRIBUTORS prior to first submission.David Titarenco2-0/+4
R=rsc http://codereview.appspot.com/153057 Committer: Russ Cox <rsc@golang.org>
2009-11-13Remove unnecessary int(h) casts in image.go.Nigel Tao1-5/+5
R=rsc http://codereview.appspot.com/154125 Committer: Russ Cox <rsc@golang.org>
2009-11-13fix typoRob Pike1-1/+1
R=rsc http://codereview.appspot.com/152128
2009-11-13Correct indentation for go-mode where a close brace following a semi-James Aguilar1-4/+15
colon-less statement would be indented one stop too many. R=rsc, aclements CC=aclements http://codereview.appspot.com/154096 Committer: Russ Cox <rsc@golang.org>
2009-11-13Add myself to the contributors file.James Aguilar1-2/+5
R=rsc http://codereview.appspot.com/152101 Committer: Russ Cox <rsc@golang.org>
2009-11-13json: minor comment fix.Adam Langley1-1/+1
I screwed up and didn't write one of the code review changes to disk before submitting. TBR=rsc R=rsc http://codereview.appspot.com/154122
2009-11-13Explain whyRob Pike1-1/+6
-flag true does not work although -flag=true does. Fixes issue 139. R=iant CC=golang-dev http://codereview.appspot.com/154118
2009-11-13test/run: use bash, not sh.Russ Cox1-2/+2
use bash builtin time instead of assuming /usr/bin/time exists. R=r http://codereview.appspot.com/152124
2009-11-13json: allow one to unmarshal a top-level JSON array.Adam Langley2-2/+43
Fixies issue 114. R=rsc CC=golang-dev http://codereview.appspot.com/154121
2009-11-13path.TestWalk: disable error case if rootRuss Cox1-23/+25
(chmod 0 doesn't cause errors for root) Fixes issue 22. R=gri http://codereview.appspot.com/152120
2009-11-13json: fix addressing of slice indexes that are multiples of 8.Adam Langley2-1/+32
Fixes issue 147. R=rsc CC=golang-dev http://codereview.appspot.com/152123
2009-11-13runtime: warn about SELinux based mmap failures on Linux.Adam Langley5-5/+32
SELinux will cause mmap to fail when we request w+x memory unless the user has configured their policies. We have a warning in make.bash, but it's quite likely that the policy will be reset at some point and then all their binaries start failing. This patch prints a warning on Linux when mmap fails with EACCES. R=rsc CC=golang-dev http://codereview.appspot.com/152086
2009-11-12yet another attempt to avoid conflicts withRuss Cox10-10/+29
<stdio.h>, which we weren't even #including R=r http://codereview.appspot.com/154108
2009-11-12remove dead code from testRob Pike1-68/+8
R=rsc CC=golang-dev http://codereview.appspot.com/152118
2009-11-12sudo.bash tries to install acid and db, which don't exist any moreRob Pike1-1/+1
R=rsc CC=golang-dev http://codereview.appspot.com/152117
2009-11-12Teach emacs M-x gofmt to save region/restrictionsKevin Ballard1-1/+12
R=agl, agl1 http://codereview.appspot.com/152078 Committer: Adam Langley <agl@golang.org>
2009-11-12codereview: clpatch tweaksRuss Cox1-3/+7
R=agl1 http://codereview.appspot.com/152114
2009-11-12Remove -align flag from gofmt.Robert Griesemer2-6/+0
(Making it work correctly with -spaces is a bit of work and the output won't make much sense as it is intended as input to tabwriter.) Fixes issue 100. R=rsc http://codereview.appspot.com/154102
2009-11-12fix style nit ignored in previous clKai Backman1-1/+1
R=rsc http://codereview.appspot.com/152110
2009-11-12add support for pre arm v6 cas. set GOARM=5 to enable.Kai Backman3-1/+46
R=rsc http://codereview.appspot.com/154101
2009-11-12tag new release at 4015/cb140bac9ab0Russ Cox0-0/+0
R=r http://codereview.appspot.com/154100
2009-11-12test/run: unset GREP_OPTIONSRuss Cox1-0/+1
Fixes issue 116. R=r http://codereview.appspot.com/152106
2009-11-12os.TestSeek: use a smaller but still 64-bit seek offset.Russ Cox1-3/+8
Might fix issue 91. R=r http://codereview.appspot.com/152108
2009-11-12produce helpful error when gotest doesn't find a MakefileRob Pike1-2/+7
Fixes issue 117. R=rsc, agl1 CC=golang-dev http://codereview.appspot.com/152107
2009-11-12add a paragraph about semicolons to the tutorial.Rob Pike4-3/+25
fix a typo caught by kakugawa@gmail.com Fixes issue 92. R=rsc CC=golang-dev http://codereview.appspot.com/152105
2009-11-12exp/draw: correct Makefile.Adam Langley1-1/+1
Thanks to Allister Macleod Fixes issue 112. R=rsc CC=golang-dev http://codereview.appspot.com/152102
2009-11-12fix a couple of typos.Rob Pike3-5/+37
add a mention of range to the tutorial. change tutorial's title. R=rsc CC=golang-dev http://codereview.appspot.com/152098
2009-11-12cc, ld: fix more gcc 4.3 -O2 compile bugsRuss Cox3-6/+5
same as http://codereview.appspot.com/152088 in more files. Fixes issue 83. R=r, r1 http://codereview.appspot.com/152091
2009-11-11 add cache flushing call after generating closure.Kai Backman2-0/+15
go/test: passes 88% (306/347) R=rsc http://codereview.appspot.com/152089
2009-11-11avoid seg fault when return type is unknownRuss Cox1-0/+5
Fixes issue 80. R=ken http://codereview.appspot.com/154079
2009-11-11gopack: work around gcc bug in hash functionRuss Cox1-3/+10
Fixes issue 48. (this time for sure!) R=r, r1 http://codereview.appspot.com/152088