summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2009-11-30AUTHORS/CONTRIBUTORS: two more namesRuss Cox2-0/+5
R=r, SnakE CC=fhs, pts http://codereview.appspot.com/162054
2009-11-29Fix example Makefile to avoid $GOROOT in case it has spaces.Fumitoshi Ukai1-2/+5
R=rsc, sergio http://codereview.appspot.com/162058 Committer: Russ Cox <rsc@golang.org>
2009-11-29websocket: avoid $GOROOT in case it has spacesRuss Cox1-2/+2
Fixes issue 115. R=r, ukai, sergio http://codereview.appspot.com/162057
2009-11-29crypto/md4, exp/draw/x11: fix makefile to build when GOROOT has whitespacesSergio Luis O. B. Correia2-4/+4
this is the exact same thing issue #115 is about. fix makefiles to use relative path to work in the case we have whitespaces as part of GOROOT. R=rsc http://codereview.appspot.com/162055 Committer: Russ Cox <rsc@golang.org>
2009-11-29cgo: use C type void for opaque types if dwarf.Common().Type returns nothingEden Li1-0/+3
Ideally, the C name would come from the typedef or pointer that references the Size<0 type, but we can't easily generate this without performing a look-ahead to see if any referencing type will become opaque. Fixes issue 334. Fixes issue 281. R=rsc http://codereview.appspot.com/161056 Committer: Russ Cox <rsc@golang.org>
2009-11-29Add WebSocket server framework hooked into http.Fumitoshi Ukai6-0/+418
R=r, rsc http://codereview.appspot.com/156071 Committer: Russ Cox <rsc@golang.org>
2009-11-29Make comment-start/-end changes buffer-local instead of global.Austin Clements1-2/+2
Fixes issue 290. R=rsc http://codereview.appspot.com/160070 Committer: Russ Cox <rsc@golang.org>
2009-11-29Add myself to CONTRIBUTORSFumitoshi Ukai1-0/+1
R=r, rsc http://codereview.appspot.com/156070 Committer: Russ Cox <rsc@golang.org>
2009-11-29Correct expression level for argument lists.Robert Griesemer2-0/+3
Fixes issue 352. R=rsc http://codereview.appspot.com/161073
2009-11-25a few utf8 benchmarks. on my mac:Rob Pike1-0/+40
utf8_test.BenchmarkRuneCountTenASCIIChars 20000000 108 ns/op utf8_test.BenchmarkRuneCountTenJapaneseChars 10000000 199 ns/op utf8_test.BenchmarkEncodeASCIIRune 500000000 6 ns/op utf8_test.BenchmarkEncodeJapaneseRune 100000000 10 ns/op utf8_test.BenchmarkDecodeASCIIRune 100000000 13 ns/op utf8_test.BenchmarkDecodeJapaneseRune 100000000 21 ns/op R=gri CC=golang-dev http://codereview.appspot.com/161049
2009-11-25rewrite RuneCountInString to use range.Rob Pike1-12/+4
R=gri CC=golang-dev http://codereview.appspot.com/160069
2009-11-25Initial exp/draw/x11 implementation.Nigel Tao3-0/+629
This provides an experimental X11 backend for the exp/draw interface. It does not aim to provide a complete implementation of the X11 client protocol. This works for me (Ubuntu Hardy 8.04, GOARCH=386). Your mileage my vary. R=r, rsc, r1 CC=golang-dev http://codereview.appspot.com/156109
2009-11-24fix weird all.bash failures by running deps.bash before make clean runs in ↵Rob Pike2-4/+7
pkg directory. before this change, if pkg/Make.deps is missing or broken, clean.bash fails and the build dies but not until much later. add freebsd to error message about valid values of $GOOS TODO: would be nice if this process exited when an error occurred. subshells make it hard R=rsc CC=golang-dev http://codereview.appspot.com/160065
2009-11-24Handle presence of illegal semicolon after package clause better.Robert Griesemer1-0/+8
R=r, r1 http://codereview.appspot.com/157167
2009-11-24Replace sort.Sort call with heapify algorithm in Init.Robert Griesemer2-17/+103
Fixed package comment. Renamed some variables for symmetry, added more internal comments and more tests. Fixes issue 304. R=rsc http://codereview.appspot.com/157166
2009-11-24gc: correct type check for x, ok map assignmentRuss Cox2-1/+15
Fixes issue 288. R=ken2 http://codereview.appspot.com/157162
2009-11-24make.bash: clear CDPATH to avoid output from cdRuss Cox1-0/+2
Fixes issue 306. R=r, r1 http://codereview.appspot.com/160060
2009-11-24add freebsd to the list of os'es.Rob Pike1-8/+33
make the GOOS/GOARCH pair a table to avoid the confusion caused when it was of the form linux/386. R=rsc CC=golang-dev http://codereview.appspot.com/160061
2009-11-24test case for large angles in trig functionsKen Thompson1-0/+37
R=rsc http://codereview.appspot.com/157160
2009-11-24bad sin/cos for large angles.Ken Thompson1-1/+1
fixes issue 326. R=rsc http://codereview.appspot.com/160059
2009-11-24timing log update for new version of chameneosRob Pike1-0/+8
R=rsc CC=golang-dev, rog http://codereview.appspot.com/160054
2009-11-24fix for broken build (built-in new was invisible due to a parameter called ↵Robert Griesemer1-6/+6
'new') R=iant http://codereview.appspot.com/160057
2009-11-24change the rules for maintaining AUTHORS and CONTRIBUTORS files.Rob Pike1-11/+27
the current system is too painful, so instead let's just have the coders tell us the details. we can update the files ourselves. R=rsc, r1 CC=golang-dev http://codereview.appspot.com/157158
2009-11-24Change to container/vector interface:Robert Griesemer25-165/+195
- removed New(len int) in favor of new(Vector).Resize(len, cap) - removed Init(len int) in favor of Resize(len, cap) - runs all.bash Fixes issue 294. R=rsc, r, r1 http://codereview.appspot.com/157143
2009-11-24Mention golang-dev as a default code review destination.Ian Lance Taylor1-0/+4
R=rsc CC=r http://codereview.appspot.com/160056
2009-11-24godoc: plug file descriptor leakRuss Cox1-0/+1
R=gri CC=r http://codereview.appspot.com/157149
2009-11-24A quick fix to ensure that json.Marshal returns errors correctly, as well as ↵Michael Hoisie2-5/+34
some error-related tests R=rsc http://codereview.appspot.com/157151 Committer: Russ Cox <rsc@golang.org>
2009-11-24http: redirect to correct URLRuss Cox1-4/+3
R=r, r1 http://codereview.appspot.com/157154
2009-11-24chameneosredux test modified, bug fixed, fasterRoger Peppe1-133/+106
based on suggestion from arvindht@gmail.com R=r, rsc, r1 http://codereview.appspot.com/157091 Committer: Russ Cox <rsc@golang.org>
2009-11-24add Roger Peppe to AUTHORS/CONTRIBUTORSRuss Cox2-0/+2
R=r http://codereview.appspot.com/157157
2009-11-24add Take, TakeWhile, Drop, DropWhile to exp/iterableMichael Elkins2-0/+134
R=dsymonds1, rsc http://codereview.appspot.com/156079 Committer: Russ Cox <rsc@golang.org>
2009-11-24Adding myself to AUTHORS/CONTRIBUTORS as a result of ↵Michael Elkins2-0/+2
http://codereview.appspot.com/156079 R=golang-dev, rsc CC=r http://codereview.appspot.com/157072 Committer: Russ Cox <rsc@golang.org>
2009-11-24print error's string when panicking.Rob Pike1-1/+1
R=rsc http://codereview.appspot.com/157156
2009-11-24Add benchmarks for commonly used routines.Trevor Strohman7-6/+176
R=rsc, r, r1 http://codereview.appspot.com/160046 Committer: Russ Cox <rsc@golang.org>
2009-11-23 cgo translates empty function arguments into void instead of dying with ↵Eden Li1-0/+9
'unexpected type: ...'. Fixes issue 162. R=rsc http://codereview.appspot.com/157147 Committer: Russ Cox <rsc@golang.org>
2009-11-23json: expose map in generic representationRuss Cox2-0/+7
R=r, r1 http://codereview.appspot.com/157146
2009-11-23Provides implementation of MD4 hashing algorithm.Chris Lennert5-0/+279
See IETF RFC 1320, http://tools.ietf.org/html/rfc1320. Fixes issue 279. R=rsc http://codereview.appspot.com/159051 Committer: Russ Cox <rsc@golang.org>
2009-11-23Added my name to the AUTHORS and CONTRIBUTORS lists.Chris Lennert2-0/+2
R=rsc http://codereview.appspot.com/160047 Committer: Russ Cox <rsc@golang.org>
2009-11-23add an FAQ entry about the logo and mascotRob Pike1-0/+15
R=rsc CC=golang-dev, reneefrench http://codereview.appspot.com/157144
2009-11-23go: makes it build for the case $GOROOT has whitespacesSergio Luis O. B. Correia135-294/+310
the bash scripts and makefiles for building go didn't take into account the fact $GOROOT / $GOBIN could both be directories containing whitespaces, and was not possible to build it in such a situation. this commit adjusts the various makefiles/scripts to make it aware of that possibility, and now it builds successfully when using a path with whitespaces as well. Fixes issue 115. R=rsc, dsymonds1 http://codereview.appspot.com/157067 Committer: Russ Cox <rsc@golang.org>
2009-11-23cmd/cc: change getquoted() to accept whitespaces.Sergio Luis O. B. Correia1-1/+1
getquoted() currently checks for whitespaces and returns nil if it finds one. this prevents us from having go in a path containing whitespaces, as the #pragma dynld directives are processed through the said function. this commit makes getquoted() accept whitespaces, and this is also needed for solving issue #115. R=rsc http://codereview.appspot.com/157066 Committer: Russ Cox <rsc@golang.org>
2009-11-23gofmt -r: documentation and minor fixesRuss Cox3-29/+67
fix a few paren insertion bugs in the printer too. R=gri, r CC=golang-dev http://codereview.appspot.com/157119
2009-11-23 Fix crash in xml.Unmarshal. Occasionally while running a scrape of some xml ↵Vish Subramanian1-1/+1
with many goroutines I see a crash with the following stack trace: SIGSEGV: segmentation violation Faulting address: 0x44 PC=0x44e510 runtime·mapaccess2+0x18 /home/vish/go/src/pkg/runtime/hashmap.c:790 runtime·mapaccess2(0x0, 0x0) xml·*Parser·text+0x922 /home/vish/go/src/pkg/xml/xml.go:765 xml·*Parser·text(0xe44c9870, 0x7fa3, 0xffffffff, 0x7f00, 0x44b5c4, ...) xml·*Parser·RawToken+0x174 /home/vish/go/src/pkg/xml/xml.go:405 xml·*Parser·RawToken(0xe44c9870, 0x7fa3, 0x0, 0x0) xml·*Parser·Token+0x625 /home/vish/go/src/pkg/xml/xml.go:205 xml·*Parser·Token(0xe44c9870, 0x7fa3, 0x0, 0x0, 0x0, ...) xml·*Parser·Skip+0x27 /home/vish/go/src/pkg/xml/read.go:371 xml·*Parser·Skip(0xe44c9870, 0x7fa3, 0x8, 0x0) xml·*Parser·unmarshal+0xae6 /home/vish/go/src/pkg/xml/read.go:328 xml·*Parser·unmarshal(0xe44c9870, 0x7fa3, 0xe8127120, 0x7fa3, 0xdc94bc40, ...) xml·Unmarshal+0xda /home/vish/go/src/pkg/xml/read.go:121 xml·Unmarshal(0xe65724b0, 0x7fa3, 0xdc94bc00, 0x7fa3, 0x4bcfc0, ...) scraper·DoSearch+0x3d1 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scraper.go:95 scraper·DoSearch(0xe7dc28c0, 0x7fa3, 0x33, 0x3, 0x6d2510, ...) main·scrapeQueries+0x202 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scrape.go:251 main·scrapeQueries(0xe7da2600, 0x7fa3, 0x64, 0x1db0, 0xe7e10000, ...) goexit /home/vish/go/src/pkg/runtime/proc.c:135 goexit() 0x7fa3e7da2600 unknown pc Clearly xml.Parser is accessing an uninitialized map. Add a check for a nil map before accessing it. R=r, rsc http://codereview.appspot.com/159050 Committer: Russ Cox <rsc@golang.org>
2009-11-23two more if(h<0) that gcc 4.3 -O2 miscompilesRuss Cox2-5/+2
R=r http://codereview.appspot.com/160044
2009-11-23io.ReadWriter: fix doc comment (ReadWrite -> ReadWriter)Russ Cox1-1/+1
R=r CC=eds http://codereview.appspot.com/160045
2009-11-23fix bug in prefix code: must stop one character before any potential match ↵Rob Pike2-3/+8
of an empty string Fixes issue 308. R=rsc CC=golang-dev http://codereview.appspot.com/157142
2009-11-23Fix doc striing for NewReadLogger.Rob Pike1-2/+2
Fixes issue 315. R=rsc http://codereview.appspot.com/157140
2009-11-238g: call throwindex for array out of boundsRuss Cox1-4/+2
R=ken2 http://codereview.appspot.com/160043
2009-11-21crypto/tls: add initial client implementation.Adam Langley9-7/+439
R=rsc, agl CC=golang-dev http://codereview.appspot.com/157076
2009-11-20mention arrays of arrays and slices of slicesRob Pike1-0/+11
Fixes issue 113. R=gri, rsc CC=golang-dev http://codereview.appspot.com/159049