Age | Commit message (Collapse) | Author | Files | Lines |
|
R=r, SnakE
CC=fhs, pts
http://codereview.appspot.com/162054
|
|
R=rsc, sergio
http://codereview.appspot.com/162058
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 115.
R=r, ukai, sergio
http://codereview.appspot.com/162057
|
|
this is the exact same thing issue #115 is about. fix makefiles to use relative
path to work in the case we have whitespaces as part of GOROOT.
R=rsc
http://codereview.appspot.com/162055
Committer: Russ Cox <rsc@golang.org>
|
|
Ideally, the C name would come from the typedef or pointer that
references the Size<0 type, but we can't easily generate this without
performing a look-ahead to see if any referencing type will become opaque.
Fixes issue 334.
Fixes issue 281.
R=rsc
http://codereview.appspot.com/161056
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, rsc
http://codereview.appspot.com/156071
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 290.
R=rsc
http://codereview.appspot.com/160070
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, rsc
http://codereview.appspot.com/156070
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 352.
R=rsc
http://codereview.appspot.com/161073
|
|
utf8_test.BenchmarkRuneCountTenASCIIChars 20000000 108 ns/op
utf8_test.BenchmarkRuneCountTenJapaneseChars 10000000 199 ns/op
utf8_test.BenchmarkEncodeASCIIRune 500000000 6 ns/op
utf8_test.BenchmarkEncodeJapaneseRune 100000000 10 ns/op
utf8_test.BenchmarkDecodeASCIIRune 100000000 13 ns/op
utf8_test.BenchmarkDecodeJapaneseRune 100000000 21 ns/op
R=gri
CC=golang-dev
http://codereview.appspot.com/161049
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/160069
|
|
This provides an experimental X11 backend for the exp/draw interface.
It does not aim to provide a complete implementation of the X11 client protocol.
This works for me (Ubuntu Hardy 8.04, GOARCH=386). Your mileage my vary.
R=r, rsc, r1
CC=golang-dev
http://codereview.appspot.com/156109
|
|
pkg directory.
before this change, if pkg/Make.deps is missing or broken, clean.bash fails and the build dies
but not until much later.
add freebsd to error message about valid values of $GOOS
TODO: would be nice if this process exited when an error occurred. subshells make it hard
R=rsc
CC=golang-dev
http://codereview.appspot.com/160065
|
|
R=r, r1
http://codereview.appspot.com/157167
|
|
Fixed package comment.
Renamed some variables for symmetry, added more internal comments and more tests.
Fixes issue 304.
R=rsc
http://codereview.appspot.com/157166
|
|
Fixes issue 288.
R=ken2
http://codereview.appspot.com/157162
|
|
Fixes issue 306.
R=r, r1
http://codereview.appspot.com/160060
|
|
make the GOOS/GOARCH pair a table to avoid the confusion caused when it was of the form linux/386.
R=rsc
CC=golang-dev
http://codereview.appspot.com/160061
|
|
R=rsc
http://codereview.appspot.com/157160
|
|
fixes issue 326.
R=rsc
http://codereview.appspot.com/160059
|
|
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/160054
|
|
'new')
R=iant
http://codereview.appspot.com/160057
|
|
the current system is too painful, so instead let's just have the coders tell us the details.
we can update the files ourselves.
R=rsc, r1
CC=golang-dev
http://codereview.appspot.com/157158
|
|
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes issue 294.
R=rsc, r, r1
http://codereview.appspot.com/157143
|
|
R=rsc
CC=r
http://codereview.appspot.com/160056
|
|
R=gri
CC=r
http://codereview.appspot.com/157149
|
|
some error-related tests
R=rsc
http://codereview.appspot.com/157151
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, r1
http://codereview.appspot.com/157154
|
|
based on suggestion from arvindht@gmail.com
R=r, rsc, r1
http://codereview.appspot.com/157091
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
http://codereview.appspot.com/157157
|
|
R=dsymonds1, rsc
http://codereview.appspot.com/156079
Committer: Russ Cox <rsc@golang.org>
|
|
http://codereview.appspot.com/156079
R=golang-dev, rsc
CC=r
http://codereview.appspot.com/157072
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/157156
|
|
R=rsc, r, r1
http://codereview.appspot.com/160046
Committer: Russ Cox <rsc@golang.org>
|
|
'unexpected type: ...'.
Fixes issue 162.
R=rsc
http://codereview.appspot.com/157147
Committer: Russ Cox <rsc@golang.org>
|
|
R=r, r1
http://codereview.appspot.com/157146
|
|
See IETF RFC 1320, http://tools.ietf.org/html/rfc1320.
Fixes issue 279.
R=rsc
http://codereview.appspot.com/159051
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/160047
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev, reneefrench
http://codereview.appspot.com/157144
|
|
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes issue 115.
R=rsc, dsymonds1
http://codereview.appspot.com/157067
Committer: Russ Cox <rsc@golang.org>
|
|
getquoted() currently checks for whitespaces and returns nil
if it finds one. this prevents us from having go in a path
containing whitespaces, as the #pragma dynld directives are
processed through the said function.
this commit makes getquoted() accept whitespaces, and this is
also needed for solving issue #115.
R=rsc
http://codereview.appspot.com/157066
Committer: Russ Cox <rsc@golang.org>
|
|
fix a few paren insertion bugs in the printer too.
R=gri, r
CC=golang-dev
http://codereview.appspot.com/157119
|
|
with many goroutines
I see a crash with the following stack trace:
SIGSEGV: segmentation violation
Faulting address: 0x44
PC=0x44e510
runtime·mapaccess2+0x18 /home/vish/go/src/pkg/runtime/hashmap.c:790
runtime·mapaccess2(0x0, 0x0)
xml·*Parser·text+0x922 /home/vish/go/src/pkg/xml/xml.go:765
xml·*Parser·text(0xe44c9870, 0x7fa3, 0xffffffff, 0x7f00, 0x44b5c4, ...)
xml·*Parser·RawToken+0x174 /home/vish/go/src/pkg/xml/xml.go:405
xml·*Parser·RawToken(0xe44c9870, 0x7fa3, 0x0, 0x0)
xml·*Parser·Token+0x625 /home/vish/go/src/pkg/xml/xml.go:205
xml·*Parser·Token(0xe44c9870, 0x7fa3, 0x0, 0x0, 0x0, ...)
xml·*Parser·Skip+0x27 /home/vish/go/src/pkg/xml/read.go:371
xml·*Parser·Skip(0xe44c9870, 0x7fa3, 0x8, 0x0)
xml·*Parser·unmarshal+0xae6 /home/vish/go/src/pkg/xml/read.go:328
xml·*Parser·unmarshal(0xe44c9870, 0x7fa3, 0xe8127120, 0x7fa3, 0xdc94bc40, ...)
xml·Unmarshal+0xda /home/vish/go/src/pkg/xml/read.go:121
xml·Unmarshal(0xe65724b0, 0x7fa3, 0xdc94bc00, 0x7fa3, 0x4bcfc0, ...)
scraper·DoSearch+0x3d1 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scraper.go:95
scraper·DoSearch(0xe7dc28c0, 0x7fa3, 0x33, 0x3, 0x6d2510, ...)
main·scrapeQueries+0x202 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scrape.go:251
main·scrapeQueries(0xe7da2600, 0x7fa3, 0x64, 0x1db0, 0xe7e10000, ...)
goexit /home/vish/go/src/pkg/runtime/proc.c:135
goexit()
0x7fa3e7da2600 unknown pc
Clearly xml.Parser is accessing an uninitialized map. Add a check for a nil map before accessing it.
R=r, rsc
http://codereview.appspot.com/159050
Committer: Russ Cox <rsc@golang.org>
|
|
R=r
http://codereview.appspot.com/160044
|
|
R=r
CC=eds
http://codereview.appspot.com/160045
|
|
of an empty string
Fixes issue 308.
R=rsc
CC=golang-dev
http://codereview.appspot.com/157142
|
|
Fixes issue 315.
R=rsc
http://codereview.appspot.com/157140
|
|
R=ken2
http://codereview.appspot.com/160043
|
|
R=rsc, agl
CC=golang-dev
http://codereview.appspot.com/157076
|
|
Fixes issue 113.
R=gri, rsc
CC=golang-dev
http://codereview.appspot.com/159049
|