Age | Commit message (Collapse) | Author | Files | Lines |
|
Fixes issue 452.
R=gri
CC=golang-dev, dougfelt
http://codereview.appspot.com/181043
|
|
as it is not needed anymore (only one impl.
of vector package).
Makefile, vector_test.go, and nogen_test.go
were modified manually (find/replace), the
other files (intvector_test.go, strinvector_test.go
are generated).
Runs all tests.
R=r
http://codereview.appspot.com/182041
|
|
Manual changes to the following files:
src/pkg/Makefile
src/pkg/exp/vector/Makefile (now: src/pkg/container/vector/Makefile)
R=rsc, r
CC=golang-dev
http://codereview.appspot.com/181041
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/180108
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/179130
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/180118
|
|
- use an interface {Get()}
- implement Get for maps, slices
- for slices, retrieves the address of the end of the array, which will give the
same value for every slice of the same array.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179129
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/179128
|
|
(Also fix case sensitivity in test for PTR inside fmt_test.go)
Fixes issue 441.
R=rsc, iant
CC=golang-dev
http://codereview.appspot.com/180112
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/179120
|
|
R=gri
CC=rsc
http://codereview.appspot.com/178048
Committer: Robert Griesemer <gri@golang.org>
|
|
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/179118
|
|
Fixes issue 436.
R=ken2
http://codereview.appspot.com/180105
|
|
R=dho
CC=golang-dev
http://codereview.appspot.com/180099
|
|
gccgo currently fails this test.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179108
|
|
R=ken2
http://codereview.appspot.com/180092
|
|
corrects a common misunderstanding about NewBuffer.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179106
|
|
(Thanks to ken and rsc for pointing this out)
rsc:
ken pointed out that there's a race in the new
one-lock-per-channel code. the issue is that
if one goroutine has gone to sleep doing
select {
case <-c1:
case <-c2:
}
and then two more goroutines try to send
on c1 and c2 simultaneously, the way that
the code makes sure only one wins is the
selgen field manipulation in dequeue:
// if sgp is stale, ignore it
if(sgp->selgen != sgp->g->selgen) {
//prints("INVALID PSEUDOG POINTER\n");
freesg(c, sgp);
goto loop;
}
// invalidate any others
sgp->g->selgen++;
but because the global lock is gone both
goroutines will be fiddling with sgp->g->selgen
at the same time.
This results in a 7% slowdown in the single threaded case for a
ping-pong microbenchmark.
Since the cas predominantly succeeds, adding a simple check first
didn't make any difference.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180068
|
|
now that the parser doesn't do this test anymore
R=rsc
CC=golang-dev
http://codereview.appspot.com/179105
|
|
added more test cases
some capitalization cleanups
R=rsc
CC=golang-dev
http://codereview.appspot.com/180085
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/179099
|
|
R=dho, phf
CC=golang-dev
http://codereview.appspot.com/180082
|
|
Fixes issue 443.
R=dho
CC=golang-dev
http://codereview.appspot.com/179095
|
|
them in the stream.
R=rsc
http://codereview.appspot.com/174052
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/179096
|
|
R=ken2
CC=dho
http://codereview.appspot.com/179097
|
|
leading tabs into spaces to ensure a good outcome in
most browsers
R=rsc
http://codereview.appspot.com/165051
|
|
Fixes issue 431.
R=r, rsc
CC=golang-dev
http://codereview.appspot.com/179079
Committer: Russ Cox <rsc@golang.org>
|
|
R=gri
CC=golang-dev
http://codereview.appspot.com/180081
|
|
Fixes issue 342.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179062
Committer: Russ Cox <rsc@golang.org>
|
|
structs containing bitfields.
Fixes issue 163.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180059
Committer: Russ Cox <rsc@golang.org>
|
|
source for xproto.go.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180074
Committer: Russ Cox <rsc@golang.org>
|
|
most signals, so that ordinary programs
can be killed, for example.
Fixes issue 434.
R=dsymonds1
CC=golang-dev, hoisie
http://codereview.appspot.com/180064
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/180075
|
|
Allows stand-alone types (e.g. []int as patterns) and doesn't require
a semicolon at the end (which are now mandatory terminators).
- Fix a matcher bug.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179088
|
|
This is not a complete JPEG implementation (e.g. it does not handle
progressive JPEGs or restart markers), but I was able to take a photo
with my phone, and view the resultant JPEG in pure Go.
The decoder is simple, but slow. The Huffman decoder in particular
should be easily improvable, but optimization is left to future
changelists. Being able to inline functions in the inner loop should
also help performance.
The output is not pixel-for-pixel identical to libjpeg, although
identical behavior isn't necessarily a goal, since JPEG is a lossy
codec. There are at least two reasons for the discrepancy.
First, the inverse DCT algorithm used is the same as Plan9's
src/cmd/jpg, which has different rounding errors from libjpeg's
default IDCT implementation. Note that libjpeg actually has three
different IDCT implementations: one floating point, and two fixed
point. Out of those four, Plan9's seemed the simplest to understand,
partly because it has no #ifdef's or C macros.
Second, for 4:2:2 or 4:2:0 chroma sampling, this implementation does
nearest neighbor upsampling, compared to libjpeg's triangle filter
(e.g. see h2v1_fancy_upsample in jdsample.c).
The difference from the first reason is typically zero, but sometimes
1 (out of 256) in YCbCr space, or double that in RGB space. The
difference from the second reason can be as large as 8/256 in YCbCr
space, in regions of steep chroma gradients. Informal eyeballing
suggests that the net difference is typically imperceptible, though.
R=r
CC=golang-dev, rsc
http://codereview.appspot.com/164056
|
|
Also adds Development heading on navbar, with Roadmap being
the only current entry.
R=r
CC=golang-dev
http://codereview.appspot.com/180069
|
|
in parser's ParsePkgFile and ParsePackage functions.
R=rsc
CC=golang-dev, rog
http://codereview.appspot.com/180070
|
|
Fixes issue 389.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180061
|
|
into consts in the resulting Go source. Previously known as issue 161047,
which I deleted accidentally. Fixes issue 207.
R=rsc
http://codereview.appspot.com/166059
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
http://codereview.appspot.com/176070
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc, r, phf
CC=golang-dev
http://codereview.appspot.com/170046
Committer: Russ Cox <rsc@golang.org>
|
|
R=rsc
CC=golang-dev
http://codereview.appspot.com/176064
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 422.
R=r
CC=golang-dev
http://codereview.appspot.com/180057
|
|
Fixes issue 71.
R=rsc, r
http://codereview.appspot.com/162056
Committer: Russ Cox <rsc@golang.org>
|
|
Fixes issue 433.
R=rsc
CC=golang-dev
http://codereview.appspot.com/179072
|
|
Fixes issue 405.
R=r
CC=golang-dev, hoisie
http://codereview.appspot.com/180056
|
|
eliminate all tab characters while we're here.
R=rsc
CC=golang-dev
http://codereview.appspot.com/180055
|
|
use Int31n in Intn when possible.
Fixes issue 390.
(using 8g)
Intn1000 50000000 38 ns/op
Int31n1000 50000000 39 ns/op
Int63n1000 20000000 114 ns/op
R=r
CC=golang-dev, skybrian
http://codereview.appspot.com/180054
|
|
R=r
CC=golang-dev
http://codereview.appspot.com/180046
|